Unterminated string constant-javascript

[hemantbasva]

i have written a the following javascript code to copy data onto clipboard but i am getting error
Unterminated string constant

code in cs file

if (lblProcedureID != null)
                    {
                        lnkHold.Attributes.Add("onclick", "javascript:copyText('Procedure Id-" + lblProcedureID.Text + " Proceudre Title-" + ProcedureTitle.Text + " Procedure Description-" + ProcedureDesc.Value + "');"); 
                        //lnkHold.Attributes.Add("onclick", "javascript:copyText('" + (ProcedureDesc.Value).ToString() + "');");

}

javascript in aspx file

<script type="text/javascript" language="javascript">
            function copyText(copyDivText) 
            {
                //var copyDivText = document.getElementById('labelclipboard').value;
                window.clipboardData.clearData();
                var returnVal = window.clipboardData.setData('Text', copyDivText); 
                alert("Procedure details copied"); 
            }
    </script>

sometimes i am also getting error
") expected"

please help as its a urgent requirement

Hemant Basvapattan
Bangalore

[RamananKalirajan]

Sorry I dont know much things about CS but ur code is working well in HTML (that I tried). The problem may be in ur code is in this line

[HTML]lnkHold.Attributes.Add("onclick", "javascript:copyText('Procedure Id-" + lblProcedureID.Text + [/HTML]

Before the Procedure Id- there was a single quotes but it was not ended. Just check it out

Regards
Ramanan Kalirajan

[iam_clint]

In your c# you are passing these 3 items into your string

lblProcedureID.Text
ProcedureTitle.Text
ProcedureDesc.Value
 

... as far as I can tell you aren't validating these items so let me put this in context..


lets say lblProcedureID = 13, ProcedureTitle = "bob's palace", ProecureDesc = "this is something"

lnkHold.Attributes.Add("onclick", "javascript:copyText('Procedure Id-13 Proceudre Title-bob's palace Procedure Description-this is something');");  
 

now lets see the problem

Javascript interprets
String1: 'Procedure Id-13 Procedure Title-bob'
Unterminated String: s palace Procedure Description-this is something'
 

as you can see the string starts and ends before everything is executed.


This is how I imagine you are coming up with this error.

[hemantbasva]

yes the problem is with the procedure description only.either due to length or due to special character. i will trace it out
Thanks everyone for help