'Create popup and return value' code working for one button but not another

[Taftheman]

Hi, I have created a pop up using js and returns a value for me to process. I have got it working. I now need to do it again for another button. The value return will be processed differently. But as i need to get the value out the same way i decide to use whats already there. The problem is it works for the original one and breaks for the new one. My code is bellow. It seems to break on theform.elements[id].value. it does not like id i think.Like i said it works for one and not the other why?. from the alerts it is pass the right stuff through

CODE:

function SetUser(formName, id, newvalueid, postBack)
{
   alert(id);
   alert(formName);
   alert(newvalueid);
   alert(postBack);
    eval('var theform = document.' + formName + ';');
    popUp.close();
    alert(theform);
    theform.elements[id].value = newvalueid;
    if (postBack)
        __doPostBack(id,'');
}

[acoder]

As a full member now, you should know that we expect your code to be posted in [code] tags (See How to Ask a Question).

This makes it easier for our Experts to read and understand it. Failing to do so creates extra work for the moderators, thus wasting resources, otherwise available to answer the members' questions.

Please use the tags in future.

Please also remember to provide a meaningful Title for any threads started (see the FAQ entry Use a Good Thread Title).

This helps to ensure that other members, and also the general public, will have a better chance of finding answers to any similar questions. Thanks

Moderator.

[acoder]

Post your form HTML code too. It seems that you're mixing the name and ID.