Firefox getElementById problem

[wangers16]

Hi all,

I have a checkbox on my site that needs it's status to be changed dynamically depending on the status of a cookie, the script I have works fine in IE yet not in Firefox, I have tried getElementById, getElementsByName and placing the checkbox in a form and obtaining the element that way but nothing seems to work, Firefox can't seem to find the checkbox.

Here is the code that I am currently using

function infocheck(){
var disabled = getCookie('disabled');
var box = document.settings.toggle;
var pageid = getCookie('currpage');
if (pageid == pid){
    if (disabled === null){
        box.checked = true;
    }
    else{
        box.checked = false;
    }
}
}
 

any suggestions?

Thanks in advance.

[RamananKalirajan]

Hi Dude, it seems there is nothing problem with the code, just check the mozilla browser property wether the cokkie is enabled or not. Because there are two methods for maintaining a session 1) through Cookies 2) URL rewritting. In most of the browser defaultly cookies will be set disabled. Just check that once.

Regards
Ramanan Kalirajan

[acoder]

Post the HTML code for the checkbox. Is it just a single checkbox and is the ID unique? Have you checked the error console for errors?

[wangers16]

I have cookies enabled and here is the code for the checkbox

<label for="toggle">Info Bar on/off</label> <input type="checkbox" id="toggle" name="toggle" onclick="barstat()" value="" disabled>
 

Yes it is just a single checkbox with a unique ID

I have also checked the error console and this is what it is displaying "box is null"

[acoder]

Is the name of the form settings?

"box is null" means that it's not getting the checkbox element. Try using the ID, i.e. box = document.getElementById("toggle").

[wangers16]

yes the name of the form is settings and I have tried that but it still comes up with the same error

I have also tried the box outside of a form as well, but to no aveil

it may or may not be worth mentioning that this error seems to pop up on both Firefox 2 and 3

[acoder]

How and when are you calling the infocheck() function?

Can you post the rest of the relevant code or a version that demonstrates the problem or a link?

[wangers16]

The function is being called onload along with some other functions, however the snag is that there is another part of the function which does something else but that works perfectly in both

here is the full code at the moment

function infocheck(){
var disabled = getCookie('disabled');
var box = document.getElementById('toggle');
var pageid = getCookie("currpage");
if (pageid == pid){
    if (disabled === null){
        box.checked = true;
    }
    else{
        box.checked = false;
    }
}
else{
    /*THIS PART ONWARDS IS WORKING PERFECTLY (somehow)*/if (pageid=="pps"){
        if (getCookie("mpwstat")=="yes"){
            history.back(1);
        }
        else{
            return false;
        }
    }
    else{
        return false;
    }
}
}
 

and this is how it is being called, I had to use a custom onload function because of other scripts

load(setTimeout('infocheck()',1));
 

I think that is all that may be needed let me know if you need any more

P.S. Cannot provide a link as it is not hosted yet

[acoder]

Can you post the getCookie function code too. What's the value of pid?

[wangers16]

the value of pid is pref

getCookie function:

function getCookie(cookie_name){
  var results = document.cookie.match ('(^|;) ?' + cookie_name + '=([^;]*)(;|$)');
 
  if (results){
    return (unescape(results[2]));
}
  else{
    return null;
}
}
 

[acoder]

Hm, ok, the best thing would be for you to post the whole code for the page leaving out the irrelevant parts (test it to see if the problem still occurs). If it's too much code, post it as an attachment.

[wangers16]

well as far as I can see, all that is relevant to the problem is the coding that was posted earlier, other than the content in the head tags and the declaration the rest is completly irrelevant to the problem.

I will post the declaration and the head tags anyway.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" "http://www.w3.org/TR/html4/loose.dtd">
<html>
 
<head>
<title>Settings</title>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<script type="text/javascript" src="js/mpw.js"></script>
</head>
 

error is still occuring

let me know if you need any more :)

[acoder]

What's in the mpw.js JavaScript file? Are the cookie functions in there? Where is pid set? I think if you could produce a mini-version of the page with all irrelevant code stripped out that still produces the error, that would help pinpoint the error. Add a few alerts in too to check that the values of variables are what you expect (or you could use a debugger such as Firebug).

[wangers16]

I have just created a mini version, and it seems to work perfectly, however when I link it up to the main site script (mpw.js) it seems to stop working and starts producing the error again.

I think it may be something to do with the other script that loads onload.

The other script that is being called is the "Obtain HREF's" one that you helped me with before, and when I cancel that out it seems to work ok.

I think it could either be a conflict between this script and the valbeta() script or this script and the custom onload script used.

[acoder]

Now we seem to be getting somewhere! Can you show the code for the custom onload script?

[wangers16]

Here is the custom onload function:

function load(func) {   
  var oldonload = window.onload;   
  if (typeof window.onload != 'function') {   
    window.onload = func;   
  }
  else{   
    window.onload = function() {   
      if (oldonload) {   
       oldonload();   
      }
      else{   
      func;
      }   
    }
  }   
}
 

[acoder]

You can avoid using this custom script by using addEventListener/attachEvent. See this link for more information. If that fails to solve the problem, can you remind me of the valbeta script.

[wangers16]

Sorry for the delayed response, first time in a while I have been able to check back here

I have looked through the page that you provided and i'm not entirely sure where to put the addEventListener(), in relation to the page or script?

Here is the code for the valbeta script

function valbeta() {
  var anchors = document.getElementsByTagName('a');
  for (var o = 0; o < anchors.length; ++o){
    anchors[o].onclick=function(){
      validate(this.getAttribute('href',2));
      return false;
    };
  }
}
 

[acoder]

It's been so long that I forgot what this was about.

To use addEventListener/attachEvent is easy. Wherever you would call your custom onload function, add an event instead.

[wangers16]

Once again, sorry for taking so long to reply, but thank you for all of your help, it is working perfectly now. :)

[acoder]

No problem. At least it's working and it's better late than never ;)