Dynamic css Property

[Jezternz]

Okay basicly I wanna do the following:

var changetype = "backgroundColor";
changevalue = "red";
element.style.changetype = changevalue;

Where changetype an changevalue could be anything. Is this possible? possibly using the eval function? the changevalue works fine, just getting it to register the dynamic property is a problem.
My last resort will be a switch/case statement, but I would much rather a sigle/few lines of code.

Thanks, Josh

[hsriat]

Try this...

var changetype = "backgroundColor";
changevalue = "red";
element.setAttribute('style', changetype+':'+changeval+';');

If it removes the other properties in style, then first use getAttribute and then replace the value.

[Jezternz]

thanks! Got me thinking, and got this working:

if(window.attachEvent)
elementdir.style.setAttribute('cssText',changetype+':'+changevalue+';'); 
else elementdir.setAttribute('style',changetype+':'+changevalue+';');

Only thing is it means I am limited to the css property's not the javascript properties, what I mean is I cant change things like innerHTML.

But thats a good start, any other ideas?

[hsriat]

I think everything could be done with setAttribute, except innerHTML.
Everything means... all style properties and all the attributes which come within the tag. But innerHTML is something which lies out of the tag. So may be you could just keep that aside with a simple if statement.

Is there anything else I'm missing?

[Jezternz]

thats a valid point. I might just go with that.
Thanks heaps, Josh

Edit: This will work but only when I only want to change a single property. as soon as I add a second property it deletes the previous one. So I made it so it just added ontop of the previous lot of cssText, only problem with that is u can end up with multiple definitions of the same property like "background:black;background:blue;background:green ;" and this wont do. so back to square one :(

[hsriat]

This will work but only when I only want to change a single property. as soon as I add a second property it deletes the previous one. So I made it so it just added ontop of the previous lot of cssText, only problem with that is u can end up with multiple definitions of the same property like "background:black;background:blue;background:green ;" and this wont do. so back to square one :(

Did you try getAttribute as I said in post #2?

[gits]

Okay basicly I wanna do the following:

var changetype = "backgroundColor";
changevalue = "red";
element.style.changetype = changevalue;

Where changetype an changevalue could be anything. Is this possible? possibly using the eval function? the changevalue works fine, just getting it to register the dynamic property is a problem.
My last resort will be a switch/case statement, but I would much rather a sigle/few lines of code.

Thanks, Josh

doesn't the following simple adaption of your original code work?

var changetype = "backgroundColor";
changevalue = "red";
element.style[changetype] = changevalue;
 

kind regards

[acoder]

That's absolutely correct. You can avoid eval in most cases in this manner. For example, if you have variables test1, test2, etc. and you need to access them using a loop, something like the following should allow you to do so:

for (i = 0; i < len; i++) {
    window["test"+i]... // equivalent to test1, test2, etc.
}

[Jezternz]

yeh hsriat, the problem i was having went with setAttribute. Thanks though, and thanks for the final answer, I never would have guessed you could do that.

[hsriat]

yeh hsriat, the problem i was having went with setAttribute.

setAttribute or getAttribute?

Thanks though, and thanks for the final answer,...

You are welcome :)

I never would have guessed you could do that.

Why? :(

[acoder]

Why? :(

I think you've misunderstood. Sometimes you can use "you" to mean "one" or "anyone" (link).

I assume you're not joking and playing with words. If you were, sorry for the English lesson :)

[hsriat]

I think you've misunderstood. Sometimes you can use "you" to mean "one" or "anyone" (link).

I assume you're not joking and playing with words. If you were, sorry for the English lesson :)

Ok, I really misunderstood that.
English isn't my first language. And I was never good in English at school. My English is just Hollywood movies' contribution.

Thanks for that lesson ;)

[acoder]

No problem. I did gather as much, though your English is pretty good for a second (or third?) language.

[hsriat]

No problem. I did gather as much, though your English is pretty good for a second (or third?) language.

Thanks, its third ;)

[acoder]

I'll rephrase that then: your English is very good considering that it's your third language ;)

[hsriat]

I'll rephrase that then: your English is very good considering that it's your third language ;)

lol... thanks again

Its just, I've never heard someone praising my English. Though many do give contradicting comments. So I'm glad to hear that, especially from a British guy.

[acoder]

Its just, I've never heard someone praising my English. Though many do give contradicting comments. So I'm glad to hear that, especially from a British guy.

Hey, I wasn't praising it per se, and you shouldn't be too chuffed - I'm no expert on the language...

PS. I like how you're linking to smilie images to get around the fact that they're disabled in this forum

[hsriat]

Ok, I'm back on the ground.

Actually I wasn't chuffed. Just due to the communication gap, it sounded like. I was just having fun.

... and again, you and of course Google have taught me a new word. Thanks for that.

... and even I like the smilies, I don't know why are they disabled. In cafe/lounge, one can't even use this method, because even image is disabled.

... and in the end, we should end the thread now, rather then hijacking it.

Regards,
Harpreet