remove siblings after current

[theS70RM]

Hi Guys,

Ive got a menu that dynamically creates <select> drop down boxes for categories and sub categories etc.

When a dropdown is changed I want to remove all susequent siblings (all <select>'s) from the current div.

Heres the code i have....

 
function removeSiblingsAfterl(dd){
 
    //remove siblings after dd
 
    divCatsel = document.getElementById('catselect');
    siblingNode = dd.nextSibling;
 
    while (siblingNode.nextSibling) {
        divCatsel.removeChild(siblingNode);
        siblingNode = siblingNode.nextSibling;    
    }
 
    //add new select box in place....
 
}
 

"dd" is the last used select box, using onchange="removeSiblingsAfter(this)"

So basically you will select an option from one DD box and all the ones after will be removed and then replaced by a new one.

I just cant seem to get it removing all the sibling nodes after the current one correctly..

Can anyone help?

thanks

Andy

[Logician]

[quote=theS70RM]

 
    while (siblingNode.nextSibling) {
        divCatsel.removeChild(siblingNode);
        siblingNode = siblingNode.nextSibling;    
 

If you've just removed siblingNode, how can you get its next sibling?
Try this:

function removeSiblingsAfterl(dd)
{
  var ns;
   while (ns=dd.nextSibling) 
     dd.parentNode.removeChild(ns);    
}
 

[hsriat]

Try this:

function removeSiblingsAfterl(dd)
{
  var ns;
   while (ns=dd.nextSibling) 
     dd.parentNode.removeChild(ns);    
}
 

Too right, but may give a small warning: Mistyped == as =

 
function removeSiblingsAfterl(dd){
    while (dd.nextSibling) 
    dd.parentNode.removeChild(dd.nextSibling);
 
}
 

[Logician]

Too right, but may give a small warning: Mistyped == as =

No - assignment was intended.

[hsriat]

No - assignment was intended.

Sure it was needed.. I'm not saying it wasn't.

[mrhoo]

To avoid the warning you can write assignment in conditionals like-

while ((ns=dd.nextSibling)!=null){

[hsriat]

To avoid the warning you can write assignment in conditionals like-

while ((ns=dd.nextSibling)!=null){

That's a good solution.

[theS70RM]

That's a good solution.

thanks chaps, ill give that a try


Andy

[theS70RM]

Worked a treat, thanks very much!

[hsriat]

Worked a treat, thanks very much!

That's fine :)

Glad to know you got it working.