object and functions

[dreamfalcon]

Hi
I had some variables and functions to work with google maps, that are working great, but i needed to have more than one map in the same page, and was using different names to each variable, like xml1, xml2. But decided to use a object to group all variables and functions.

function Map(){
    this.xml;
 
    this.loadMap = function (tabId){
        this.myElement = $(tabId);
        if (GBrowserIsCompatible()) {
            this.map = new GMap2(this.myElement.getElementsByClassName("googlemap")[0]);
        ...
        this.getCells(tabId);
        }
    }
 
    this.getCells = function(){
        GDownloadUrl("request.php?script=genxml.php", function (data){
            this.xml = GXml.parse(data);
            this.redraw();
        });
 
    this.redraw = function (){
        alert("ok");
        //code to draw cells
    }
}
 

and

map1= new Map();
map1.loadMap(tabId);
 

it gives this error
"this.redraw is not a function"

and map1.xml is empty.

I don´t have many experience with objects in Javascript
Can anyone help me?
thx

[hsriat]

Add a closing brace and a semicolon }; after line 17

[dreamfalcon]

Add a closing brace and a semicolon }; after line 17

sorry, copy paste error :D

function Map(){
    this.xml;
 
    this.loadMap = function (tabId){
            this.myElement = $(tabId);
        if (GBrowserIsCompatible()) {
            this.map = new GMap2(this.myElement.getElementsByClassName("googlemap")[0]);
        ...
        this.getCells(tabId);
        }
    }
 
    this.getCells = function(){
        GDownloadUrl("request.php?script=genxml.php", function (data){
            this.xml = GXml.parse(data);
            this.redraw();
        });
      }
    this.redraw = function (){
        alert("ok");
        //code to draw cells
    }
}
 

and

map1= new Map();
map1.loadMap(tabId);
 

[hsriat]

Is the error still there?

[dreamfalcon]

Is the error still there?

"this.redraw is not a function"
Yes, same error :(

Maybe because is a function inside a function, it doesn't recognize as the same object?

[dreamfalcon]

"In JavaScript this always refers to the “owner” of the function..."

In my case the “owner” becomes GDownloadUrl.
After a google search i think that this is called "Higher order functions", but no ideas how to solve this.

[dreamfalcon]

SOLVED
-> var me=this;

function Map(){
    this.xml;
    var me=this;
...
 
    this.getCells = function(){
        GDownloadUrl("request.php?script=genxml.php", function (data){
            me.xml = GXml.parse(data);
            me.redraw();
        });
      }
 
}
 

[hsriat]

That's good you solved it!!

Even I hate the fact that I don't understand OOP. Will start from a..b..c.. in some free time.