onChange issue with select dropdown

[idj]

Hi, I'm using the following code to redirect to a new page with a select dropdown, which works fine:

[HTML]<script type="text/javascript">
<!--
function go(){
location=
document.FRM_NAME.VALUE_NAME.
options[document.FRM_NAME.VALUE_NAME.selectedIndex].value
}
//-->
</script>

<form action="" method="post" name="FRM_NAME">
<select name="VALUE_NAME" id="VALUE_NAME" onChange="go();">
<option value="001.html">001</option>
<option value="002.html">002</option>
<option value="003.html">003</option>
</select>
</form>
[/HTML]
The problem is when I have multiple select dropdowns, I'd like to use the same function with vars for FRM_NAME & VALUE_NAME!

eg:

onChange="go(FRM001, VAL001);" and onChange="go(FRM002, VAL002);"

As a complete newbie to JS, I'd appreciate any help and apologise if this is very basic.

Thanks in advance.

KR idj

[acoder]

Welcome to TSDN and to JavaScript programming!

No need to apologise for basic questions.

Just use arguments for the function and use the forms and elements arrays:

function go(frm, sel) {
  location.href = document.forms[frm].elements[sel].value;
}

[idj]

Hi Acoder, thanks for the reply.

I get an error:

Error: 'document.forms[...].elements' is null or not an object

I've used your supplied JS and the following HTML:

<form action="" method="post" name="FRM_NAME">
<select name="SELECT_NAME" id="SELECT_NAME" onChange="go(FRM_NAME, SELECT_NAME);">
<option value="001">001</option>
<option value="002">002</option>
<option value="003">003</option>
</select>
</form>

Any thoughts?

KR ijd

[gits]

hi ...

you have to pass the params as string values (actually in your code you pass variable-names that refer to undefined values in this case), so use the following:

[HTML]onChange="go('FRM_NAME', 'SELECT_NAME');"[/HTML]
kind regards

[acoder]

Yes, and put the ".html" back in the option values or append it in the function.

[idj]

Thanks Guys for all your help. It works now :-). KR idj

[acoder]

You're welcome. Glad it's working. Post again anytime should you have any more questions.