Perform control schedule

[viki1967]

Hi there.

Hi have this script:

 <script language="javascript" type="text/javascript">
<!--
 
var fieldNames = new Array("IRE", "ISI", "IMI", "REL", "REV", "MAN", "SOP", "GUF", "FOR", "VAS");
 
function loaded()
{
 
  var tm, q = location.href.indexOf("?tm=");
  if (q < 0 || (tm = location.href.substr(q + 4)).length <= 0) return;
 
 
  tm = tm.split(";");
 
  var frmObj = document.timeForm;
 
  var re = /^([a-z]+)-(([01]\d|2[0-3]):[0-5]\d)$/;
 
  for ( var n = 0 ; n < tm.length ; n++ )
    {
      var rt = tm[n].match(re);
      if (rt && typeof(frmObj[rt[1]]) != "undefined")
        {
 
          frmObj[rt[1]].value = rt[2];
        }
    }
}
 
function unloading()
{
 
  if (window.opener == null) return;
 
  window.opener.popupWin = null; 
}
 
function updateTime(txtObj)
{
  if (window.opener == null) return;
 
  var re = /^([01]\d|2[0-3]):[0-5]\d$/;
 
  if (txtObj.value.length >= 5 && !txtObj.value.match(re))
    {
      alert("Inserire l'orario nel formato 'hh:mm'.");
      txtObj.focus();
    }
 
  var frmObj = txtObj.form;
  var elems = frmObj.elements;
 
  var result = "";
  var destObj = window.opener.document.myform.impiego;
 
    {
      for ( var n = 0 ; n < elems.length ; n++ )
        {
 
          if (elems[n].type == "text" && elems[n].value.match(re))
            {
              if (result.length) result += ";";
 
              result += elems[n].name + "-" + elems[n].value;
            }
        }
 
      destObj.value= result;
    }
  else destObj.value= "--:--"; 
}
 
// -->
</script> 

To perform control schedule.
That is schedule no superior to 7 hours and 36 minutes.

For example:

1) In the field of the form "IRE" inserted 08:00... this value is superior to 7:36
Its' wrong !!!!


2) In the field of the form "IRE" inserted 04:00 and in the field of the form "ISI" inserted 04:00.... this value is superior to 7:36
Its' wrong !!!!

Help me please, regards
viki1967

[acoder]

For each field, get the hours and minutes by splitting the input using split(). Use parseInt to convert into a number. Then add them up. If the hours are more than 7, then validation fails. If the hours equal 7, but the minutes exceed 36, again the validation fails. If you get stuck, post your attempt.

[viki1967]

Sorry I not understand... for example ?

[acoder]

For example, let's say you have 'field' which contains the input:

var vals = field.value.split(":");
var hours = parseInt(vals[0]);
var mins = parseInt(vals[1]);
// if this is in a loop, you could now add them to the total hours/mins:
totalHours += hours;
totalMins += mins;
// validate outside the loop
if (totalHours > 7) // error
if ((totalHours == 7) && (totalMins > 36)) // error here too.
 

[viki1967]

Sorry Acoder... but how to integrate your code with code existing ?
Many Thanks....

[acoder]

Where are you making the validation? In updateTime()?

[viki1967]

Yes Acoder in UpdateTime()

[acoder]

Just as you've used a loop in there, loop over the form elements in a similar manner:

var totalHours = 0;
var totalMins = 0;
for ( var n = 0 ; n < elems.length ; n++ )
  {
     if (elems[n].type == "text" && elems[n].value.match(re))
        {
           var vals = elems[n].value.split(":");
           var hours = parseInt(vals[0]);
           var mins = parseInt(vals[1]);
           totalHours += hours;
           totalMins += mins;
        }
  }
// validate outside the loop
if (totalHours > 7) // error
if ((totalHours == 7) && (totalMins > 36)) // error here too.
 

[viki1967]

Sorry Acoder, but not working....

[php]
function updateTime(txtObj)
{
if (window.opener == null) return;


var re = /^([01]\d|2[0-3]):[0-5]\d$/;


if (txtObj.value.length >= 5 && !txtObj.value.match(re))
{
alert("Inserire l'orario nel formato 'hh:mm'.");
txtObj.focus();
}


var frmObj = txtObj.form;
var elems = frmObj.elements;


var result = "";
var destObj = window.opener.document.myform.impiego;


if (frmObj.IRE.value.match(re))

var totalHours = 0;
var totalMins = 0;

{
for ( var n = 0 ; n < elems.length ; n++ )
{


if (elems[n].type == "text" && elems[n].value.match(re))


{
var vals = elems[n].value.split(":");
var hours = parseInt(vals[0]);
var mins = parseInt(vals[1]);
totalHours += hours;
totalMins += mins;
}

{
if (result.length) result += ";";

result += elems[n].name + "-" + elems[n].value;
}
}

destObj.value= result;
}
else destObj.value= "--:--";

// validate outside the loop
if (totalHours > 7) // error
if ((totalHours == 7) && (totalMins > 36)) // error here too.

}
[/php]

[acoder]

There are two problems: one is that you want to validate before you calculate the result. So make two loops. The second problem is that where I've added comments, e.g. // error, you need to replace that with an error message.

[viki1967]

What solution for this script ?

[acoder]

What changes have you made to the script?

[viki1967]

[php]
function updateTime(txtObj)
{
if (window.opener == null) return;


var re = /^([01]\d|2[0-3]):[0-5]\d$/;


if (txtObj.value.length >= 5 && !txtObj.value.match(re))
{
alert("Inserire l'orario nel formato 'hh:mm'.");
txtObj.focus();
}


var frmObj = txtObj.form;
var elems = frmObj.elements;


var result = "";
var destObj = window.opener.document.myform.impiego;


if (frmObj.IRE.value.match(re))

var totalHours = 0;
var totalMins = 0;

{
for ( var n = 0 ; n < elems.length ; n++ )
{


if (elems[n].type == "text" && elems[n].value.match(re))


{
var vals = elems[n].value.split(":");
var hours = parseInt(vals[0]);
var mins = parseInt(vals[1]);
totalHours += hours;
totalMins += mins;
}

{
if (result.length) result += ";";

result += elems[n].name + "-" + elems[n].value;
}
}

destObj.value= result;
}
else destObj.value= "--:--";

// validate outside the loop
if (totalHours > 7) // error
if ((totalHours == 7) && (totalMins > 36)) // error here too.

}

[/php]

[acoder]

I've made some quick changes without testing to give you an idea:

function updateTime(txtObj)
{
  if (window.opener == null) return;
 
  var re = /^([01]\d|2[0-3]):[0-5]\d$/;
 
  if (txtObj.value.length >= 5 && !txtObj.value.match(re))
    {
      alert("Inserire l'orario nel formato 'hh:mm'.");
      txtObj.focus();
    }
 
 
  var frmObj = txtObj.form;
  var elems = frmObj.elements;
 
 
  var result = "";
  var destObj = window.opener.document.myform.impiego;
 
  var totalHours = 0;
  var totalMins = 0;
 
      for ( var n = 0 ; n < elems.length ; n++ )
      {
 
 
          if (elems[n].type == "text" && elems[n].value.match(re))
          {
           var vals = elems[n].value.split(":");
           var hours = parseInt(vals[0]);
           var mins = parseInt(vals[1]);
           totalHours += hours;
           totalMins += mins;
          }
      } 
  // validate outside the loop
  if (totalHours > 7) {
    alert("Error: total hours is more than 7");
    return;
  }
  if ((totalHours == 7) && (totalMins > 36)) {
    alert("Error: total time exceeds 7:36");
    return;
  }
// validation complete...
      for ( var n = 0 ; n < elems.length ; n++ )
      {
 
          if (elems[n].type == "text" && elems[n].value.match(re))
          {
            {
              if (result.length) result += ";"; 
 
              result += elems[n].name + "-" + elems[n].value;
            }
        }
 
      destObj.value= result;
    }
}

[viki1967]

Thanks Acoder.
But 09:00 value is validated by function...

[acoder]

Thanks Acoder.
But 09:00 value is validated by function...

Use the radix to parse the number as a decimal, i.e. use parseInt(val,10) as described here.

[viki1967]

How to change this ?

var hours = parseInt(vals[0]);
var mins = parseInt(vals[1]);

[acoder]

var hours = parseInt(vals[0],10);
var mins = parseInt(vals[1],10);

[viki1967]

Thanks Acoder !!!!!!

[acoder]

You're welcome.