Javascript issues with Mozilla

[danielji]

Hi, I'm having trouble with my javascript in Mozilla. I'm trying to use onClick within a link to call hidden divs in page. This seems to function properly in IE and Safari but not Mozilla. I would appreciate any feedback.


javascript in header:

[HTML]<script language="javascript">
<!--

function changeLinks(link) {


if (link=="1") {

window.LinksInternal.style.display = '';
window.LinksExternal.style.display = 'none';
window.LinksQuick.style.display = 'none';

}

if (link=="2") {

window.LinksInternal.style.display = 'none';
window.LinksExternal.style.display = '';
window.LinksQuick.style.display = 'none';

}

if (link=="3") {

window.LinksInternal.style.display = 'none';
window.LinksExternal.style.display = 'none';
window.LinksQuick.style.display = '';

}

</head>
[/HTML]
code in body:

[HTML]
<a onClick="changeLinks(3);return false;" style="cursor:hand"><img border="0" src="/images/quicklinks3.gif" class="right" ></a><a onClick="changeLinks(2);return false;" style="cursor:hand"><img border="0" class="right" src="/images/externallinks3.gif" ></a> <a onClick="changeLinks(1);return false;" style="cursor:hand"><img border="0" class="right" src="/images/internallinks3.gif" ></a><BR>[/HTML]

[gits]

hi ...

welcome to TSDN ...

try to use:

window.LinksInternal.style.display = 'block';

instead of setting it to an empty string :)

kind regards

[Dasty]

And fix referencing too, because it is invalid. Make it this way:

document.getElementById('LinksInternal').style.display = '';

[gits]

And fix referencing too, because it is invalid. Make it this way:

document.getElementById('LinksInternal').style.display = '';

yup ... of course ... and ensure you have the corresponding id set to the node ...

kind regards

[danielji]

Hi Friends, thank you for the prompt replies. I've tried both your recommendations and am still having trouble except this time it's not working in IE either.

[HTML]function changeLinks(link) {


if (link=="1") {

document.getElementByID('LinksInternal').style.dis play = '';
document.getElementByID('LinksExternal').style.dis play = 'none';
document.getElementByID('LinksQuick').style.displa y = 'none';

}

if (link=="2") {

document.getElementByID('LinksInternal').style.dis play = 'none';
document.getElementByID('LinksExternal').style.dis play = '';
document.getElementByID('LinksQuick').style.displa y = 'none';


}

if (link=="3") {

document.getElementByID('LinksInternal').style.dis play = 'none';
document.getElementByID('LinksExternal').style.dis play = 'none';
document.getElementByID('LinksQuick').style.displa y = '';


}


}
[/HTML]

called via onClick here:
[HTML]
<div id="LinksContainer" >
<a onClick="changeLinks(3);return false;" style="cursor:hand"><img border="0" src="/images/quicklinks3.gif" class="right" ></a><a onClick="changeLinks(2);return false;" style="cursor:hand"><img border="0" class="right" src="/images/externallinks3.gif" ></a> <a onClick="changeLinks(1);return false;" style="cursor:hand"><img border="0" class="right" src="/images/internallinks3.gif" ></a><BR>

<% Call fn_getLinksExternal(2) %>
<% Call fn_getLinksInternal(2) %>
<% Call fn_getLinksQuick(2) %>


</div>[/HTML]

[gits]

getElementById ... note that javascript is case-sensitive

kind regards

[danielji]

getElementById ... note that javascript is case-sensitive

kind regards

works now, many many thanks for catching that!

[gits]

no problem ... glad to hear you got it working :) ... post back to the forum anytime you have more questions

kind regards