Login - javascript execution

[kerriejones]

I am trying to create a simple login routine, and am failing completely, I have tried to simplify the test and still no luck.

HTML
<form method="post" action="" >
<div>
<input type="text" name="field1"/>
<input type="password" name="field2"/>
<input type="button" name="submit" value="Click" onclick="javascript:test(field1.value,field2.value )"/>
</div>
</form>

SCRIPT
<script type="javascript">
<!--
function test(field1,field2)
{
echo "in the test<br>";
alert ("i am in the code");
return;
}
//-->
</script>

ERROR
Microsoft JScript runtime error: Object expected
<input type="button" name="submit" value="Click" onclick="javascript:test(field1.value,field2.value )"/>
This part of the line is highlighted when in debug:
javascript:test(field1.value,fi



I know I have probably done something really simple, please help!

[Markus]

try changing

<input type="button" name="submit" value="Click" onclick="javascript:test(field1.value,field2.value)"/>
 

to

<input type="button" name="submit" value="Click" onclick="test(field1.value,field2.value)"/>
 

please remember to use CODE tags when posting - it makes provided code easier to read.

And also, this is the PHP forum, not javascript.

[kerriejones]

I am trying to create a simple login routine, and am failing completely, I have tried to simplify the test and still no luck. This code is in a php page!

HTML
[HTML]<form method="post" action="" >
<div>
<input type="text" name="field1"/>
<input type="password" name="field2"/>
<input type="button" name="submit" value="Click" onclick="javascript:test(field1.value,field2.value )"/>
</div>
</form>
[/HTML]
SCRIPT

<script type="javascript">
<!--
function test(field1,field2)
{
echo "in the test<br>";
alert ("i am in the code");
return;
}
//-->
</script>
 

ERROR
Microsoft JScript runtime error: Object expected
<input type="button" name="submit" value="Click" onclick="javascript:test(field1.value,field2.value )"/>
This part of the line is highlighted when in debug:
javascript:test(field1.value,fi

I have tried all of the following onclick commands and still the same error
onclick="javascript:test(field1.value,field2.value )"
onclick="javascript:test(field1,field2)"
onclick="test(field1.value,field2.value)"
onclick="test(field1,field2)"

I know I have probably done something really simple, please help!

[kerriejones]

Mark,

This does not work either. I have republished the problem in the correct area!

[clai83]

I've been creating a login script as well. And actually I finished it in firefox, and it worked fine with safari, and opera, but not IE.

It would be great if someone were to post the solution to this.

This particular error also comes up in Zend Studio when doing a debug session.

IE strikes again -_-

[acoder]

I am trying to create a simple login routine, and am failing completely, I have tried to simplify the test and still no luck. This code is in a php page!

You have an echo statement inside a JavaScript statement. Firstly, that should appear in PHP tags. Secondly, it needs to be valid JavaScript, e.g. an alert statement.

[acoder]

I've been creating a login script as well. And actually I finished it in firefox, and it worked fine with safari, and opera, but not IE.

What error did you get in IE? Post your code.

[clai83]

What error did you get in IE? Post your code.

I have similar code to kerriejones (the javascript part not the PHP).

[HTML]
<input
class="shortInputField"
id="username"
name="username"
type="text"
title="<?php echo $html['usertitle']; ?>"
maxlength="40"
value="<?php if (isset($clean['username'])) { echo $clean['username'];} else {echo "";}?>"
tabindex="1"
onfocus="this.hasFocus=true; <?php echo $html['fieldcheck']; ?>;"
onkeyup="<?php echo $html['fieldcheck']; ?>"
onblur="this.hasFocus=false; <?php echo $html['fieldcheck']; ?>;"
/>
[/HTML]

The problem I'm having is the $html['fieldcheck'] variable. This variable will either be

[PHP]
$html['fieldcheck'] = "fieldCheck('japanese');";
$html['fieldcheck'] = "fieldCheck('english')";
[/PHP]

I get the exact same error kerriejones does, where

Microsoft JScript runtime error: Object expected

The function fieldCheck is fairly lengthy but here is the basic structure

function fieldCheck(language) {
      //set some vars and regex stuff
     var  username =  document.login.username; 
     //for example
 
     if (username.value.length === 0) {
           if (language == 'english') {
                //print a english error in paragraph innerHTML
           }
           else {
                //print a japanese error in paragraph innerHTML
           }
    }
 
}
 

I'm a complete newb to javascript. It may be simple, I just can't seem to find it. I'm not sure why there is a JScript runtime error, am I not telling the browser correctly that I'm using javascript. I used <script type="text/javascript" src="something.js" ></script> in the head element. Should I be using something else? Or is there something about IE javascript handling I don't know about. (probably is)

Hopefully I've given enough information

[acoder]

I have similar code to kerriejones (the javascript part not the PHP).

[HTML]
<input
class="shortInputField"
id="username"
name="username"
type="text"
title="<?php echo $html['usertitle']; ?>"
maxlength="40"
value="<?php if (isset($clean['username'])) { echo $clean['username'];} else {echo "";}?>"
tabindex="1"
onfocus="this.hasFocus=true; <?php echo $html['fieldcheck']; ?>;"
onkeyup="<?php echo $html['fieldcheck']; ?>"
onblur="this.hasFocus=false; <?php echo $html['fieldcheck']; ?>;"
/>
[/HTML]

The problem I'm having is the $html['fieldcheck'] variable. This variable will either be

[PHP]
$html['fieldcheck'] = "fieldCheck('japanese');";
$html['fieldcheck'] = "fieldCheck('english')";
[/PHP]

Maybe it's the double semi-colon. Which line does the error occur on?