register onclick problem

[obarash]

I ran into a strange problem:

I'm adding and removing rows dynamicly,
each row has it's id and remove button

when I removing a row i go on all the next rows and update their ID
I also need to update the delete row button.

the problem is that the button has onclick="deleteRow(rowId)"

and when I remove a row and update all the next elements

all of them are calling the deleteRow with the same ID (the id of last one)

i = currentID;
while(i < ElementsCounter){
    newID = i - 1;
    $("delete"+i).id = "delete"+newID;
    $("delete"+newID).onclick = function(){ deleteRow(newID); };
}
 

any idea will help

[obarash]

setting onclick of one element happans to effect other elements onclick

I'm adding and removing rows dynamicly,
each row has it's id and remove button.

when I removing a row i update all the next rows IDs
and the onclick functino to call the deleteRow(rowID) with the new ID.

All next elements onclick function
is calling the deleteRow function with the same ID (the id of last iteration)

for example:
all of the button call deleteRow(2)


[PHP]i = currentID;
while(i < ElementsCounter){
newID = i - 1;
document.getElementById("delete"+i).id = "delete"+newID;
document.getElementById("delete"+newID).onclick = function(){ deleteRow(newID); };
}[/PHP]

Thanks from advance

[acoder]

Merged duplicate threads.

How about passing "this" to the delete function instead?

[obarash]

Merged duplicate threads.

How about passing "this" to the delete function instead?

if I pass the obj itself how can i get the row ID?

there is another way to add an onlick event?

[Eyeinstyin]

I ran into a strange problem:

I'm adding and removing rows dynamicly,
each row has it's id and remove button

when I removing a row i go on all the next rows and update their ID
I also need to update the delete row button.

the problem is that the button has onclick="deleteRow(rowId)"

and when I remove a row and update all the next elements

all of them are calling the deleteRow with the same ID (the id of last one)

i = currentID;
while(i < ElementsCounter){
    newID = i - 1;
    $("delete"+i).id = "delete"+newID;
    $("delete"+newID).onclick = function(){ deleteRow(newID); };
}
 

any idea will help

what is "$"
and i is not getting decrementted

[acoder]

if I pass the obj itself how can i get the row ID?

there is another way to add an onlick event?

If you're deleting a row, why do you need the row ID? However, if you really need it, use the rowIndex property.

[obarash]

If you're deleting a row, why do you need the row ID? However, if you really need it, use the rowIndex property.

Thanks I'll see if I can use it

[obarash]

what is "$"
and i is not getting decrementted

$ is prototype refernce.
the implementation is very easy:

function $(element){
return document.getElementById(element);
}

in the prototype libary there a simple validition if it is an obj

[obarash]

If you're deleting a row, why do you need the row ID? However, if you really need it, use the rowIndex property.

I can't use it my code is like this
<tr>
<td>
<table>
<tr>
<td>
<td>
<td>button</td>
<tr>
</table>
<td>
<tr>

I need it to stay as is my problem is relly in the 'this'
in the loop that i described before if i write this it is not a refernce to the button itself.
how can i pass this?

[acoder]

Can you post the rest of the code (if it's not too much) or a link?

[obarash]

Can you post the rest of the code (if it's not too much) or a link?

i solved my problem!!

I've set the <td> that contatins the button only the row id and just call deleteRow()

in the deleteRow():
var obj = event.srcElement;

and then I use obj.parentNode.id

and in the loop i just update the <td> id.

[acoder]

i solved my problem!!

...
in the deleteRow():
var obj = event.srcElement;

Glad you managed to solve it. Just a note though: srcElement is IE-only. You need to use target for standards-compliant browsers. See, for example, this link.