ajax help please

[Inny]

The following code is giving no output on my site. its supposed to show user veiws on the index page. can anyone find anything wrong with it?

http://herproom.5.forumer.com/index.php?

 
<script type="text/javascript">
<!--
/*
Users Viewing In Main Page Board Cells
Coded By Greg/Moose
Don't repost or edit
*/
var addrequest;
var viewadds = new Array();
var curnum = 0;
var td = document.getElementsByTagName('td');
for(t=0;t<td.length;t++){
if(td[t].getElementsByTagName('a')[0] && td[t].getElementsByTagName('a')[0].href.match(/showforum=\d+/)){
viewadds.push(td[t]);
}}
checkBViews();
function checkBViews(){
if(window.ActiveXObject){
addrequest = new ActiveXObject("Microsoft.XMLHTTP");
} else {
addrequest = new XMLHttpRequest();
}
var opener = viewadds[curnum].getElementsByTagName('a')[0].href;
addrequest.onreadystatechange = function(){
addBViews();
}
addrequest.open("GET",opener,true);
addrequest.send('');
}
function addBViews(){
if(addrequest.readyState == 4 && addrequest.status == 200){
var resptext = addrequest.responseText;
var addiv = document.createElement('div');
addiv.innerHTML = resptext;
var hdiv = addiv.getElementsByTagName('div');
var views = 0;
for(a=0;a<hdiv.length;a++){
if(hdiv[a].className == "darkrow2" && hdiv[a].innerHTML.match(/^(\d+) User\(s\) are browsing this forum/)){
views = parseInt(RegExp.$1) - 1;
}}
if(views < 0){
views = 0;
}
if(views != 0){
var viewstext = document.createTextNode( ' ('+views+' viewing'+')');
viewadds[curnum].insertBefore(viewstext,viewadds[curnum].getElementsByTagName('br')[0]);
}
curnum++;
if(curnum != viewadds.length){
checkBViews();
} else {
termViews();
}}}
function termViews(){
if(window.ActiveXObject){
addrequest = new ActiveXObject("Microsoft.XMLHTTP");
} else {
addrequest = new XMLHttpRequest();
}
addrequest.open("GET",location.href,true);
addrequest.send('');
}
//-->
</script>
 

[acoder]

Do you have any errors?

For the send method, use send(null) instead of an empty string.

[Inny]

I changed the send to send(null) but still no output. I think my variables are wrong, instead of 'veiws' my site has '{ibf.lang.h_hits}'
not sure how to rewrite it without ruining the code?

<th width='7%' align='center' nowrap="nowrap" class='titlemedium'>{ibf.lang.h_hits}</th>

[acoder]

So do you get any errors? Check the JavaScript console.

[Inny]

yes I got 2 errors following (couldnt cut n paste)

[acoder]

Which lines are these?

Line 732 is obviously part of the Ajax code that you've already posted.

[Inny]

Yes it is, as for the other im not sure without posting the entire source to see where the line comes up, not sure how to make stuff display like the code above?

[Inny]

I expect the other error is not to do with it. I dont know where I can test it and get correct line numbers

[acoder]

When do you run this code?

Is it run during page load? If so, the tables, etc. may not be loaded yet. This should be executed after page load.

[Inny]

When do you run this code?

Is it run during page load? If so, the tables, etc. may not be loaded yet. This should be executed after page load.

how would I make it run After page load? /defer?

[Inny]

how would I make it run After page load? /defer?

I tried

<script defer src="http://h1.ripway.com/Inny/showem.js" type="text/javascript"></script>

where 'showem' is the code above (even though its only IE supported) but nothing.

[acoder]

how would I make it run After page load? /defer?

Put it in a function and call it on body onload or window.onload.

[Inny]

Put it in a function and call it on body onload or window.onload.

Errr...I have no idea how to do that! Putting the function in my onload I can do, but whats the actual Function?

[Inny]

This is what The ajax code above is designed to work around. (note: I dont have access to these php files) Maybe this will help sombody create a succesful code for me?

Mod Name:   Amount of Users showed on board
Author:     x00179
AuthorMail: [e-mail]
Author HP:  www.dorg4u.com/x00179
IPB Ver:    1.3pr2 
Decs.
this will show how many people are in a specific category and forum? 
 
Open sources\boards.php
Find
    var $children = array();
Add Below
    var $UsOnBo      = array();
 
Find
    // Get the forums and category info from the DB
Add below
    if ($ibforums->vars['au_cutoff'] == "")    $ibforums->vars['au_cutoff'] = 15;
    $time    = time() - ($ibforums->vars['au_cutoff'] * 60);        
        $DB->query("SELECT COUNT(*) as mcnt,in_forum FROM ibf_sessions WHERE running_time > '$time' GROUP BY in_forum");
        while ( $r = $DB->fetch_row() ) $this->UbOnBo[$r['in_forum']] = $r['mcnt'];
Find
        if ($forum_data['subwrap'] == 1)
        {
Add Above
        $count_users=0;    
 
Find
                        $newest['last_poster_name'] = $data['last_poster_name'];
                        $newest['status']           = $data['status'];
                    }
Add Below
                    //users are where?
                    $count_users += $this->UbOnBo[$newest['fid']];
 
 
Find
                return $this->html->ForumRow($forum_data);
 
            }
            else
Add above
                //users are where?
                if($count_users) {$forum_data['description'] .= "<span class='highlight'> (".$count_users.")</span>";}
Find
            $forum_data['posts']  = $std->do_number_format($forum_data['posts']);
            $forum_data['topics'] = $std->do_number_format($forum_data['topics']);
Add Below
            $count_users += $this->UbOnBo[$forum_data['id']];
            if($count_users) {$forum_data['description'] .= "<span class='highlight'> (".$count_users.")</span>";}
Close & Save
Open Board\Forums.php
Find
        $DB->query("SELECT f.*, m.member_name as mod_name, m.member_id as mod_id, m.is_group, m.group_id, m.group_name, m.mid
Add Above
    //Users are where ?
        $UbOnBo = array();
        if ($ibforums->vars['au_cutoff'] == "")    $ibforums->vars['au_cutoff'] = 15;
        $DB->query("SELECT COUNT(s.id) as mcnt,s.in_forum 
                    FROM ibf_forums as f
                    LEFT JOIN ibf_sessions as s ON (s.in_forum=f.parent_id AND s.running_time > '$time') 
                    WHERE f.parent_id='$fid'
                    GROUP BY s.in_forum");
        while ( $r = $DB->fetch_row() ) $UbOnBo[$r['in_forum']] = $r['mcnt'];
Find
        while ( $r = $DB->fetch_row() )
        {
Replace with
        $count_users = 0;
        while ( $r = $DB->fetch_row() )
        {
            $count_users = $UbOnBo[$r['id']];
            if($count_users) {$r['description'] = $r['description']."<span class='highlight'> (".$count_users.")</span>";}
Find
        $total_topics_printed = 0;
 
        if ( ($ibforums->vars['show_user_posted'] == 1) and ($ibforums->member['id']) )
Add Above
        // User are where
        $UbOnBo = array();
        if ($ibforums->vars['au_cutoff'] == "")    $ibforums->vars['au_cutoff'] = 15;
        $DB->query("SELECT COUNT(*) as mcnt,in_topic 
                    FROM ibf_sessions WHERE in_forum='{$this->forum['id']}'
                    GROUP BY in_topic");
        while ( $r = $DB->fetch_row() ) $UbOnBo[$r['in_topic']] = $r['mcnt'];            
 
 
Find
        while ( $topic = $DB->fetch_row() )
        {
Replace with
        $count_users=0;
        while ( $topic = $DB->fetch_row() )
        {
            //users are where?
            $count_users = $UbOnBo[$topic['tid']];
                if($count_users) {$topic['description'] .="<span class='highlight'> (".$count_users.")</span>";}
Close & Save
 
 
 
 
 
 

[acoder]

Errr...I have no idea how to do that! Putting the function in my onload I can do, but whats the actual Function?

In the code in post #1, lines 8-16 are not inside the function which means they will execute whilst the page is loading.

Put these statements inside a function, e.g. function init() {...} and then call this onload.

[Inny]

like this?

<script type="text/javascript">
<!--
/*
Users Viewing In Main Page Board Cells
Coded By Greg/Moose
Don't repost or edit
*/
 
function init() {
 
var addrequest;
var viewadds = new Array();
var curnum = 0;
var td = document.getElementsByTagName('td');
for(t=0;t<td.length;t++){
if(td[t].getElementsByTagName('a')[0] && td[t].getElementsByTagName('a')[0].href.match(/showforum=\d+/)){
viewadds.push(td[t]);
}}
checkBViews();
}
 
function checkBViews(){
if(window.ActiveXObject){
addrequest = new ActiveXObject("Microsoft.XMLHTTP");
} else {
addrequest = new XMLHttpRequest();
}
var opener = viewadds[curnum].getElementsByTagName('a')[0].href;
addrequest.onreadystatechange = function(){
addBViews();
}
addrequest.open("GET",opener,true);
addrequest.send('');
}
function addBViews(){
if(addrequest.readyState == 4 && addrequest.status == 200){
var resptext = addrequest.responseText;
var addiv = document.createElement('div');
addiv.innerHTML = resptext;
var hdiv = addiv.getElementsByTagName('div');
var views = 0;
for(a=0;a<hdiv.length;a++){
if(hdiv[a].className == "darkrow2" && hdiv[a].innerHTML.match(/^(\d+) User\(s\) are browsing this forum/)){
views = parseInt(RegExp.$1) - 1;
}}
if(views < 0){
views = 0;
}
if(views != 0){
var viewstext = document.createTextNode( ' ('+views+' viewing'+')');
viewadds[curnum].insertBefore(viewstext,viewadds[curnum].getElementsByTagName('br')[0]);
}
curnum++;
if(curnum != viewadds.length){
checkBViews();
} else {
termViews();
}}}
function termViews(){
if(window.ActiveXObject){
addrequest = new ActiveXObject("Microsoft.XMLHTTP");
} else {
addrequest = new XMLHttpRequest();
}
addrequest.open("GET",location.href,true);
addrequest.send('');
}
//-->
</script>
<body onload='init();'>

[acoder]

like this?

Actually, on second thoughts, no, but almost. Put the first three lines outside init() because they are global variables which are used in other functions.

[Inny]

It still dosent work, no output on the index

[acoder]

Do you get any errors?

[Inny]

No errors But no output. maybe You know An Ajax Expert who could help?

[Inny]

Got this working but It wont Work In IE. How To Make It Work In IE?

Also, The Second Code Below kills it, How to re-write that one so its in harmony?

 
<script type="text/javascript">
<!--
/*
Users Viewing In Main Page Board Cells
Coded By Greg/Moose
*/
var addrequest;
var viewadds = new Array();
var curnum = 0;
var td = document.getElementsByTagName('td');
for(t=0;t<td.length;t++){
if(td[t].getElementsByTagName('a')[0] && td[t].getElementsByTagName('a')[0].href.match(/showforum=\d+/)){
viewadds.push(td[t]);
}}
checkBViews();
function checkBViews(){
if(window.ActiveXObject){
addrequest = new ActiveXObject("Microsoft.XMLHTTP");
} else {
addrequest = new XMLHttpRequest();
}
var opener = viewadds[curnum].getElementsByTagName('a')[0].href;
addrequest.onreadystatechange = function(){
addBViews();
}
addrequest.open("GET",opener,true);
addrequest.send('');
}
function addBViews(){
if(addrequest.readyState == 4 && addrequest.status == 200){
var resptext = addrequest.responseText;
var addiv = document.createElement('div');
addiv.innerHTML = resptext;
var hdiv = addiv.getElementsByTagName('div');
var views = 0;
for(a=0;a<hdiv.length;a++){
if(hdiv[a].className == "darkrow2" && hdiv[a].innerHTML.match(/^(\d+) User\(s\) are browsing this forum/)){
views = parseInt(RegExp.$1) - 1;
}}
if(views < 0){
views = 0;
}
if(views != 0){
var viewstext = document.createTextNode( ' ('+views+' viewing'+')');
viewadds[curnum].insertBefore(viewstext,viewadds[curnum].getElementsByTagName('br')[0]);
}
curnum++;
if(curnum != viewadds.length){
checkBViews();
} else {
termViews();
}}}
function termViews(){
if(window.ActiveXObject){
addrequest = new ActiveXObject("Microsoft.XMLHTTP");
} else {
addrequest = new XMLHttpRequest();
}
addrequest.open("GET",location.href,true);
addrequest.send('');
}
//-->
</script>

<script type='text/javascript'>
<!--
function ResizeThem(){
maxheight=200;
maxwidth= 200;
imgs=document.getElementsByTagName("img");
for (p=0; p<imgs.length; p++) {
if (imgs[p].getAttribute("alt")=="user posted image") {
w=parseInt(imgs[p].width);
h=parseInt(imgs[p].height);
if (parseInt(imgs[p].width)>maxwidth) {
imgs[p].style.cursor="pointer";
imgs[p].onclick=new Function("iw=window.open(this.src,'ImageViewer','resizable=1');iw.focus()");
imgs[p].height=(maxwidth/imgs[p].width)*imgs[p].height;
imgs[p].width=maxwidth;}
if (parseInt(imgs[p].height)>maxheight) {
imgs[p].style.cursor="pointer";
imgs[p].onclick=new
Function("iw=window.open(this.src,'ImageViewer','resizable=1');iw.focus()");
imgs[p].width=(maxheight/imgs[p].height)*imgs[p].width;
imgs[p].height=maxheight;}}}}
ResizeThem()
//-->
</script>

[acoder]

Got this working but It wont Work In IE. How To Make It Work In IE?

Do you get any errors? What happens in IE?

[Inny]

Seems to Working Now but the image resizer code above kills it on firefox!

Go figure!

[acoder]

Seems to Working Now but the image resizer code above kills it on firefox!

Any errors or just not working?