opening a new window with a switch case

[mcc]

I am having a problem with my homework I cant seem to get the redirection with onClick. The script is supposed to have the user insert the name and password and the choose a department from a drop down. The instruction state that we have to use a case statement. Below is the code. I’m new here to this forum so please forgive my messiness in the post. Any help will be greatly appreciated THANKS in advance! I know its choppy and I have changes things up so many times I'm sure my mistakes are in the if statement throught the case ......

here is the script:

<form method = "post" name= "frmlogin" action = "javascript:void(0)"> 
 
User Name<br />
<input type ="text" name ="txtUserName"><br />
<br />
Password<br />
<input type ="text" name ="txtPassword"><br />
<br />
Department</b>
<select name = "1stDepartment">
<option value="employee.htm">Employee</option>
<option value="customer.htm">Customer</option>
<option value="administration.htm">Administration</option>
<option value="finance.htm">Finance</option>
<option value="hr.htm">HR</option>
<option value="it.htm">IT</option>
<option value="managment.htm">Managment</option>
<option value="manufacturing.htm">Manufacturing</option>
<option value="marketing.htm">Marketing</option>
<option value="webmaster.htm">Webmaster</option>
</select><br />
<br />
<input type="button" name= "btnLogin" value="Go to the Department Web Site" onClick ="login()" > 
 
<input type="reset" name= "btnClear" value="Clear Form">
 
 
</form>
 
<script language = "JavaScript">
function login(strUserName){
var strUserName, strPassword, strDepartment;
strUserName = document.frmlogin.txtUserName.value;
strPassword = document.frmlogin.txtPassword.value;
strDepartment = document.frmlogin.value;
 
switch (strUserName){
 case "kFoster":
  if (strPassword = "MST3K"){
    window.location.href= ("strDepartment.htm");
    }
    else{
    location.href= ("loginFormJS.htm");
    }
    break;
 case "CSchawab":
  if (strPassword = "OKC802"){
    location.href= ("strDepartment.htm");
    }
    else{
    location.href= ("loginFormJS.htm");
    }
    break;
 case "FHelms":
  if (strPassword = "telcom52"){
    location.href= ("strDepartment.htm");
    }
    else{
    location.href= ("loginFormJS.htm");
    }
    break;
 case "kShea":
  if (strPassword = "Ghost716"){
    location.href= ("strDepartment.htm");
    }
    else{
    location.href= ("loginFormJS.htm");
    }
    break;
        }
 
 
      }
</script>

[epots9]

Hi mcc welcome to TSDN,

inside your if statements you are using a single equal sign "=", that means your assigning values and it is always true. what you want to do is change
those in the if statement to double equal signs "==", that will test the considtions and return true or false and based on your code it do perform a certain task.

[mcc]

Hi mcc welcome to TSDN,

inside your if statements you are using a single equal sign "=", that means your assigning values and it is always true. what you want to do is change
those in the if statement to double equal signs "==", that will test the considtions and return true or false and based on your code it do perform a certain task.

Thanks I should have known better! Let me give that a try
Thanks again!

[mcc]

Thanks for the welcome...forgot to add that. Anyways I used the == instead of the =. Changed things up.I dont get any errors in IE or FireFox error council, but is still does not direct to the page or any error page. Still stuck!
Thanks
redone

<form method = "post" name= "frmlogin" action = "javascript:void(0)"> 
 
User Name<br />
<input type ="text" name ="txtUserName"><br />
<br />
Password<br />
<input type ="text" name ="txtPassword"><br />
<br />
Department</b>
<select name = "1stDepartment">
<option value="employee.htm">Employee</option>
<option value="customer.htm">Customer</option>
<option value="administration.htm">Administration</option>
<option value="finance.htm">Finance</option>
<option value="hr.htm">HR</option>
<option value="it.htm">IT</option>
<option value="managment.htm">Managment</option>
<option value="manufacturing.htm">Manufacturing</option>
<option value="marketing.htm">Marketing</option>
<option value="webmaster.htm">Webmaster</option>
</select><br />
<br />
<input type="button" name= "btnLogin" value="Go to the Department Web Site" onClick ="login()" > 
 
<input type="reset" name= "btnClear" value="Clear Form">
 
 
</form>
 

<script language = "JavaScript">
function login(strUserName){
var strUserName, strPassword, strDepartment;
strUserName = document.frmlogin.txtUserName.value;
strPassword = document.frmlogin.txtPassword.value;
strDepartment = document.frmlogin.value;
 
switch (strUserName){
 case "kFoster":
  if (strPassword == "MST3K"){
    location.href= strDepartment;
    }
    else{
    location.href= "loginFormJS.htm";
    }
    break;
 case "CSchawab":
  if (strPassword == "OKC802"){
    location.href= strDepartment;
    }
    else{
    location.href= "loginFormJS.htm";
    }
    break;
 case "FHelms":
  if (strPassword == "telcom52"){
    location.href= strDepartment;
    }
    else{
    location.href= "loginFormJS.htm";
    }
    break;
 case "kShea":
  if (strPassword == "Ghost716"){
    location.href= strDepartment;
    }
    else{
    location.href= "loginFormJS.htm";
    }
    break;
        }
 
 
      }
</script>

[pbmods]

Heya, MCC.

JavaScript CODE tags make your JavaScript easier to read:
[CODE=javascript]
JavaScript code goes here.
[/CODE]

Try alert()ing strUserName before your switch to make sure that you're getting a value, and to confirm that the login() function is getting evaluated.

[acoder]

mcc, on line 2 in your Javascript, remove the strUsername argument. You're not using it anyway.

For the strDepartment, rename the select so that it doesn't start with a number.

Then, access the select element properly like you have with the username and password.