Passing arguments dynamically to onclick event / Scope of variables

[Csanád]

Hi,

Here's my form:

http://www.steinrogan.com/SecureSite_v2_beta/addthis.php

When I add two or more Dependant Items and remove one that's not the last that I added, I won't be able to remove any more Dependant Items. Say I deleted the first Dependant Item and try to remove the second Dependant Item - it will try to look for the link inactive.html that should never be accessed.

I believe the problem is with reassigning the onclick attribue values. I spent the whole day yesterday on this, but can't figure out what I'm doing wrong.

Any help is greatly appreciated,

Thank you!

Csanád

[Csanád]

Hi,

I have the following function. Everything works except the assignment of the onclick event on line 20. I need to pass 3 arguments dynamically to the function call like this: rmdep(this, i, d). How do I go about this?

Thanks for your time,

Csanád

function rmdep(what,i,d)
{ // i is the index of current Item
  // d is the index of current Dependant Item
  var deps=document.getElementById('dep_'+i).value; // deps is the number of Dependant Items for current Item
  if (d==deps) // remove the last Dependant Item
  {
    deps--;
    document.getElementById('dep_'+i).value=deps;
  }
  else // remove Dependant Item from the middle of list; renumber following Dependant Items 
  {    
    var q=d+1;
    var depup;
    for (q; q<=deps; q++)
    {
        depup=document.getElementById(i+'_'+q);
        depup.setAttribute('name','f'+i+'_'+d);
        depup.setAttribute('id',i+'_'+d);
        depup.previousSibling.previousSibling.firstChild.nodeValue='Dependant Item ['+d+']';
        depup.nextSibling.nextSibling.onclick='rmdep(this,i,d); return false';
        depup.nextSibling.nextSibling.setAttribute('id','r_'+i+'_'+d);
        d++;
    }
    deps--;
    document.getElementById('dep_'+i).value=deps; 
  }    
  while (what && what.tagName!='DIV') { what=what.parentNode; }
  if (what) what.parentNode.removeChild(what);
}

[acoder]

Try:

depup.nextSibling.nextSibling.onclick='rmdep('+this+','+i+','+d+'); return false;';

[Csanád]

Thanks Acoder! Your help is greatly appreciated, but something is still not quite right with my code and it's driving me crazy! :)

You can check it out here:

http://www.steinrogan.com/SecureSite_v2_beta/addthis.php

Please do the following:

- add 4 Dependant Items,
- remove the second Dependant Item (the idea here is that Dependant Items [3] and [4] get renumbered to [2] and [3], respectively)
- try removing the very first Dependant Item.

This is where the code crashes. I believe the trouble is coming from the "this" keyword's reassignment, but I'm not sure.

Any ideas?

Thanks very much!!

Csanád

[dmjpro]

Try:

depup.nextSibling.nextSibling.onclick='rmdep('+this+','+i+','+d+'); return false;';

It will work fine if you write.......

depup.nextSibling.nextSibling.setAttribute('onclick','rmdep(,'+i+','+d+'); return false;');

this needs not to be appended, but you have to append i and d these are the JavaScript Variables.
I hope it will work fine.
And all the best with your try.

Kind regards,
Dmjpro.

[Csanád]

The problem is gone. :) Thank you so much for your help Acoder and Dmjpro!!

All the best!

Cheers,

Csanád

[acoder]

Glad you got it working. So how exactly did you get it working?

[Csanád]

Glad you got it working. So how exactly did you get it working?

Truth be told, I don't know. :) All I did was that I deleted all the alerts from the function that were there to help me find the bug...and shushhh, with that, everything worked like a charm. In other words, the error I described earlier could not be reproduced. It's still a mystery. But it's working, so I'm happy!

Thank you again for your help!

Cheers,

Csanád

[dmjpro]

It will work fine if you write.......

depup.nextSibling.nextSibling.setAttribute('onclick','rmdep(,'+i+','+d+'); return false;');

this needs not to be appended, but you have to append i and d these are the JavaScript Variables.
I hope it will work fine.
And all the best with your try.

Kind regards,
Dmjpro.

I did a mistake here.....!!

depup.nextSibling.nextSibling.setAttribute('onclick','rmdep(this,'+i+','+d+'); return false;');

Kind regards,
Dmjpro.