document.getElementbyID('TICKER') has no properties

RommelTJ

Hi,

My website (http://www.justiceinmexico.org/indextest.php) looks good in Firefox, but horrible in IE, and I think it's because of an error in the javascript of a free web ticker I got off the internet.

When I run Firebug on it, it says:

document.getElementById("TICKER") has no properties
TICKER_CONTENT = document.getElementById("TICKER").innerHTML;
Here is the complete script:

Expand|Select|Wrap|Line Numbers

 
// WebTicker by Mioplanet

3// www.mioplanet.com

4

5TICKER_CONTENT = document.getElementById("TICKER").innerHTML;

6

7TICKER_RIGHTTOLEFT = false;

8TICKER_SPEED = 1;

9TICKER_STYLE = "font-family:Arial; font-size:12px; color:#444444";

10TICKER_PAUSED = false;

11

12ticker_start();

13

14function ticker_start() {

15 var tickerSupported = false;

16 TICKER_WIDTH = document.getElementById("TICKER").style.width;

17 var img = "<img src=ticker_space.gif width="+TICKER_WIDTH+" height=0>";

18

19 // Firefox

20 if (navigator.userAgent.indexOf("Firefox")!=-1 || navigator.userAgent.indexOf("Safari")!=-1) {

21 document.getElementById("TICKER").innerHTML = "<TABLE cellspacing='0' cellpadding='0' width='100%'><TR><TD nowrap='nowrap'>"+img+"<SPAN style='"+TICKER_STYLE+"' ID='TICKER_BODY' width='100%'>&nbsp;</SPAN>"+img+"</TD></TR></TABLE>";

22 tickerSupported = true;

23 }

24 // IE

25 if (navigator.userAgent.indexOf("MSIE")!=-1 && navigator.userAgent.indexOf("Opera")==-1) {

26 document.getElementById("TICKER").innerHTML = "<DIV nowrap='nowrap' style='width:100%;'>"+img+"<SPAN style='"+TICKER_STYLE+"' ID='TICKER_BODY' width='100%'></SPAN>"+img+"</DIV>";

27 tickerSupported = true;

28 }

29 if(!tickerSupported) document.getElementById("TICKER").outerHTML = ""; else {

30 document.getElementById("TICKER").scrollLeft = TICKER_RIGHTTOLEFT ? document.getElementById("TICKER").scrollWidth - document.getElementById("TICKER").offsetWidth : 0;

31 document.getElementById("TICKER_BODY").innerHTML = TICKER_CONTENT;

32 document.getElementById("TICKER").style.display="block";

33 TICKER_tick();

34 }

35}

36

37function TICKER_tick() {

38 if(!TICKER_PAUSED) document.getElementById("TICKER").scrollLeft += TICKER_SPEED * (TICKER_RIGHTTOLEFT ? -1 : 1);

39 if(TICKER_RIGHTTOLEFT && document.getElementById("TICKER").scrollLeft <= 0) document.getElementById("TICKER").scrollLeft = document.getElementById("TICKER").scrollWidth - document.getElementById("TICKER").offsetWidth;

40 if(!TICKER_RIGHTTOLEFT && document.getElementById("TICKER").scrollLeft >= document.getElementById("TICKER").scrollWidth - document.getElementById("TICKER").offsetWidth) document.getElementById("TICKER").scrollLeft = 0;

41 window.setTimeout("TICKER_tick()", 30);

42}

43

pbmods

Heya, Rommel. Welcome to TSDN!

Please use CODE tags when posting source code. See the REPLY GUIDELINES on the right side of the page next time you post.

Does the TICKER element exist at the time that the browser evaluates this JavaScript?

RommelTJ

Heya, Rommel. Welcome to TSDN!

Please use CODE tags when posting source code. See the REPLY GUIDELINES on the right side of the page next time you post.

Does the TICKER element exist at the time that the browser evaluates this JavaScript?

Sorry about that. I apologize for not using the code tags. I read the forum guidelines, but I didn't read the Reply guidelines. I can see them now.

I don't know. I'm a noobie at this. I just copy pasted the free javascript ticker to my website and it messed it up on IE, but not on Firefox.

How can I check if the TICKER element exists at the time that the browser evaluates it?

I think the answer is no, because Firebug doesn't detect an error immediately, it takes about 2 minutes to come up with the error. Sorry for sounding completely clueless, but I am.

By the way, I used the search bar first and it seems that many people hve this problem. However, since I don't know js I can't fix it.

gits

hi ...

there has to be a html-element with the id="TICKER" at your page ... assure that, may be you should refer to the page from where you copied the script.

when do you call the script ... during the load-time of the page or in the body onload event? you should always use the onload-event of the body since the dom of your page is ready to use at this time.

kind regards

RommelTJ

It's inside the body of the html inside a table. Here is the html:

Expand|Select|Wrap|Line Numbers

  <table border="0" width="266">

        <tr>

        <td width="5%"><p><script type="text/javascript" src="webticker_lib.js" language="javascript"></script>

        </p>
 
        <!-- TICKER IS HERE -->

        <DIV ID="TICKER" STYLE="display:none; border-top:1px solid #CCCCCC; border-bottom:1px solid #CCCCCC; overflow:hidden; background-color:#FFFFFF; width:250px" onmouseover="TICKER_PAUSED=true" onmouseout="TICKER_PAUSED=false">
 
        <span style='background-color:#0088FF;'> &nbsp; &nbsp; <B><font color=#ffffff> News and Announcements:</font></a></B>&nbsp; &nbsp; </span>

        <span style='background-color:#006633;'> &nbsp; &nbsp; 

            <B><A href="/news/recent_news.php"><font color=#ffffff> Read our Latest News Report: July 2007</font></a></B>&nbsp; &nbsp; </span>

        <span style='background-color:#CCCCCC;'> &nbsp; &nbsp; 

            <B><A href="/events/seguridad_publica_y_reforma_penal_en_mexico.php"><font color=#ffffff> Recent Event: Seguridad Publica y Reforma Penal en Mexico</font></a></B>&nbsp; &nbsp; </span>

        <span style='background-color:#CC0000;'> &nbsp; &nbsp; 

            <B><A href="/events/binational_forum_on_alternative_criminal_justice.php"><font color=#ffffff> Recent Event: Binational Forum on Alternative Criminal Justice</font></a></B>&nbsp; &nbsp; </span>&nbsp; 

        <span style='background-color:#0088FF;'> &nbsp; &nbsp; 

            <B><A href="http://www.justiceinmexico.org/search/index.php"><font color=#ffffff> Search</font></a></B>&nbsp; &nbsp; </span>

        <span style='background-color:#006633;'> &nbsp; &nbsp; 

            <B><A href="http://www.justiceinmexico.org/contact/index.php"><font color=#ffffff> Contact us/Subscribe</font></a></B>&nbsp; &nbsp; </span>

        <span style='background-color:#CCCCCC;'> &nbsp; &nbsp; 

            <B><A href="http://www.sandiego.edu/tbi/"><font color=#ffffff> USD: Trans-Border Institute</font></a></B>&nbsp; &nbsp; </span>        <span style='background-color:#FFFFFF;'> &nbsp; &nbsp;

        <B><A href="http://www.mioplanet.com/rsc/newsticker_javascript.htm" target="Mio">Scrolling News Ticker</A>

by <a href="http://www.mioplanet.com">Mioplanet</a></B>&nbsp;&nbsp;    </DIV>
 
    <script type="text/javascript" src="webticker_lib.js" language="javascript"></script>        </td>

    </tr>

    </table>    </td>

  </tr>

</table>

Thank you for your help. It is much appreciated. I've been trying to fix this for weeks.

Note: for some reason, my post suddenly put all tags in bold.

RommelTJ

Help would be appreciated.

pbmods

Heya, Rommel.

Try this. Remove this line (I think it's line 12 or so):

Expand|Select|Wrap|Line Numbers

ticker_start();

And then change your HTML slightly:

Expand|Select|Wrap|Line Numbers

<body onload="ticker_start();">

RommelTJ

Heya, Rommel.

Try this. Remove this line (I think it's line 12 or so):

Expand|Select|Wrap|Line Numbers

ticker_start();

And then change your HTML slightly:

Expand|Select|Wrap|Line Numbers

<body onload="ticker_start();">

Thanks, but where should I put the HTML code?

pbmods

Heya, Rommel.

Replace the body declaration ('<body>') in your code with the new code. There is always only one body tag per HTML file.

RommelTJ

Heya, Rommel.

Replace the body declaration ('<body>') in your code with the new code. There is always only one body tag per HTML file.

Oh. Duh.

I already load the common images there and it's a relatively large list under the parenthesis. I put a comma and added the code you gave me, but it still shows up wrong.

Actually, Firebug stopped detecting an error, but IE says there is an error in loading an object in line 6 Char 1. I went to line 6, but those are only common pictures and they were working before.

In any case, the site still looks bad on IE but good on firefox.

RommelTJ

Sorry for double posting, but this makes me irritated.

I decided to take out the webticker from the site, and the site still looks wrong. So there is no problem with the javascript.......It's probably with the html or php.

Sorry to bother you guys.

pbmods

Heya, Rommel.

Try posting over at the HTML/CSS forum. Once you get the display issues hammered out, come on back and let's get the ticker working.

Good luck with your project, and if you ever need anything, post back anytime :)

codegecko

Hi Rommel,

My thoughts are that the JS reference isn't placed in the head section of your site, which is where I would normally put a reference to an external JS file.
Not only that, but check out your markup validation here - it shows more than 300 errors with XHTML Transitional and I had to over-ride on character encoding to iso-8859-1, which is a massive problem.

This could be why it isn't quite parsing correctly - in an ideal world, Javascript does like to deal with clean, compliant code.

My suggestion - clean up your XHTML big-time, then if the script still isn't working, it's one thing we know can't be wrong with it - messy code.

All the best,

medicineworker

RommelTJ

Hi Rommel,
......My suggestion - clean up your XHTML big-time, then if the script still isn't working, it's one thing we know can't be wrong with it - messy code.

All the best,

medicineworker

Thank you very much, I cleaned up my code down to 66 errors. I will iron those out tomorrow.
I still get the getelementbyID has no properties error, so I don't think it's the code.

At least everything is displaying properly at the moment, so I'll leave it at that, and if something arises with the html, I'll post it in the proper forum.

Thank you again.

document.getElementbyID('TICKER') has no properties

Post your reply

Similar topics

Question stats

	Ask Question
Home Questions Articles Browse Topics Latest Top Members FAQ