Expected 'with' to have an indentation of 4 instead of 1.

[rhx]

hi guys.... i have this problem when i validate a form, any thoughts on this one?

function checkAddUserForm()
{
    with (window.document.frmAddUser) {
        if (isEmpty(txtUserName, 'Enter user name')) {
            return;
        } else if (isEmpty(txtPassword, 'Enter password')) {
            return;
        } else {
            submit();
        }
    }
}

[acoder]

Welcome to TSDN!

What do you mean by 'indentation of 4 instead of 1'?

Do you get some sort of error?

[rhx]

Welcome to TSDN!

What do you mean by 'indentation of 4 instead of 1'?

Do you get some sort of error?

i tried checking the function with a js-verifier and got this error.. Problem at line 3 character 2: Expected 'with' to have an indentation of 4 instead of 1.

with (window.document.frmAddUser) {

while on firefox error console it says,

Error: window.document.frmAddUser has no properties


this is my form..
[HTML]<form action="processUser.php?action=add" method="post" enctype="multipart/form-data" name="frmAddUser" id="frmAddUser"">
<table width="100%" border="0" align="center" cellpadding="5" cellspacing="1" class="entryTable">
<tr>
<td width="150" class="label">User Name</td>
<td class="content"> <input name="txtUserName" type="text" class="box" id="txtUserName" size="20" maxlength="20"></td>
</tr>
<tr>
<td width="150" class="label">Password</td>
<td class="content"> <input name="txtPassword" type="password" class="box" id="txtPassword" value="" size="20" maxlength="20"></td>
</tr>
</table>
<p align="center">
<input name="btnAddUser" type="button" id="btnAddUser" value="Add User" onClick="checkAddUserForm();" class="box">
&nbsp;&nbsp;<input name="btnCancel" type="button" id="btnCancel" value="Cancel" onClick="window.location.href='index.php';" class="box">
</p>
</form>[/HTML]

[acoder]

You should avoid using 'with' - see why.

In your case, here, you could just use document.getElementById to access the elements.

[rhx]

You should avoid using 'with' - see why.

In your case, here, you could just use document.getElementById to access the elements.

a lot of thanks acoder,

going back, i now have document.getElementById on my script, but it does not validates.

function checkAddUserForm() {
    var txtUserName = document.getElementById('btnAddUser');
    var txtPassword = document.getElementById('btnAddUser');
 
    if (txtUserName.value === "") {
        return;
    } else if (txtPassword.value === "") {
        return;
    } else {
        submit();
    }
}

[acoder]

On lines 2 and 3, the ids are incorrect. They should be 'txtUsername' and 'txtPassword'.

Instead of having a button calling this validation script, you could call the validate function onsubmit and have a submit button:
[HTML]<form name="..." id="..." action="..." onsubmit="return checkAddUserForm();">[/HTML] and [HTML]<input type="submit" value="Add User">[/HTML] In your validation function, you only need double equals when comparing. Also, return false instead of just 'return'-ing. One final thing: you don't need the submit method call, just return true instead.

[rhx]

On lines 2 and 3, the ids are incorrect. They should be 'txtUsername' and 'txtPassword'.

Instead of having a button calling this validation script, you could call the validate function onsubmit and have a submit button:
[HTML]<form name="..." id="..." action="..." onsubmit="return checkAddUserForm();">[/HTML] and [HTML]<input type="submit" value="Add User">[/HTML] In your validation function, you only need double equals when comparing. Also, return false instead of just 'return'-ing. One final thing: you don't need the submit method call, just return true instead.

thanks a lot acoder... i was able to fix some of the problems.