GetElementById vs. IE7

[RobertoColombo]

Hello all,

I have some simple JavaScript code that changes an image based on some user action (i.e. pushing a button).
I sniff the broiwsers and, in case of IE5+, I use GetElementById and then change the object.src, pointing to the proper gif or jpg.
The code is:

if ( document.getElementById ) // IE5+ & Gecko
{
if ( document.getElementById( id ).innerHTML != null )
{
document.getElementById( id ).innerHTML.src = url;
}
}
else if ( document.getElementById ) // IE5+ & Gecko
{
if ( document.getElementById( id ) != null )
{
document.getElementById( id ).src = url;
}
}
else if (document.all) // IE4
{
if ( document.all[ id ] != null )
{
document.all[ id ].src = url;
}
}
else // Netscape 4
{
if ( document.images[ id ] != null )
{
document.images[ id ].src = url;
}
}

Very basic JavaScript... should it be...
In fact, it works fine with IE5 or IE6 and Netscape, but does not work with IE7.
Is there anything regarding GetElementById and IE7 ?
Or is my piece of script wrong ?

Pelase, help... :-|

[RobertoColombo]

Hello all,

I have some simple JavaScript code that changes an image based on some user action (i.e. pushing a button).
I sniff the broiwsers and, in case of IE5+, I use GetElementById and then change the object.src, pointing to the proper gif or jpg (selected by the "url" variable, previously assigned according to the user action, e.g. button on/off).
The code is:

if ( document.getElementById ) // IE5+ & Gecko
{
if ( document.getElementById( id ).innerHTML != null )
{
document.getElementById( id ).innerHTML.src = url;
}
}
else if ( document.getElementById ) // IE5+ & Gecko
{
if ( document.getElementById( id ) != null )
{
document.getElementById( id ).src = url;
}
}
else if (document.all) // IE4
{
if ( document.all[ id ] != null )
{
document.all[ id ].src = url;
}
}
else // Netscape 4
{
if ( document.images[ id ] != null )
{
document.images[ id ].src = url;
}
}

Very basic JavaScript... should it be...
In fact, it works fine with IE5 or IE6 and Netscape, but does not work with IE7.
Is there anything regarding GetElementById and IE7 ?
Or is my piece of script wrong ?

Please, help... :-|

[r035198x]

Hello all,

I have some simple JavaScript code that changes an image based on some user action (i.e. pushing a button).
I sniff the broiwsers and, in case of IE5+, I use GetElementById and then change the object.src, pointing to the proper gif or jpg.
The code is:

if ( document.getElementById ) // IE5+ & Gecko
{
if ( document.getElementById( id ).innerHTML != null )
{
document.getElementById( id ).innerHTML.src = url;
}
}
else if ( document.getElementById ) // IE5+ & Gecko
{
if ( document.getElementById( id ) != null )
{
document.getElementById( id ).src = url;
}
}
else if (document.all) // IE4
{
if ( document.all[ id ] != null )
{
document.all[ id ].src = url;
}
}
else // Netscape 4
{
if ( document.images[ id ] != null )
{
document.images[ id ].src = url;
}
}

Very basic JavaScript... should it be...
In fact, it works fine with IE5 or IE6 and Netscape, but does not work with IE7.
Is there anything regarding GetElementById and IE7 ?
Or is my piece of script wrong ?

Pelase, help... :-|

Please do not double post.

Threads merged

[acoder]

You can't have

document.getElementById( id ).innerHTML.src;

Get rid of that 'if' code block.

In any case, if the first code block is executed, it's not going to execute the second one which checks for the same thing.