Simple onClick problem

[WSPL5]

I have done this function before and I cannot figure out why it is not working. I am receiving the results of an xmlhttp call and I am looping through the values I am creating links with an OnClick. I created a simple function with just an alert, but the link is not kicking off the function. I have several examples of the same process working on different pages. I must be missing something simple.

This is the code from the relavent section:
The issue is with the onClick of the Anchor Tag.

var D = new ActiveXObject("Microsoft.XMLDOM");
D.async=false;
D.loadXML(xml);
supplierquery.innerHTML='';
var s='';
s=s+'</b><Table class="pnumblock" Style="Background-Color:#f5f5f5;border:1px solid black" cellpadding=0px cellspacing=0px width=100%>';

for(var i=0;i<D.childNodes[0].childNodes.length;i++) {
var e = D.childNodes[0].childNodes[i];
var getVnd = e.getAttribute('xSUPP');

s = s + '<tr valign=top><td Style="border-bottom:1px solid black">
<A HREF="#" onClick="setVnd('+getVnd+')" class="pnum"> '+e.getAttribute('xSUPP')+' </A></td></tr>';
}
s = s + '</table>';
supplierquery.innerHTML = s;

}
}

function setVnd(v) {
alert("got here");
}

[drhowarddrfine]

I'm not a javascript guy but I believe, with xhtml or xml, OnClick needs to be lower case because there it's case sensitive.

[WSPL5]

Thanks, but the correct case of the onClick event is "onClick"
The error I am receiving is --- Error: Expected ')'

[iam_clint]

This

s = s + '<tr valign=top><td Style="border-bottom:1px solid black">
<A HREF="#" onClick="setVnd('+getVnd+')" class="pnum"> '+e.getAttribute('xSUPP')+' </A></td></tr>';
 

Needs To Be

s = s + "<tr valign=top><td Style=\"border-bottom:1px solid black\"><A HREF=\"#\" onClick=\"setVnd('"+getVnd+"');\" class=\"pnum\"> "+e.getAttribute('xSUPP')+" </A></td></tr>";
 

[WSPL5]

Thanks a million, that fixed the problem. I guess I was concentrating on the onClick and did not take into account the rest of the string. The wierd thing is that I have a very similar string in another function that works fine:

Code that works:
s = s + '<tr valign=top><td width=20 Style="Background-color:#fff;border:1px solid gray"><A HREF="#" onClick="delMRB('+getMRBID+')"><img src="/icons/actn011.gif" border=0></A></td><td width=250 Style="Background-color:#fff;border:1px solid gray"><A HREF="#" onClick="setMRB('+e.getAttribute('xPNUM3')+' )"> '+e.getAttribute('xPNUM')+' </A></td><td width=250 Style="Background-color:#fff;border:1px solid gray"> '+e.getAttribute('xPNUM1')+'</td><td Style="Background-color:#fff;border:1px solid gray"> '+e.getAttribute('xPNUM2')+'</td></tr>';

Do you know why this works and the one you fixed didn't? I probably spend more time debugging string issues than anything else in javascript.

Thanks for the help.

[iam_clint]

Because this one

s = s + '<tr valign=top><td width=20 Style="Background-color:#fff;border:1px solid gray"><A HREF="#" onClick="delMRB('+getMRBID+')"><img src="/icons/actn011.gif" border=0></A></td><td width=250 Style="Background-color:#fff;border:1px solid gray"><A HREF="#" onClick="setMRB('+e.getAttribute('xPNUM3')+' )"> '+e.getAttribute('xPNUM')+' </A></td><td width=250 Style="Background-color:#fff;border:1px solid gray"> '+e.getAttribute('xPNUM1')+'</td><td Style="Background-color:#fff;border:1px solid gray"> '+e.getAttribute('xPNUM2')+'</td></tr>';
 

Doesn't have syntax errors
This ones syntax error is here
s = s + '<tr valign=top><td Style="border-bottom:1px solid black">
<A HREF="#" onClick="setVnd("'+getVnd+'")" class="pnum"> '+e.getAttribute('xSUPP')+' </A></td></tr>';

the bold underlined text is all that really needed to be changed but i didn't like the string at all that way so i made it cleaner after i found your error.

[drhowarddrfine]

Thanks, but the correct case of the onClick event is "onClick"

I should have known better but, no, the correct case is 'onclick'. I forgot onclick is an HTML attribute and not javascript. While HTML doesn't care about case, Xhtml and XML do. Therefore, you should always use lowercase.

[pbmods]

Why are you using InnerHTML? Why not just create a template node and then clone it?

Would save you a lot of headaches, especially in the keeping-track-of-quotes department :)