Object doesn't support this property or method

[Darkstar 3D]

Could I get some help on whats going on here. This thing worked in a
previous incarnation. The only change (as my feeble memory recalls) was
changes to the formating of the page.

Help!

http://www.thepurrfectnanny.com/map.php

Code block that errors is:

//Map Change function
function changeMap(){
//user_input = "kennesaw";
user_input = "";
for (i=0;i<document.forms[0].c1.length;i++) {
if (document.forms[0].c1[i].checked) {
user_input = document.forms[0].c1[i].value;
}
}
city = user_input;
onLoad(city);

}

[Daz]

Darkstar 3D wrote:

Could I get some help on whats going on here. This thing worked in a
previous incarnation. The only change (as my feeble memory recalls) was
changes to the formating of the page.

Help!

http://www.thepurrfectnanny.com/map.php

Code block that errors is:

//Map Change function
function changeMap(){
//user_input = "kennesaw";
user_input = "";
for (i=0;i<document.forms[0].c1.length;i++) {
if (document.forms[0].c1[i].checked) {
user_input = document.forms[0].c1[i].value;
}
}
city = user_input;
onLoad(city);

}

Can you provide any hints as to the error you are seeing?

[VK]

Ref. Object doesn't support this property or method

Because you were a very bad boy :-) so you did not pre-declare
user_input variable neither in global nor in local scope:
var user_input;
or
var user_input = "something';

Somewhere on your page you also have added an element with
id="user_input". On IE (always) and on Gecko (in BackCompat mode) it
leads to auto-created variable "user_input" referencing that element.
Because you did not use var the system assumes that you are trying to
assign empty string to that DOM element reference and this is indeed
not allowed.

[Daz]

VK wrote:

Ref. Object doesn't support this property or method

Because you were a very bad boy :-) so you did not pre-declare
user_input variable neither in global nor in local scope:
var user_input;
or
var user_input = "something';

Somewhere on your page you also have added an element with
id="user_input". On IE (always) and on Gecko (in BackCompat mode) it
leads to auto-created variable "user_input" referencing that element.
Because you did not use var the system assumes that you are trying to
assign empty string to that DOM element reference and this is indeed
not allowed.

It's good practise to always use 'var' when declaring variables, unless
you have a specific reason not to. 'var' will make the variable private
to the scope it's in, and it should therefore save a lot of coding
problems, such as the one you experienced. I can't believe I didn't
spot it. Nice site by the way. :)

Daz.

[Darkstar 3D]

VK wrote:

Ref. Object doesn't support this property or method

Because you were a very bad boy :-) so you did not pre-declare
user_input variable neither in global nor in local scope:
var user_input;
or
var user_input = "something';

Somewhere on your page you also have added an element with
id="user_input". On IE (always) and on Gecko (in BackCompat mode) it
leads to auto-created variable "user_input" referencing that element.
Because you did not use var the system assumes that you are trying to
assign empty string to that DOM element reference and this is indeed
not allowed.

Wow! I must have blinders on. :) Think I was too focused on the
conversion or something.

Mucho thanks! Great explanation too as I learned a bit as well.

[Darkstar 3D]

Daz wrote:

It's good practise to always use 'var' when declaring variables, unless
you have a specific reason not to. 'var' will make the variable private
to the scope it's in, and it should therefore save a lot of coding

I do try, still fuming that I missed some. Although, I must admit that
I don't do webpages for a living, but this client was the wife! :)

Nice site by the way. :)

Thanks!