David wrote:
"RobG" wrote:
I'm not quite sure what you mean - if you want to remember the index
value 'i', then yes, you can do that, though you need to avoid a
closure otherwise the value of i will be the same regardless of which
'this' is called (it will be aTags.length).
Try:
aTags[i].onclick = (function(counter){
return function(event){
this.className = 'myClass';
alert(counter);
}
})(i);
The value of 'counter' inside the function is set to the value of 'i'
when the onclick handler is assigned.
var theID = this.somethingOrOtherThatWouldGiveMeTheNumber;
var elementID = document.getElementById("myDiv"+theID);
Replace your 'theID' with my 'counter' (or vice versa) and I think you
have it. :-)
Well, I need to grab the item number within the loop of the script. This
The value 'counter' in the example I gave does exactly that. Each and
every instance of the anonymous function added to an A element by doMe
will have a local variable 'counter' that is set to the value of 'i'
when the function is assigned.
Clicking on A elements will show that (presuming the rest of your code
works).
would better explain it..
function doMe(){
var aTags = document.getElementById("list").getElementsByTagNa me("a");
for (var i=0; i<aTags.length; i++) {
aTags[i].onclick=function() {
var theID = this.somethingOrOtherThatWouldGiveMeTheNumber;
When the A element is clicked on, 'this' will refer to the A element
itself. Does it have a 'somethingOrOtherThatWouldGiveMeTheNumber'
property? I think here is where you wanted to use my 'counter'.
var elementID = document.getElementById("myDiv"+theID);
Presuming that - "myDiv"+theID - resolves to a string, and that string
is the id of an element, then the right hand side will return a
reference to that element. The reference will be assigned to the local
variable 'elementID'.
this.className = "myClass"+elementID;
Again, 'this' here is a reference to the A element. Presuming
'elementID' does actually return an object reference, then
concatenating it to the string "myClass" will result in a string
something like "myClass[HTMLelement]" or "myClass[Object]" or similar.
}
}
}
Where the this.className would then be "myClass3" if the 3rd a tag wac
clicked. I tried a few permutations of your method without success :-((
Here's a full working example:
<title>A play</title>
<script type="text/javascript">
function doMe(){
var theList = document.getElementById("list");
var aTags = theList.getElementsByTagName("a");
for (var i=0, len=aTags.length; i<len; i++){
aTags[i].onclick = (function(counter){
return function(event){
this.className = "myClass" + counter;
alert(this.className); // Just for debug...
}
})(i);
}
}
window.onload = doMe;
</script>
<div id="list">
<a href="#">A0</a><br>
<a href="#">A1</a><br>
<a href="#">A2</a><br>
</div>
Clicking on A0 shows 'myClass0'. Inspecting it in the DOM inspector
shows it has a class of 'myClass0'. A1 has a class of 'myClass1', and
so on.
But nowhere here have we discussed what it is that you are actually
trying to do, so the above may not be what you want at all - it assigns
the class when the element is clicked on. You might want doMe() to
assign the class when it runs, so:
function doMe(){
var theList = document.getElementById("list");
var aTags = theList.getElementsByTagName("a");
for (var i=0, len=aTags.length; i<len; i++){
aTags[i].className = 'myClass' + i;
aTags[i].onclick = function(){
alert(this.className); // Just for debug...
}
}
}
might do the trick.
--
Rob