472,951 Members | 1,564 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

Join Bytes to post your question to a community of 472,951 software developers and data experts.

How to compare two 20 digit numbers in javascript

hi frnds,
Im having two 20digit numbers, But while comparing those it
is giiving wrong ouput in javascript.

for example here is my code,
my secanrio is ,

~ If first 20 digit number is greater number than second 20 digit
number ,then it should return.

* And another important thing is, the two 20digit number will be same
but last one digit only change

Code:

<HTML>
<script language='javascript'>
function numberCheck()
{
var val1=document.getElementById('txt1').value;
var val2=document.getElementById('txt2').value;
if(parseInt(val1) parseInt(val2))
alert("Greater")
else
alert("Correct");

}
</script>
<body>
<input type=text id="txt1" value="18446744073709551617" size=25>
<input type=text id="txt2" value="18446744073709551616" size=25>
<input type=button onclick="numberCheck();" value="check">

</body>
</html>

So here txt1 value is greater than txt2 value, but it returning Correct
alert.
Please tel me reason why its returning like this,
Is there any restriction for comparing more than 20 digits

Jul 28 '06 #1
11 17656
ba*****************@gmail.com said the following on 7/28/2006 1:44 AM:
hi frnds,
Im having two 20digit numbers, But while comparing those it
is giiving wrong ouput in javascript.

for example here is my code,
my secanrio is ,

~ If first 20 digit number is greater number than second 20 digit
number ,then it should return.

* And another important thing is, the two 20digit number will be same
but last one digit only change
If the only thing that can change is the last digit then simply compare
the last character and it doesn't matter how long the "number" is if it
is stored in a string.
<HTML>
<script language='javascript'>
function numberCheck()
{
var val1=document.getElementById('txt1').value;
var lastChar1 = val1.charAt(val1.length-1);
var val2=document.getElementById('txt2').value;
var lastChar2 = val2.charAt(val2.length-1);
Now, simply compare the last 2 characters.
if(parseInt(val1) parseInt(val2))
Don't use parseInt without the second parameter or you may eventually
get unexpected results.

if (+lastChar1>+lastChar2)

<snip>
>
So here txt1 value is greater than txt2 value, but it returning Correct
alert.
Please tel me reason why its returning like this,
The incorrectness introduced by floating point math.
Is there any restriction for comparing more than 20 digits
Probably.

--
Randy
comp.lang.javascript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/
Jul 28 '06 #2
ba*****************@gmail.com wrote:
[...]
So here txt1 value is greater than txt2 value, but it returning Correct
alert.
Please tel me reason why its returning like this,
Is there any restriction for comparing more than 20 digits
Yes, absolutely.

If only the last digit needs to be compared, then Randy has answered
your question. However, if you want to compare large numbers as
numbers, read the following thread:

<URL:
http://groups.google.com/group/comp....73213f5f2e91c5
>
>From that thread:
"The representable range is +/-1.797693134862315710^308 (with
numbers as small as +/-510^-324). The range of precise integer
values is +/-9007199254740992 (+/-2^53)."

Note that there are many integers in the representable range that can't
be represented exactly, starting with integers of 16 digits. That is
well short of your requirement for 20 digits.
--
Rob

Jul 28 '06 #3
Hi Randy,

For a example only ,i told u the last character, It can be any digit in
the whole number, So i want to compare the whole 20 digit number with
other 20 digit number.

I want know ,why is it not comparing correctly. Is there anyother way
to compare

Jul 28 '06 #4
Hi Randy,

For a example only ,i told u the last character, It can be any digit in
the whole number, So i want to compare the whole 20 digit number with
other 20 digit number.

I want know ,why is it not comparing correctly. Is there anyother way
to compare

Jul 28 '06 #5
HI Rob,

Thanks for your information.

Then there no way to compare this. My senario is like that,
what can i do to solve this problem.
Can u give me a suggestion.

Jul 28 '06 #6
ba*****************@gmail.com said the following on 7/28/2006 2:51 AM:
Hi Randy,

For a example only ,i told u the last character, It can be any digit in
the whole number, So i want to compare the whole 20 digit number with
other 20 digit number.
The value of a text input is a string. Do a string comparison and you
don't run into the 16 digit limit.
I want know ,why is it not comparing correctly. Is there anyother way
to compare
Compare them as strings.

if (string1 == string2)
--
Randy
comp.lang.javascript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/
Jul 28 '06 #7

ba*****************@gmail.com wrote:
HI Rob,

Thanks for your information.

Then there no way to compare this. My senario is like that,
what can i do to solve this problem.
Can u give me a suggestion.
An algorithm is:

- get the values as strings (input elements will return strings)
- check they are both integers
- remove leading zeros
- the longest one is bigger
- if they are the same length, check digit by digit
- if the numbers are really big, chec, blocks of say
10 digits at a time.

e.g. the following example returns true only if a and b are integers
and a is bigger than b. If a or b aren't integers, 'undefined' is
returned. Otherwise, if b is bigger or equal to a, false is returned.

function isBigger(a, b)
{
// Make sure they are integers
var re = new RegExp('\\D','g');
if (re.test(a) || re.test(b)){
return undefined;
}

// Trim leading zeros
a = a.replace(/^0+/g,'');
b = b.replace(/^0+/g,'');

// Check lengths
if (a.length != b.length){
return (a.length b.length);
}

// Compare digits
var a = a.split('');
var b = b.split('');
for (var i=0, j=a.length; i<j; i++){
if (+a[i] b[i]) return true;
}
return false;
}

Jul 28 '06 #8
RobG said the following on 7/28/2006 5:07 AM:
ba*****************@gmail.com wrote:
>HI Rob,

Thanks for your information.

Then there no way to compare this. My senario is like that,
what can i do to solve this problem.
Can u give me a suggestion.

An algorithm is:

- get the values as strings (input elements will return strings)
- check they are both integers
- remove leading zeros
If they are defined in the HTML then you can be pretty assured whether
they are numbers or not, but even then, comparing them as strings is
simpler and easier. After removing the leading zeros, if they are equal
as strings they must be equal as numbers. If they aren't equal as
strings then they aren't equal as numbers.

--
Randy
comp.lang.javascript FAQ - http://jibbering.com/faq & newsgroup weekly
Javascript Best Practices - http://www.JavascriptToolbox.com/bestpractices/
Jul 28 '06 #9

RobG wrote:
ba*****************@gmail.com wrote:
HI Rob,

Thanks for your information.

Then there no way to compare this. My senario is like that,
what can i do to solve this problem.
Can u give me a suggestion.

An algorithm is:

- get the values as strings (input elements will return strings)
- check they are both integers
- remove leading zeros
- the longest one is bigger
- if they are the same length, check digit by digit
- if the numbers are really big, chec, blocks of say
10 digits at a time.

e.g. the following example returns true only if a and b are integers
and a is bigger than b. If a or b aren't integers, 'undefined' is
returned. Otherwise, if b is bigger or equal to a, false is returned.

function isBigger(a, b)
{
// Make sure they are integers
var re = new RegExp('\\D','g');
if (re.test(a) || re.test(b)){
return undefined;
}

// Trim leading zeros
a = a.replace(/^0+/g,'');
b = b.replace(/^0+/g,'');

// Check lengths
if (a.length != b.length){
return (a.length b.length);
}

// Compare digits
var a = a.split('');
var b = b.split('');
for (var i=0, j=a.length; i<j; i++){
if (+a[i] b[i]) return true;
}
return false;
}
Rob, I think you've got a great solution for the problem.
But, I'm going to offer up something a little more general purpose.
Inspired by Java's BigDecimal object. I'm going to propose a BigInteger
for java that will allow for comparison of really large numbers.
/*
* Representation of a big integer.
* the compare method returns a value greater than zero if the
comparing
* object is greater, a negative number if the object compared is
greater,
* or zero if the objects are equal.
*/
function BigInteger(strVal) {
this.parts = new Array();
for(var i=0; i<strVal.length; i++){
this.parts[i] = +strVal.charAt(i);
}
this.compare = function(num){
var thisLength = this.parts.length;
var numLength = num.parts.length;
var greater = 0;
if(thisLength == numLength && thisLength>0){
var cnt = thisLength-1;
while( greater==0 && cnt >= 0 ){
greater = this.parts[cnt] - num.parts[cnt];
cnt--;
}
} else {
greater = (thisLength numLength)?(1):(-1);
}
return greater;
}
}
Granted, creating an array of numbers is probably overkill for simple
comparison it does simplify extending to allow mathematical operations
pretty easily.

The original number check function could be modified to use this like:
function numberCheck()
{
var val1=document.getElementById('txt1').value;
var val2=document.getElementById('txt2').value;
var val1Bigint = new BigInteger(val1);
var val2Bigint = new BigInteger(val2);

var comp = val1Bigint.compare(val2Bigint);
if(comp==0) {
alert("Equal");
} else if(comp>0){
alert("Greater")
} else {
alert("Less");
}
}

Jul 28 '06 #10
JRS: In article <11**********************@b28g2000cwb.googlegroups .com>
, dated Fri, 28 Jul 2006 02:07:30 remote, seen in
news:comp.lang.javascript, RobG <rg***@iinet.net.auposted :
>
ba*****************@gmail.com wrote:
> Can u give me a suggestion.
That must seem very polite, to a Burmese.
>An algorithm is:

- get the values as strings (input elements will return strings)
- check they are both integers
But -79, +3, 123e45, 123e4567 are all integers. *Probably* he means
all-digit strings.
- remove leading zeros
Probably. But 077 = 0x3F = 63 = 0.63e2, maybe.
>function isBigger(a, b)
{
// Make sure they are integers
var re = new RegExp('\\D','g');
I don't see that 'g' is needed, any non-digit fails an all-digit format.
if (re.test(a) || re.test(b)){
return undefined;
}

// Trim leading zeros
a = a.replace(/^0+/g,'');
b = b.replace(/^0+/g,'');
Ditto.
// Check lengths
if (a.length != b.length){
return (a.length b.length);
}

// Compare digits
var a = a.split('');
var b = b.split('');
for (var i=0, j=a.length; i<j; i++){
if (+a[i] b[i]) return true;
}
return false;
}
It could be better to compare a.charAt(i) with b.charAt(i); it saves
generating length+length objects. Perhaps I mean charCodeAt throughout.
I suspect you've not handled b<a, though he seems not to need that.
I think I'd go lower-level.

Take strings A & B.

From the Subject line, we can take it that the numbers consist only of
decimal digits, to be interpreted as decimal (if doubtful, use a
preliminary RegExp[*]).

We can also take it that they are of equal length; and, if not, it's
easy to prepend a string of zeroes to the shorter. At this stage they
can in fact be compared as strings.

Otherwise, loop through both strings, subtracting A.charAt[i] and
B.charAt[i]. At the first difference, return that difference. Finally
return 0 (the final difference; so it'd be nice to use
Dif = cA-cB ; if (!Dif) break ; ... return Dif ; ).
ISTM that charAt[i] should be swift given what ECMA seems to say about
all characters using 16 bits. If charAt[50] requires 100 or more bytes
to be considered, I'd not want to use it here.

ISTM that the strings could perhaps be broken up into ten-digit units
with a cunning RegExp (actually, cunning not needed where the length is
a multiple of 10) match, and the resulting strings compared numerically
in turn with unary +.

--
John Stockton, Surrey, UK. ?@merlyn.demon.co.uk Turnpike v4.00 IE 4
<URL:http://www.jibbering.com/faq/>? JL/RC: FAQ of news:comp.lang.javascript
<URL:http://www.merlyn.demon.co.uk/js-index.htmjscr maths, dates, sources.
<URL:http://www.merlyn.demon.co.uk/TP/BP/Delphi/jscr/&c, FAQ items, links.
Jul 28 '06 #11
Hi john,

Thanks for suggestion, Its working fine.

Aug 3 '06 #12

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

9
by: Rune Strand | last post by:
Hi, If I have a lot of integers and want do something with each digit as integer, what is the fastest way to get there? Eg. Make 12345 into an iterable object, like or "12345" (Btw: What is...
4
by: Richard Hollenbeck | last post by:
I'm trying to write some code that will convert any of the most popular standard date formats twice in to something like "dd Mmm yyyy" (i.e. 08 Jan 1908) and compare the first with the second and...
11
by: Nobody | last post by:
Heres the deal... I have an application where I have a list (as in a Windows list control, but thats not important) displayed to the user. I sort this list based on the list controls sort function...
3
by: Dan Gidman | last post by:
Okay all I have a problem. I have two list of adresses and phone numbers. I do not have control over the contents of the lists The only unique field between the two is the phone number. I need...
3
by: Matt | last post by:
if (123 > 33) will return true and if ("123" > 33) will return true So my question is, if the above behaviors are the same?? If string is a number, and compare with another number, it will...
12
by: Assimalyst | last post by:
Hi, I have a working script that converts a dd/mm/yyyy text box date entry to yyyy/mm/dd and compares it to the current date, giving an error through an asp.net custom validator, it is as...
14
by: thehobbit | last post by:
Hi, Could anyone give ideas on how to add 4 20 digit numbers in ANSI C and pass the result back to a calling program in COBOL? We were able to add up to 15 digit numbers without any problems,...
10
by: agendum97 | last post by:
I have three values: UInt64 a, b, c, d; I need to determine if: (a*b) <=(c*d). Naturally, just doing the multiplication and comparing would tell me the result. However, the values could...
7
by: harijay | last post by:
Hi I am a few months new into python. I have used regexps before in perl and java but am a little confused with this problem. I want to parse a number of strings and extract only those that...
0
by: lllomh | last post by:
Define the method first this.state = { buttonBackgroundColor: 'green', isBlinking: false, // A new status is added to identify whether the button is blinking or not } autoStart=()=>{
2
by: DJRhino | last post by:
Was curious if anyone else was having this same issue or not.... I was just Up/Down graded to windows 11 and now my access combo boxes are not acting right. With win 10 I could start typing...
2
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 4 Oct 2023 starting at 18:00 UK time (6PM UTC+1) and finishing at about 19:15 (7.15PM) The start time is equivalent to 19:00 (7PM) in Central...
0
by: Aliciasmith | last post by:
In an age dominated by smartphones, having a mobile app for your business is no longer an option; it's a necessity. Whether you're a startup or an established enterprise, finding the right mobile app...
0
tracyyun
by: tracyyun | last post by:
Hello everyone, I have a question and would like some advice on network connectivity. I have one computer connected to my router via WiFi, but I have two other computers that I want to be able to...
0
isladogs
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 1 Nov 2023 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM) Please note that the UK and Europe revert to winter time on...
3
by: nia12 | last post by:
Hi there, I am very new to Access so apologies if any of this is obvious/not clear. I am creating a data collection tool for health care employees to complete. It consists of a number of...
0
NeoPa
by: NeoPa | last post by:
Introduction For this article I'll be focusing on the Report (clsReport) class. This simply handles making the calling Form invisible until all of the Reports opened by it have been closed, when it...
0
isladogs
by: isladogs | last post by:
The next online meeting of the Access Europe User Group will be on Wednesday 6 Dec 2023 starting at 18:00 UK time (6PM UTC) and finishing at about 19:15 (7.15PM). In this month's session, Mike...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.