javascript: variable has no properties

[sagel]

im trying to iterate thru form elements and pull out the ones with "note" in their name. getting "elementName has no properties" with the following code, and i don't understand why? any help is greatly appreciated. thx!

Code:
 
function saveNotes(){ 
var elementName=''; 
var isNote=''; 
for(i=0; i<document.formNotes.elements.length; i++){ elementName=document.formNotes.elements[i].name; isNote=elementName.indexOf('note'); 
if (isNote!=-1) {
 alert('its a note!'); 
}
}
}

changing "elementName=document.formNotes.elements[i].name;" to "alert(document.formNotes.elements[i].name);" gives me the name. why won't it transfer the name of the element to the variable?

thanks!

[acoder]

Without the HTML it'd be difficult to say, but the code would work with, for example:
[html]<form name="formNotes">
<input type="text" name="notes">
<input type="button" onclick="saveNotes()" value="Save">
</form>[/html]

[mrhoo]

Change this line-
elementName=document.formNotes.elements[i].name;
to this:
elementName=document.formNotes.elements[i].name || '';

Chances are your form has a fieldset or some other member that is counted as a form element but returns undefined for the name attribute.

Give your undefined's the empty string, which will return -1 for any indexOf call.