re links and javascript

[adriansuri]

Hi
I have an external javascript file which in included in my html file
header thus:

<script src="/style/common.js" type="text/javascript"></script>

with a function thus

/* simple new window function Adrian Suri common.js */

function loadNewPage(url) {
window.open(url);
return true;
}

now the question is how do I do a nornal href link to call this
function passing the url, note I do not want to use buttons

this does not work
<li><a
href="loadNewPage("http://groups.yahoo.com/group/Dev_Corner/files/C%20&amp;%20C++%20Training/Class%20Lessons/CPPL01NM.TXT)";
Setting up the Watcom compiler</a></li>
regards

Adrian

[VK]

ad********@gmail.com wrote:

Hi
I have an external javascript file which in included in my html file
header thus:

<script src="/style/common.js" type="text/javascript"></script>

with a function thus

/* simple new window function Adrian Suri common.js */

function loadNewPage(url) {
window.open(url);
return true;
}

now the question is how do I do a nornal href link to call this
function passing the url, note I do not want to use buttons

this does not work
<li><a
href="loadNewPage("http://groups.yahoo.com/group/Dev_Corner/files/C%20&amp;%20C++%20Training/Class%20Lessons/CPPL01NM.TXT)";
Setting up the Watcom compiler</a></li>

<a href="MyNoScript.html" onclick="loadNewPage('foo.html');return
false;">

[Evertjan.]

wrote on 16 feb 2006 in comp.lang.javascript:

I have an external javascript file which in included in my html file
header thus:

<script src="/style/common.js" type="text/javascript"></script>

An external .js-file must not so cannot contain html, and <script.. is.

--
Evertjan.
The Netherlands.
(Please change the x'es to dots in my emailaddress)

[adriansuri]

Thanks for that it work, one more question, since some of the links
are so long
is it possible to include an array of links in say an onload method
anmd then use these avalues in the function loadNewPage()

regards

adrian

sorry cannot post via my normal news server, not sure why

[UnaCoder]

To reanswer your first question, I would change the link code to look
like this:

<a href="http://www.blahblahblah.com/morestuff"
onclick="loadNewPage(this.href); return false;">Click Me</a>

This solution seems a little more elegant to me. This would make it
very easy to convert normal links to use your load page function with
out changing anything else in the link. All you would have to do is
add the onclick code, and the link wouldn't break if you removed it.

As for your second question, you could certainly program your
loanNewPage to accept an array of links, but why would you want to do
this? Clarify your question please.

[adriansuri]

the idea was simply to cut down on very long href links
to make it more understandable but
loadNewPage(this.href); return false;" solves the problems for me...

Many thanks for all the help

kind regards

adrian