JRS: In article <11**********************@z14g2000cwz.googlegroups .com>
, dated Mon, 6 Feb 2006 00:50:21 remote, seen in
news:comp.lang.javascript, Phil Powell <ph**************@gmail.com>
posted :
I thought this would work but it seems to not work neither in Netscape
nor in IE:
[code]
<script type="text/javascript">
<!--
// OBTAINED FROM http://www.javascripter.net/faq/settinga.htm
Clearly a site to be avoided.
// NOTE THAT IF YOU SET days TO -1 THE COOKIE WILL BE SET TO YESTERDAY
AND THUS EXPIRE
function setCookie(name, value, days) {
var today = new Date();
var expire = new Date();
if (days == null || isNaN(days) || days == 0) days = 1;
if (days >= 1 || days < 0) expire.setTime(today.getTime() + 3600000 *
24 * days);
document.cookie = name + '=' + escape(value) + ';expires=' +
expire.toGMTString();
}
There's no need to create two Date Objects just to get an Object set to
24 hours ahead of now.
To get a Date Object whose value does not matter, use new Date(0)
which is quicker. To get a new Date Object E with the same value as a
Date Object D, use E = new Date(+D) .
3600000 * 24 is better written as 864e5.
Code posted should be executable as posted. Do not allow your posting
agent to wrap lines.
You can advance 24 hours, but the description is in terms of days.
Civil days do not always have 24 hours; if you describe the expiry in
days, your users may occasionally get surprised.
Use var T = new Date() ; T.setDate(T.getDate()+1)
Your code seems to assume that the value of days is integer, without
ensuring that.
So how have you guys done this correctly where I have gone wrong?
Your code no doubt does exactly what it should do. You have failed to
say what you want it to do.
It seems that days is read from a user control. If you check the
control with a RegExp you can assure a good value; consider and test
S = control.value
OK = /^[+-]?\d+$/.test(S) // repeat if false?
days = OK ? +S : 1
I suppose that you have checked the incipient cookie string S with, say,
alert(S); probably the error whose consequences you refer to lies
elsewhere.
--
© John Stockton, Surrey, UK. ?@merlyn.demon.co.uk Turnpike v4.00 IE 4 ©
<URL:http://www.jibbering.com/faq/> JL/RC: FAQ of news:comp.lang.javascript
<URL:http://www.merlyn.demon.co.uk/js-index.htm> jscr maths, dates, sources.
<URL:http://www.merlyn.demon.co.uk/> TP/BP/Delphi/jscr/&c, FAQ items, links.