Div not working.

[DBLWizard]

Howdy All,

I am trying to detect if the user has cookies enabled on a page and
display text accordingly. My cookie detection works but I can't get
the divs to work. Here is the javascript and html does anybody have
any sugestions?

<script language="JavaScript">
function window_onload() {
var sCookie;

SetCookie("CookieTest","True");
sCookie = GetCookie("CookieTest");

if (sCookie = "True")
{
divNoCookies.style.display = "none";
divDisclaimer.style.display = "block";
}

}

window.onload = window_onload;
</script>
<div ID="divDisclaimer" Name="divDisclaimer" style="display:none">
<!-- #include file='County\Disclaimer.htm' -->
</div>
<div ID="divNoCookies" Name="divNoCookies" style="display:block">
<tr>
<td>
<FONT color=red>
Your browser or your firewall is not set up to allow
cookies. This site requires session cookies. Please check your
browser
settings or contact your system administrator.
</FONT>
</td>
</tr>
</div>

[Michael Winter]

On 28/03/2005 17:48, DBLWizard wrote:

<script language="JavaScript">
The language attribute has been deprecated for a very long time. Use
the (required) type attribute instead:

<script type="text/javascript">
function window_onload() {
Rather than introducing a global identifier unnecessarily, assign the
function object directly to the onload property:

window.onload = function() {
/* ... */
};
var sCookie;

SetCookie("CookieTest","True");
sCookie = GetCookie("CookieTest");
I hope you check that the cookie property exists and is a string
before writing to it. If not, you'll create a cookie property which
will always contain whatever you assign to it. See
<URL:http://www.jibbering.com/faq/faq_notes/cookies.html>.
if (sCookie = "True")
That expression will always be true as you're assigning the string,
'True', to the sCookie variable. The comparison operator is two
consecutive equals symbols (==). A simple way to avoid this specific
example is to always specify literals and other "r-values"
(expressions that you cannot assign to) first:

if('true' = sCookie) {

In this case, the script engine would report an error as you cannot
assign to a string literal.
divNoCookies.style.display = "none";
divDisclaimer.style.display = "block";
Microsoft came up with (what I think is) a stupid idea where global
variables are created based on the id and name attributes of HTML
elements. This "feature" is not supported and all browsers and should
never be used. Instead, use the getElementById method (with
appropriate feature detection):

var disclaimer = null,
noCookies = null;

if(document.getElementById) {
disclaimer = document.getElementById('divDisclaimer');
noCookies = document.getElementById('divNoCookies');
}
if(disclaimer && disclaimer.style
&& noCookies && noCookies.style)
{
disclaimer.style.display = 'block';
noCookies.style.display = 'none';
}
<div ID="divDisclaimer" Name="divDisclaimer" style="display:none">
DIV elements do not have name attributes.
<div ID="divNoCookies" Name="divNoCookies" style="display:block">
<tr>
<td>
You don't seem to have a table, so you can hardly have table rows or
cells. Even if there is a TABLE element somewhere, a DIV element
cannot be its child. That is,

<table>
<div>

is invalid, however

<table>
<tr>
<td>
<div>

is fine. If you want to group table rows, use a TBODY element:

<table>
<tbody>
<tr><!-- ... --></tr>
<tr><!-- ... --></tr>
</tbody>
</table>
<FONT color=red>

The FONT element is deprecated. A better approach would be to give a P
element a warning class and style that red:

In a style sheet:

.warning {
color: red;
}

<p class="warning">
...
</p>

Hope that helps,
Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.

[kaeli]

In article <11**********************@f14g2000cwb.googlegroups .com>,
ib*********@yahoo.com enlightened us with...

Howdy All,

I am trying to detect if the user has cookies enabled on a page and
display text accordingly. My cookie detection works but I can't get
the divs to work. Here is the javascript and html does anybody have
any sugestions?

Stop coding using vbscript syntax and operators when you're writing
javascript. :)

(see Michael's post for a more involved breakdown of the script's many
issues)

--
--
~kaeli~
"When dogma enters the brain, all intellectual activity
ceases" -- Robert Anton Wilson
http://www.ipwebdesign.net/wildAtHeart
http://www.ipwebdesign.net/kaelisSpace