Please help

[dungping5]

Hi,

I am very new to Javascript, and have some problems with the code for
sorting. My question is in the following web page:

www.pinyinology.com/sort1.html

Thanks for help.

Juli Zhang

[Dietmar Meier]

du*******@yahoo.com wrote:

I am very new to Javascript, and have some problems with the code for
sorting. My question is in the following web page: [...]

Untested quickhack for IDs matching /\D+-\d+/:

function sortByID(a, b) {
var A = a["ID"].toLowerCase().replace(/\d/g,""),
B = b["ID"].toLowerCase().replace(/\d/g,""),
C = a["ID"].replace(/\D/g,""),
D = b["ID"].replace(/\D/g,"");
if (A < B) return -1;
else if (A > B) return 1;
else if (C - D < 0) return -1;
else if (C - D > 0) return 1;
else return 0;
}

In addition to that, you should test if a function exists that
is named like the value you get from the location's search before
you call it:

var sortCriteria = location.search.substring(1);
if (sortCriteria && typeof window[sortCriteria] == "function")
kidney.sort(window[sortCriteria]);

ciao, dhgm

[dungping5]

Dear Dietmar Meier:

Thank you very, very much. The code works perfectly. It is now
sorting correctly:

www.pinyinology.com/sort2.html

Juli Zhang

[Dietmar Meier]

du*******@yahoo.com wrote:

The code works perfectly. It is now sorting correctly: [...]

There's still an error in the other function, sortByPinyin().

Replace

var A = a["Pinyin"].toString.toLowerCase();
var B = b["Pinyin"].toString.toLowerCase();

with

var A = a["Pinyin"].toString().toLowerCase();
var B = b["Pinyin"].toString().toLowerCase();

or, since all these values are of type "string" already, simply

var A = a["Pinyin"].toLowerCase();
var B = b["Pinyin"].toLowerCase();

in lines 134 and 135.

ciao, dhgm

[dungping5]

Dietmar Meier wrote:

du*******@yahoo.com wrote:

The code works perfectly. It is now sorting correctly: [...]

There's still an error in the other function, sortByPinyin().

Replace

var A = a["Pinyin"].toString.toLowerCase();
var B = b["Pinyin"].toString.toLowerCase();

with

var A = a["Pinyin"].toString().toLowerCase();
var B = b["Pinyin"].toString().toLowerCase();

or, since all these values are of type "string" already, simply

var A = a["Pinyin"].toLowerCase();
var B = b["Pinyin"].toLowerCase();

in lines 134 and 135.

ciao, dhgm

Errors corrected accordingly. Now it is in:

www.pinyinology.com/sortable/sort2.html

Thanks again for expertise and kindness.

Sincerely,
Juli Zhang