Shortnening my JS DOM references

[Astra]

Hi All

In one of my JS files, I have a lot of what appears to be unnecessary and
repetitive text, eg:

document.order.cardnumberbox1.value = '';
document.order.cardnumberbox2.value = '';
document.order.cardnumberbox3.value = '';
document.order.cardnumberbox4.value = '';
document.order.cardnumberbox5.value = '';
document.order.cardholder.value = '';
document.order.expirymonth.value = '01';
document.order.expiryyear.value = '2003';
document.order.startmonth.value = 'N/A';
document.order.startyear.value = 'N/A';
document.order.issuenumber.value = 'N/A';
document.order.securitycode.value = '';

To try to shorten the lines and my overall text size I thought I would do
the following:

var doc = 'document.order';

doc.cardnumberbox1.value = '';
doc.cardnumberbox2.value = '';
doc.cardnumberbox3.value = '';
etc... etc..

But it doesn't work.

If poss, could you please advise me as to where I'm gonig wrong.

Thanks Robbie

[Joakim Braun]

"Astra" <in**@NoEmail.com> skrev i meddelandet
news:10*************@corp.supernews.com...

Hi All

In one of my JS files, I have a lot of what appears to be unnecessary and
repetitive text, eg:

document.order.cardnumberbox1.value = '';
document.order.cardnumberbox2.value = '';
document.order.cardnumberbox3.value = '';
document.order.cardnumberbox4.value = '';
document.order.cardnumberbox5.value = '';
document.order.cardholder.value = '';
document.order.expirymonth.value = '01';
document.order.expiryyear.value = '2003';
document.order.startmonth.value = 'N/A';
document.order.startyear.value = 'N/A';
document.order.issuenumber.value = 'N/A';
document.order.securitycode.value = '';

To try to shorten the lines and my overall text size I thought I would do
the following:

var doc = 'document.order';

<snip>

var doc=document.order;

You want a reference to a form, not a concatenated string.

Joakim Braun

[Tom Szabo]

var doc = 'document.order'; >> > var doc = document.order;

without quotes, it should work

Regards,

Tom

[Michael Winter]

On Thu, 2 Dec 2004 16:01:03 -0000, Astra <in**@NoEmail.com> wrote:

[snip]

var doc = 'document.order';

doc.cardnumberbox1.value = '';

As others have pointed out, the code above creates a string, doc, not a
reference to the form. Instead, use:

var form = document.forms['order'],
elem = form.elements;

/* which could be shortened to
* var elem = document.forms['order'].elements;
*/

elem['cardnumberbox1'].value = '';

The forms and elements collections are the most cross-browser approach to
referencing forms and their controls.

[snip]

Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.

[Astra]

Thanks Guys

"Michael Winter" <M.******@blueyonder.co.invalid> wrote in message
news:opsid2a4x5x13kvk@atlantis...
On Thu, 2 Dec 2004 16:01:03 -0000, Astra <in**@NoEmail.com> wrote:

[snip]

var doc = 'document.order';

doc.cardnumberbox1.value = '';

As others have pointed out, the code above creates a string, doc, not a
reference to the form. Instead, use:

var form = document.forms['order'],
elem = form.elements;

/* which could be shortened to
* var elem = document.forms['order'].elements;
*/

elem['cardnumberbox1'].value = '';

The forms and elements collections are the most cross-browser approach to
referencing forms and their controls.

[snip]

Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.