Pass form name and value to a function

[Sen]

This is the Javascript function:
function auto_submit(form_name, value) {
document.form_name.elements[value].click();
}

This is the XHTML:
<select name="category" onchange="auto_submit(this.form.name,'Select')">

So, when choosing an option from the select list, the Select button is
clicked and the form is submitted. Somehow the function only works when
I replace form_name variable with the name of the form. Ex.
document.keychain_selector.elements[value].click();

How can this be solved?

[Michael Winter]

On Fri, 26 Nov 2004 14:45:43 +0100, Sen <[e-mail]> wrote:

This is the Javascript function:
function auto_submit(form_name, value) {
document.form_name.elements[value].click();
}

This is the XHTML:
<select name="category"
onchange="auto_submit(this.form.name,'Select')">
[snip]
How can this be solved?

By passing a reference, not the name:

function auto_submit(form, elem) {
form.elements[elem].click();
}

<select ... onchange="auto_submit(this.form, 'Select');">

However, I'd like to point out that performing an action based upon
selection from a SELECT element is generally a bad idea. It's usually much
better to allow the user to perform the action themselves with a button.

Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.

[ZER0]

On Fri, 26 Nov 2004 14:45:43 +0100, Sen wrote:

This is the Javascript function: function auto_submit(form_name, value) {
document.form_name.elements[value].click();
}
form_name is a string, like your "value" variable, not a form's reference.
So:
document.forms[form_name].elements[value].click();

But you can directly use a reference to form:

<select name="category" onchange="auto_submit(this.form,'Select')">

function auto_submit(f, value) {
f.elements[value].click();
}

or a reference to button:

<select name="category" onchange="auto_submit(this.form.Select)">

function auto_submit(btn) {
btn.click();
}

or:

<select name="category" onchange="this.form.Select.click()">
So, when choosing an option from the select list, the Select button is
clicked and the form is submitted.

But why you don't use the submit method of form object?

<select name="category" onchange="this.form.submit()">

--
ZER0://coder.gfxer.web-designer/

~ Alcune persone sono ancora vive per il semplice motivo che e'
illegale ucciderle.

[Sen]

On 2004-11-26 15:19:31 +0100, "Michael Winter"
<M.******@blueyonder.co.invalid> said:

By passing a reference, not the name:

function auto_submit(form, elem) {
form.elements[elem].click();
}

<select ... onchange="auto_submit(this.form, 'Select');">
Thanks! That worked perfectly :)
However, I'd like to point out that performing an action based upon
selection from a SELECT element is generally a bad idea. It's usually
much better to allow the user to perform the action themselves with a
button.

I fully agree useability & standards wise but the form isn't made for a
wide audience. It's a keychain web app to store my passwords . I can
work a little speedier with this solution.

[Sen]

On 2004-11-26 15:28:33 +0100, ZER0 <ze********@libero.it> said:

form_name is a string, like your "value" variable, not a form's reference.
So: [...] or a reference to button: [...] or: [...]
All solution work perfectly :) but I prefer the shortest one.
But why you don't use the submit method of form object?
<select name="category" onchange="this.form.submit()">

Because I have three submit buttons with different values. Form.submit
doesn't send any value to the cgi.