472,958 Members | 2,144 Online
Bytes | Software Development & Data Engineering Community
Post Job

Home Posts Topics Members FAQ

home > topics > javascript > questions > script help

Join Bytes to post your question to a community of 472,958 software developers and data experts.

Script Help

Help..

We cannot get this script to work..can someone take a look at it and make
suggestions?

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">

<html>
<head>
<title>Convert Temperature</title>
<script language="javascript">
<!-- hide from incompatible browsers
function convert_celcius(){
(document.fahrenheit.value - 32)*5/9;
}
function convert_fahrenheit(){
(document.celcius.value * 1.8)+32;
}
//stop hiding from incompatable browsers -->
</script>
</head>
<body><pre>
<h1>Convert Temperature</h1>
<h3>Enter the temperature in Celcius</h3>
<input type="text" name="fahrenheit"
onChange="fahrenheit.value";>
<input type="button" value="Convert to Celcius"
onClick="alert('Converted to celcius' + convert_celcius[])";><br />
<h3>Enter the temperature in Fahrenheit</h3>
<input type="text" name="celcius"
onChange="celcius.value";>
<input type="button" value="Convert to Fahrenheit"
onClick="alert('Converted to Fahrenheit ' + convert_fahrenheit[]";>
</pre></body>
</html>
Jul 23 '05 #1
6 1564
"Brian" <jo*@joe.com> wrote in message news:2t*************@uni-berlin.de...
Help..

We cannot get this script to work..can someone take a look at it and make
suggestions?


[snip]

<html>
<head>
<title>Convert Temperature</title>
<script type="text/javascript">
function convert_celcius() {
var what = document.getElementById("fahrenheit").value;
var temp = (what - 32) * 5 / 9;
document.getElementById("celcius").value = temp;
return what + " C = " + temp + " F";
}
function convert_fahrenheit() {
var what = document.getElementById("celcius").value;
var temp = (what * 1.8) + 32;
document.getElementById("fahrenheit").value = temp;
return what + " F = " + temp + " C";
}
</script>
</head>
<body>
<pre>
<h1>Convert Temperature</h1>
<h3>Enter the temperature in Celcius</h3>
<input type="text" name="celcius">
<input type="button" value="Convert to Fahrenheit"
onClick="alert(convert_fahrenheit())">
<br />
<h3>Enter the temperature in Fahrenheit</h3>
<input type="text" name="fahrenheit">
<input type="button" value="Convert to Celcius"
onClick="alert(convert_celcius())">
</pre>
</body>
</html>
Jul 23 '05 #2
On Tue, 19 Oct 2004 14:30:12 -0500, Brian <jo*@joe.com> wrote:
Help..

We cannot get this script to work..
In future, please explain what you mean. We can't read minds: you need to
state what *should* occur, what *does* occur, and possibly why that's a
problem.

As things stand, the reasons are clear, here.
can someone take a look at it and make suggestions?
Certainly.
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
You should include the URL.

<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">

Omitting it can fail to switch some browsers into "strict rendering" mode.

[snip]
<script language="javascript">
The language attribute has been deprecated for several years now. Instead,
use the (required) type attribute.

<script type="text/javascript">
<!-- hide from incompatible browsers
Such browsers aren't in use anymore. If I remember correctly, even
Netscape 2 understood what a SCRIPT element is, and Netscape 4 (and its
generation) are considered the oldest browsers to be considered (and even
that's debatable).
function convert_celcius(){
(document.fahrenheit.value - 32)*5/9;
It's unreasonable to assume that this will obtain a reference to the
control, fahrenheit. You also fail to do anything with the result.

Read the FAQ (<URL:http://jibbering.com/faq/>) and its notes
(<URL:http://www.jibbering.com/faq/faq_notes/faq_notes.html>). It contains
information on how to reference elements. You'll either need to include a
FORM, or reference the element with its id.
}
function convert_fahrenheit(){
(document.celcius.value * 1.8)+32;
The same applies here.
}
//stop hiding from incompatable browsers -->
This should be deleted along with the other SGML comment delimiter.
</script>
</head>
<body><pre>
Why a PRE element? I don't see any preformatted text.
<h1>Convert Temperature</h1>
<h3>Enter the temperature in Celcius</h3>
You shouldn't skip heading levels. If you want to change the style of a
heading, use CSS.
<input type="text" name="fahrenheit"
onChange="fahrenheit.value";>
That doesn't do anything. It also suffers from the "bad referencing",
earlier.

For future reference, code inside an intrinsic event can use the this
operator to refer to the current element.
<input type="button" value="Convert to Celcius"
onClick="alert('Converted to celcius' + convert_celcius[])";>
Functions are called using parentheses, not square brackets.
<br />


You're not writing XHTML, so the slash above is invalid.

From this point on, the mistakes above are repeated.

[snip]

Here's a reworked version of your page:

<URL:http://www.mlwinter.pwp.blueyonder.co.uk/clj/brian/basic.html>

It also includes input validation (will accept integers, reals, and
scientific notation) and number formatting (currently set to display 2
decimal places - the toFixed function handles that).

You'll probably want to ignore the isReal and toFixed functions at the
moment. They aren't really readable. If you want to see the effects of
toFixed, the arguments are:

n - The number to format.
p - The number of decimal places to display. Rounding is performed
automatically. The number here must be no less than 0, and no
more than 20 (the default is zero - return an integer).
g - The grouping symbol to use every three digits (the default is
no symbol).

For example,

toFixed(1234.56, 1, ',')

will produce the string, "1,234.6".

Hope that helps,
Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.
Jul 23 '05 #3
On Tue, 19 Oct 2004 19:59:00 GMT, McKirahan <Ne**@McKirahan.com> wrote:

[snip]
var what = document.getElementById("fahrenheit").value;
[snip]
<input type="text" name="fahrenheit">


Mind explaining that, please?

[snip]

Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.
Jul 23 '05 #4
"Michael Winter" <M.******@blueyonder.co.invalid> wrote in message
news:opsf4zjcttx13kvk@atlantis...
On Tue, 19 Oct 2004 19:59:00 GMT, McKirahan <Ne**@McKirahan.com> wrote:

[snip]
var what = document.getElementById("fahrenheit").value;


[snip]
<input type="text" name="fahrenheit">


Mind explaining that, please?

[snip]

Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.


What is your question?

I suppose you are suggesting that I use "id=";
I tested this under IE which supports "name=".

Or did you want a reference to a form field?

Would you prefer the following?

<html>
<head>
<title>Convert Temperature</title>
<script type="text/javascript">
function convert_celcius() {
var what = document.getElementById("fahrenheit").value;
var temp = (what - 32) * 5 / 9;
document.getElementById("celcius").value = temp;
return what + " F = " + temp + " C";
}
function convert_fahrenheit() {
var what = document.getElementById("celcius").value;
var temp = (what * 1.8) + 32;
document.getElementById("fahrenheit").value = temp;
return what + " C = " + temp + " F";
}
</script>
</head>
<body>
<pre>
<h1>Convert Temperature</h1>
<h3>Enter the temperature in Celcius</h3>
<input type="text" id="celcius">
<input type="button" value="Convert to Fahrenheit"
onClick="alert(convert_fahrenheit())">
<br />
<h3>Enter the temperature in Fahrenheit</h3>
<input type="text" id="fahrenheit">
<input type="button" value="Convert to Celcius"
onClick="alert(convert_celcius())">
</pre>
</body>
</html>

Note that the "return" statements were switched from before.
Jul 23 '05 #5
On Wed, 20 Oct 2004 09:53:30 GMT, McKirahan <Ne**@McKirahan.com> wrote:

[snip]
I suppose you are suggesting that I use "id=";
You have to!
I tested this under IE which supports "name=".
Incorrectly.
Or did you want a reference to a form field?
That would do just as well. Probably better, in fact.
Would you prefer the following?


Yes. :)

[snip]

Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.
Jul 23 '05 #6
McKirahan wrote:

<--snip-->

What is your question?

I suppose you are suggesting that I use "id=";
Personally, I would use name= and the forms collection.
I tested this under IE which supports "name=".
IE supports a lot of things that isn't cross-browser. Thats why it sucks
as a test browser.
Or did you want a reference to a form field?
Thats more cross-browser and more backwards compatible.
Would you prefer the following?
No, see the notes.
<html>
<head>
<title>Convert Temperature</title>
<script type="text/javascript">
function convert_celcius() {
var what = document.getElementById("fahrenheit").value;
var what = document.forms['formName'].elements['farenheit'].value;

var temp = (what - 32) * 5 / 9;
document.getElementById("celcius").value = temp;
var what = document.forms['formName'].elements['celsius'].value = temp;
return what + " F = " + temp + " C";
}
function convert_fahrenheit() {
var what = document.getElementById("celcius").value;
var what = document.forms['formName'].elements['celcius'].value;
var temp = (what * 1.8) + 32;
document.getElementById("fahrenheit").value = temp;
var what = document.forms['formName'].elements['farenheit'].value = temp;

return what + " C = " + temp + " F";
}
</script>
</head>
<body>
<pre>
<h1>Convert Temperature</h1>
<h3>Enter the temperature in Celcius</h3>
<form name="formName" action="">
<input type="text" id="celcius">
<input type="text" name="celcius">
<input type="button" value="Convert to Fahrenheit"
onClick="alert(convert_fahrenheit())">
<br />
<h3>Enter the temperature in Fahrenheit</h3>
<input type="text" id="fahrenheit">
<input type="text" name="fahrenheit">
<input type="button" value="Convert to Celcius"
onClick="alert(convert_celcius())">


<form>

Drop the pre's

--
Randy
comp.lang.javascript FAQ - http://jibbering.com/faq
Jul 23 '05 #7
New Post

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

3
Perl Help - Windows Perl script accessing a Unix perl Script
by: dpackwood | last post by:
Hello, I have two different scripts that do pretty much the same thing. The main perl script is on Windows. It runs and in the middle of it, it then calls out another perl script that then...
Perl
4
Script to calculate remaining minutes
by: hupjack | last post by:
I finally joined the millions of cell phone users out there. I'm the 2nd phone on what is now a family share plan. (Our two cell phones use minutes from a central 400 minute peak time pool.)...
Perl
14
Script-generated code displaying differntly than the exact same code displayed staticly... help!?!?!
by: Akbar | last post by:
Hey there, Big-time curiosity issue here... Here's the test code (it's not that long)... it's to display a large number of image links with captions, ideally pulled in from an external file...
Javascript
8
Need help with this script please..
by: Johnny Knoxville | last post by:
I've added a favicon to my site (http://lazyape.filetap.com/) which works fine if you add the site to favourites the normal way, but I have some JavaScript code on a couple of pages with a link,...
Javascript
4
help please - script problem in IE 6 - (but not in Mozilla/Firefox)
by: Derek | last post by:
I have the following script in a page and it gets an error in IE 6. Says something about an invalid argument but the line number doesn't help since I can't see the javascript code when viewing...
Javascript
0
Erratic Sever Side Script Debugging ASP 3.0/.NET DLLs: Problems and Solution
by: ZMan | last post by:
Scenario: This is about debugging server side scripts that make calls to middle-tier business DLLs. The server side scripts are legacy ASP 3.0 pages, and the DLLs are managed DLLs...
ASP.NET
9
What is client startup script?
by: Harry Smith | last post by:
While reading the documentation on IsStartupScriptRegistered, there is a reference to "client startup script" as "Determines if the client startup script is registered with the Page object." What...
ASP.NET
3
How to work out which script to call to Save
by: Angus | last post by:
I have a web page with a toolbar containing a Save button. The Save button can change contextually to be a Search button in some cases. Hence the button name searchsavechanges. The snippet of...
Javascript
3
Re: Script Optimization
by: David | last post by:
On Sun, May 4, 2008 at 4:43 AM, lev <levlozhkin@gmail.comwrote: Hi, I started tidying up the script a bit, but there are some parts I don't understand or look buggy. So I'm forwarding you the...
Python
1
KevinADC
How to Make a File Download Script with Perl
by: KevinADC | last post by:
Note: You may skip to the end of the article if all you want is the perl code. Introduction Many websites have a form or a link you can use to download a file. You click a form button or click...
Perl
0
React to native button blinking effect
by: lllomh | last post by:
Define the method first this.state = { buttonBackgroundColor: 'green', isBlinking: false, // A new status is added to identify whether the button is blinking or not } autoStart=()=>{
Software Development
2
Windows 11 and Access Combo Box Issue
by: DJRhino | last post by:
Was curious if anyone else was having this same issue or not.... I was just Up/Down graded to windows 11 and now my access combo boxes are not acting right. With win 10 I could start typing...
Microsoft Access / VBA
2
isladogs
Access Europe meeting on Wed 4 Oct - The future of Access
by: isladogs | last post by:
The next Access Europe meeting will be on Wednesday 4 Oct 2023 starting at 18:00 UK time (6PM UTC+1) and finishing at about 19:15 (7.15PM) The start time is equivalent to 19:00 (7PM) in Central...
Microsoft Access / VBA
0
tracyyun
Can faster file sharing be achieved by connecting computers simultaneously via WiFi and LAN cables
by: tracyyun | last post by:
Hello everyone, I have a question and would like some advice on network connectivity. I have one computer connected to my router via WiFi, but I have two other computers that I want to be able to...
Networking - Hardware / Configuration
4
NeoPa
Send Current Object to PDF
by: NeoPa | last post by:
Hello everyone. I find myself stuck trying to find the VBA way to get Access to create a PDF of the currently-selected (and open) object (Form or Report). I know it can be done by selecting :...
Microsoft Access / VBA
1
Report value list
by: Teri B | last post by:
Hi, I have created a sub-form Roles. In my course form the user selects the roles assigned to the course. 0ne-to-many. One course many roles. Then I created a report based on the Course form and...
Microsoft Access / VBA
3
Finding a record, and then saving a new record after the record has been amended.
by: nia12 | last post by:
Hi there, I am very new to Access so apologies if any of this is obvious/not clear. I am creating a data collection tool for health care employees to complete. It consists of a number of...
Microsoft Access / VBA
0
NeoPa
VBA Class Basics (Report Class)
by: NeoPa | last post by:
Introduction For this article I'll be focusing on the Report (clsReport) class. This simply handles making the calling Form invisible until all of the Reports opened by it have been closed, when it...
Microsoft Access / VBA
2
Take a Database to the Next Level
by: GKJR | last post by:
Does anyone have a recommendation to build a standalone application to replace an Access database? I have my bookkeeping software I developed in Access that I would like to make available to other...
Microsoft Access / VBA

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.

BYTES.COM © 2023
About Bytes
Terms Of Use
Privacy Policy
Sitemap
Advertise on Bytes:
Post a Job
Sponsored Posts
Platinum & Gold Sponsors
Hire Now!