format currency function has problems

[Abby Lee]

I found the following script somewhere so I can change values to money before
the form is printed. The page works for most people but not some. It worked
fine for me but I get the yellow tri-angle with an exclamation point in the
bottom left part of the window. When I told my IE to display a notification
about every error...it told me there was a problem with line 11.
What is wrong with this?

9 function formatCurrency(strValue)
10 {
11 strValue = strValue.toString().replace(/\$|\,/g,'');
12 dblValue = parseFloat(strValue);
13 blnSign = (dblValue == (dblValue = Math.abs(dblValue)));
14 dblValue = Math.floor(dblValue*100+0.50000000001);
15 intCents = dblValue%100;
16 strCents = intCents.toString();
17 dblValue = Math.floor(dblValue/100).toString();
18 if(intCents<10)
19 strCents = "0" + strCents;
20 for (var i = 0; i < Math.floor((dblValue.length-(1+i))/3); i++)
21 dblValue = dblValue.substring(0,dblValue.length-(4*i+3))+','+
22 dblValue.substring(dblValue.length-(4*i+3));
23 return (((blnSign)?'':'-') + '$' + dblValue + '.' + strCents);
}

error message
Line 11
Char 2
Error 'undefined' is null or not an object
code 0

[Michael Winter]

On Tue, 19 Oct 2004 11:50:30 -0500, Abby Lee <ab*******@hotmail.com> wrote:

I found the following script somewhere [...]
I seriously suggest you put it back.
When I told my IE to display a notification about every error [...]
You don't need to do that. You could just double-click on the icon on the
status bar.
What is wrong with this?

Aside from it being an unreadable mess, and containing some dubious hacks?

Try:

/* n - Number to format (in pennies).
* c - Currency symbol to use (defaults to none).
* g - Grouping symbol (defaults to none).
*
* Outputs a number of the form cngnnngnnn.nn
*
* For example, toCurrency(142635.7, '£', ',') produces
* £1,426.36
*/
function toCurrency(n, c, g) {
var s = (0 > n) ? '-' : ''; n = Math.abs(n);
var m = String(Math.round(n));
var j, i = '', f; c = c || ''; g = g || '';

while(m.length < 3) {m = '0' + m;}
f = m.substring((j = m.length - 2));
while(j > 3) {
i = g + m.substring(j - 3, j) + i;
j -= 3;
}
i = m.substring(0, j) + i;
return s + c + i + '.' + f;
}

Note the instructions for the first parameter: the value should be in
pennies (cents). Currency-related calculations should be performed like
this anyway to reduce the change of errors. If you aren't using pennies
and you don't want to change your existing script, multiply by 100 when
passing the value.

Hope that helps,
Mike

--
Michael Winter
Replace ".invalid" with ".uk" to reply by e-mail.

[Abby Lee]

"Michael Winter" <M.******@blueyonder.co.invalid> writes:

On Tue, 19 Oct 2004 11:50:30 -0500, Abby Lee <ab*******@hotmail.com> wrote:

I found the following script somewhere [...]

I seriously suggest you put it back.

Now that's funny!
thanks for your help.

[Dr John Stockton]

JRS: In article <opsf4o6zuox13kvk@atlantis>, dated Tue, 19 Oct 2004
17:49:22, seen in news:comp.lang.javascript, Michael Winter <M.Winter@bl
ueyonder.co.invalid> posted :

On Tue, 19 Oct 2004 11:50:30 -0500, Abby Lee <ab*******@hotmail.com> wrote:

I found the following script somewhere [...]
I seriously suggest you put it back.

Pereant, inquit, qui ante nos nostra dixerunt.

Try:

/* n - Number to format (in pennies).
* c - Currency symbol to use (defaults to none).
* g - Grouping symbol (defaults to none).
or Thousands separator

ISTM that it should also have
* d - Decimal separator (defaults to '.').
... Note the instructions for the first parameter: the value should be in
pennies (cents).
...

Bring back the ha'penny and farthing!

--
© John Stockton, Surrey, UK. ?@merlyn.demon.co.uk Turnpike v4.00 IE 4 ©
<URL:http://www.jibbering.com/faq/> JL/RC: FAQ of news:comp.lang.javascript
<URL:http://www.merlyn.demon.co.uk/js-index.htm> jscr maths, dates, sources.
<URL:http://www.merlyn.demon.co.uk/> TP/BP/Delphi/jscr/&c, FAQ items, links.