Disabling elements on load

[Rob]

Does anybody see anything wrong ith this code? I want to have the
elements disabled on load by default and it doesn't seem to work this
way.

Thanks
Rob

<script language="Javascript">
<!--
window.onload(DisableElements());

function DisableElements(){
document.forms[0].RepContactDemographic_2_1.disabled = true;
document.forms[0].RepFlightTravelArriveDate_1.disabled = true;
document.forms[0].RepFlightTravelDepartDate_1.disabled = true;
document.forms[0].RepContactDemographic_3_1.disabled = true;
document.forms[0].RepContactDemographic_4_1.disabled = true;
document.forms[0].RepDepartureCity_1.disabled = true;

}

//-->
</script>

*** Sent via Developersdex http://www.developersdex.com ***
Don't just participate in USENET...get rewarded for it!

[Lasse Reichstein Nielsen]

Rob <rv******@hotmail.com> writes:

Does anybody see anything wrong ith this code? I want to have the
elements disabled on load by default and it doesn't seem to work this
way. .... <script language="Javascript"> Should be
<script type="text/javascript">
The type attribute is required by HTML 4, and is always sufficient.
<!--
HTML-comments are not needed here.
window.onload(DisableElements());
This code immediately calls the window's onload property with an
argument that is the return value of calling DisableElements.
What you probably meant was:
---
window.onload = DisableElements;
---
There should be no calling of functions yet.
function DisableElements(){
document.forms[0].RepContactDemographic_2_1.disabled = true;
document.forms[0].RepFlightTravelArriveDate_1.disabled = true;

I would create a variable referring to the form (or event its elements
collection) insted of finding it froms cratch for each line:

var formElems = document.forms[0].elements;
formElems['RepContactDemographic_2_1'].disabled = true;
formElems['RepFlightTravelArriveDate_1'].disabled = true;
...

/L
--
Lasse Reichstein Nielsen - lr*@hotpop.com
DHTML Death Colors: <URL:http://www.infimum.dk/HTML/rasterTriangleDOM.html>
'Faith without judgement merely degrades the spirit divine.'

[Rob]

Thank you, works like a charm.

Rob
*** Sent via Developersdex http://www.developersdex.com ***
Don't just participate in USENET...get rewarded for it!