function

[Samir]

1. Here is my javascript

<script language="JavaScript">
function link(linkname){
strvar1 = linkname
window.main.location=""+strvar1+".asp"
}
</script>

2. Here is part of my code

<img onclick="link(editoffice)" border="0" src="test_m1_i3.png" />

3. I don't know if the script is right or not, but I want to accomplish
that once the image, that the main window location would go to
editoffice.asp

[Ivo]

"Samir" wrote

1. Here is my javascript
You don't describe your problem, but there are a couple of things that could
do with improvement...
<script language="JavaScript"> Drop the language, use type instead:
<script type="text/javascript">
function link(linkname){ The word "link" is highly confusing, as there is already a string method and
so many other things called "link". Name your function "mylink" or something
else.
strvar1 = linkname You don't need to copy the variable here.
Also, not necessary, but it is good practise to end each statement with ;
window.main.location=""+strvar1+".asp" The first (empty) string serves no purpose.
}
</script>

2. Here is part of my code

<img onclick="link(editoffice)" border="0" src="test_m1_i3.png" /> You want "editoffice" as a string, so put it in quotes. Use single quotes
(apostrophes) as the whole function call is already inside double quotes.
3. I don't know if the script is right or not, but I want to accomplish
that once the image, that the main window location would go to
editoffice.asp

What happened when you tried it?

Here is my version:
<script type="text/javascript">
function mylink(linkname){
window.main.location=linkname+".asp";
}
</script>
<img onclick="link('editoffice')" border="0" src="test_m1_i3.png" />
Ivo

[Samir]

Thanks, I just needed the quotes all along.
"Ivo" <[e-mail]> wrote in message
news:40********************@news.wanadoo.nl...

"Samir" wrote

1. Here is my javascript
You don't describe your problem, but there are a couple of things that

could do with improvement...

<script language="JavaScript"> Drop the language, use type instead:
<script type="text/javascript">

function link(linkname){

The word "link" is highly confusing, as there is already a string method

and so many other things called "link". Name your function "mylink" or something else.

strvar1 = linkname

You don't need to copy the variable here.
Also, not necessary, but it is good practise to end each statement with ;

window.main.location=""+strvar1+".asp"

The first (empty) string serves no purpose.

}
</script>

2. Here is part of my code

<img onclick="link(editoffice)" border="0" src="test_m1_i3.png" />

You want "editoffice" as a string, so put it in quotes. Use single quotes
(apostrophes) as the whole function call is already inside double quotes.

3. I don't know if the script is right or not, but I want to accomplish that once the image, that the main window location would go to
editoffice.asp

What happened when you tried it?

Here is my version:
<script type="text/javascript">
function mylink(linkname){
window.main.location=linkname+".asp";
}
</script>
<img onclick="link('editoffice')" border="0" src="test_m1_i3.png" />
Ivo

[Lasse Reichstein Nielsen]

"Samir" <Sa***@hotmail.com> writes:

1. Here is my javascript

<script language="JavaScript">
Should be
<script type="text/javascript">
The "type" attribute is required in HTML 4, and it is always
sufficient.
function link(linkname){
strvar1 = linkname
window.main.location=""+strvar1+".asp"
This could be just:
window.main.location = linkname + ".asp";
although I would prefer:
frames["main"].location = linkname + ".asp";
}
</script>

2. Here is part of my code

<img onclick="link(editoffice)" border="0" src="test_m1_i3.png" />

You want the string "editoffice" to be sent to the link function. However,
what you have written is a variable called "editoffice", and its value
(if it had any) to be sent to the link function. Since the variable doesn't
exist, this will just throw an error.

Use:
<img onclick="link('editoffice');" style="border:none;"
src="test_m1_i3.png" />
(Are you sure you want to write XHTML?)

/L
--
Lasse Reichstein Nielsen - lr*@hotpop.com
DHTML Death Colors: <URL:http://www.infimum.dk/HTML/rasterTriangleDOM.html>
'Faith without judgement merely degrades the spirit divine.'