how to write query for access session query with database

[vishal prada]

ResultSet res = st.executeQuery("select * from regist where Password='"+User_Password+"'");
            if(res.next()==true)
            {
                ps = con.prepareStatement("update regist set Password=?, Confirm_Password=? where Email_Id='"+session.getAttribute( "theEmail" )+"'");
                ps.setString(1, User_NewPassword);
                ps.setString(2, User_ConfirmPassword);
                ps.executeUpdate();
                con.close();

the above code i am write for maintain session and check condition. now i want to know am i write a right query or not. for DAO file bcoz i am write this code in java class file. and error is occur for session can not resolved

[r035198x]

Did you declare session anywhere?
Don't tie your Http objects with your DAO classes. Your DAO should be reusable and testable without knowledge of your client type.
Make your method take the Email and password as String parameters.
Also, always close connections in a finally block.

[vishal prada]

hi r035198x first thanks for quick response.
and sir as u told last time i am now using the java class files for my jsp.
but how to use that declare session
tell me that little code.

[r035198x]

Call that DAO class from your controller (Servlet). In the servlet, you have access to the request, response and session objects.

[vishal prada]

changepassAction.jsp

String theEmail = session.getAttribute("theEmail").toString();

where i am declare the session in string varible.
and my DAO class file is,

changepassclass.java

String theEmail; //declare that again for use.

public String gettheEmail() {
return theEmail;
}
public void settheEmail(String theEmail) {
this.theEmail = theEmail;
}
//this is getter and setter for above declaration.

public String implement(){
try
{
Class.forName("com.mysql.jdbc.Driver");
Connection con=DriverManager.getConnection("jdbc:mysql://127.0.0.1:3306/registration","root","root");
Statement st = con.createStatement();
ResultSet res = st.executeQuery("select * from regist where Password='"+User_Password+"'");
if(res.next()==true)
{
ps = con.prepareStatement("update regist set Password=?, Confirm_Password=? where Email_Id="theEmail,;");
ps.setString(1, User_NewPassword);
ps.setString(2, User_ConfirmPassword);
ps.executeUpdate();
con.close();
System.out.println("record-success.jsp");

//out.print("LOGIN Success");

}
else
{

// this is the condition where i want to check of that particulate user who's session is started..
plz tell me where i am wrong.

[r035198x]

Java is object oriented. Think objects and stop doing everything in one file. It's really bad code. Create classes

class User {
    private String email;
    private String password;
    public User(String email, String password) {
    super();
    this.email = email;
    this.password = password;
    }
    public String getEmail() {
        return email;
    }
    public void setEmail(String email) {
        this.email = email;
    }
    public String getPassword() {
        return password;
    }
    public void setPassword(String password) {
        this.password = password;
    }
 
 
}
 
class DAO {
 
    public User getUser(String email) {
    // Select from DB and create a user object and return that
    }
    public boolean changePassword(String email, String password) {
    //do your update statement here
    }
}
 

Then your JSP doesn't contain process code anymore. It just asks for data from the DAO.