crazy problem..help me.

[vikassawant]

hi,
My problem is some what crazy for me.

Let's see,

I declare one java file named as, test1.java.
In which i designed required GUI for project i.e 8 combobox,two buttons,etc.

Second file is automatic.java in which I get the selected values of combobox by creating the object of test1.java file.
like
test1 tst=new test();

and access value of combobox like
String cmb = tst.cmbv1;

Same as above getting the values of combobox in third file and fourth file.

but when I create the object of class test1,GUI for test1 is executed.

And this is what the problem I faced i.e. 3 times GUI frame for test1 is displayed.

Please tell me how to overcome this problem.Thanks in advance.

Thanks,
Vikas Sawant.

[JosAH]

So you must've created three JFrames, i.e. you have called the constructor for your GUI class three times. You didn't show us any code so we can't give you more details. A few System.out.println() statements on strategic places would soon show you your mistake.

kind regards,

Jos

[vikassawant]

hi,
My code for test1.java is as fallow

import java.awt.Font;
 
public class test1 extends JFrame implements ActionListener 
{
 
  JFrame frame;
  JLabel lbl= new JLabel(); 
  String[] offense = { "HR", "RBI", "SB", "AVG"};
  String[] pitching = { "W", "S", "ERA", "WHIP"};
  String[] cmbint={"0","10","20","30","40","50","60","70","80","90","100"};
  //String[] cmbhr2={"0","10","20","30","40","50","60","70","80","90","100"};
  String[] cmbfloat={"0.200","0.210","0.220","0.230","0.240","0.250","0.260","0.270","0.280","0.290","0.300","0.310","0.320","0.330","0.340","0.350"};
  String[] cmbws={"0","2","4","6","8","10","12","14","16","18","20"};
  String[] cmbera = {"1.0","1.5","2.0","2.5","3.0","3.5","4.0","4.5","5.0"};
  String[] cmbwhip = {"1.00","1.10","1.20","1.30","1.40","1.50","1.60","1.70","1.80","1.90","2.00"};
 
  JButton create,cancel;
  JComboBox Oone,Otwo,Othree,Ofour,Pone,Ptwo,Pthree,Pfour;
  JComboBox Oone2,Otwo2,Othree2,Ofour2,Pone2,Ptwo2,Pthree2,Pfour2;
  public JComboBox hr1,hr2,rbi1,rbi2,sb1,sb2,avg1,avg2;
  public JComboBox s1,s2,w1,w2,era1,era2,whip1,whip2;
  public JComboBox rbi11,rbi21;
 
  static String hrv1,hrv2,rbiv1,rbiv2,sbv1,sbv2,avgv1,avgv2,wv1,wv2,sv1,sv2,erav1,erav2,whipv1,whipv2;
 
 
 
 
  public test1()
  {
 
    frame = new JFrame("Order Of logic");
    frame.setSize(675,560);
    addWindowListener(new WindowAdapter() 
    {
      public void windowClosing(WindowEvent e) 
      {
        System.exit(0);
      }
    });
 
 
try
{
 
    JPanel title = new JPanel();
    title.setLayout(new GridLayout(2,1,5,30));
    JLabel OLabel = new JLabel("Offense :-",JLabel.CENTER);
    title.add(OLabel);
    JLabel PLabel = new JLabel("Pitching :-",JLabel.CENTER);
    title.add(PLabel);
 
    ///////////////////////// offense combo box
 
    JPanel o = new JPanel();
    o.setLayout(new GridLayout(1,4,25,30));
 
    Oone = new JComboBox(offense);
    o.add(Oone);
 
    Otwo = new JComboBox(offense);
    o.add(Otwo);
 
    Othree = new JComboBox(offense);
    o.add(Othree);
 
    Ofour = new JComboBox(offense);
    o.add(Ofour);
 
    ///////////////////////////// pitching combo box
 
    JPanel p = new JPanel();
    p.setLayout(new GridLayout(1,4,25,30));
 
 
    Pone = new JComboBox(pitching);
    p.add(Pone);
 
    Ptwo = new JComboBox(pitching);
    p.add(Ptwo);
 
    Pthree = new JComboBox(pitching);
    p.add(Pthree);
 
    Pfour = new JComboBox(pitching);
    p.add(Pfour);
 
 
 
   Oone.setSelectedIndex(0);
    Otwo.setSelectedIndex(1);
    Othree.setSelectedIndex(2);
    Ofour.setSelectedIndex(3);
 
    Oone.addActionListener(this);
    Otwo.addActionListener(this);
    Othree.addActionListener(this);
    Ofour.addActionListener(this);
 
    Pone.setSelectedIndex(0);
    Ptwo.setSelectedIndex(1);
    Pthree.setSelectedIndex(2);
    Pfour.setSelectedIndex(3);
 
    Pone.addActionListener(this);
    Ptwo.addActionListener(this);
    Pthree.addActionListener(this);
    Pfour.addActionListener(this);
 
 
    TitledBorder tcriteria;
    tcriteria = BorderFactory.createTitledBorder("Select Order Of Logic ");
 
    ////////////////////////////////// panel for buttons
 
    JPanel box= new JPanel();
 
 
    create=new JButton("Create Team");
    box.add(create);
    create.addActionListener(this);
 
    cancel=new JButton("Cancel");
    box.add(cancel);
    cancel.addActionListener(this);
 
 
 
 
    ///////////////////        Panel for order of Logic
    JPanel m= new JPanel();
 
    m.setLayout(new GridLayout(2,2,30,20));
    m.add(o);
    m.add(p);
 
    JPanel mn = new JPanel();
    mn.setBorder(tcriteria);
    mn.add(BorderLayout.WEST,title);
    mn.add(BorderLayout.CENTER,m);
 
 
 
    /////////////////////////////////  arrangment at frame
 
 
    frame.add(BorderLayout.NORTH,mn);
 
    frame.add(BorderLayout.SOUTH,box);
 
 
    frame.setVisible(true);
//    frame.setResizable(false);
 
 
    }catch(Exception e)
    {
        System.out.println(e);
    }
 
 
}
 
  public void actionPerformed(ActionEvent e) 
  {
 
    try
    {
 
     if(e.getSource()==cancel)
    {
        System.exit(0);
        }
 
    else if(e.getSource()==create)
    {
        category[0] =(String)Oone.getSelectedItem();
        category[1] =(String)Otwo.getSelectedItem();
        category[2] =(String)Othree.getSelectedItem();
        category[3] =(String)Ofour.getSelectedItem();
 
        category[4] =(String)Pone.getSelectedItem();
        category[5] =(String)Ptwo.getSelectedItem();
        category[6] =(String)Pthree.getSelectedItem();
        category[7] =(String)Pfour.getSelectedItem();
 
         final Automatic1 automatic1 = new Automatic1(category[0],category[1],category[2],category[3],category[4],category[5],category[6],category[7]);
 
     frame.setContentPane(automatic1);
 
     frame.setLocation(250,150);
     frame.setSize(750,650);
     frame.setVisible(true);
 
    }
 
    }catch(Exception e1)
    {
        System.out.println("hi..."+e1);
    }
 
  }
 
  public static void main(String[] args)
  {
    test1 tst = new test1();
 
  }
}
 

This is the code for test1.java.
when I wanna use the value of combo box in another file.I write code their as

test1 tst = new test1();
String s =tst.cmb1;

and use above code in two files. So when i declare like this test1() constructor called and GUI is displayed. Which I don't want.

I want only at first GUI displayed and when I clicked on button appropriate operation performed.but when I clicked on button and go for next class in which value of variables of test1 is accessed by object of test1 like given above. but because of this GUI displayed 3 times.

How can I overcome this problem.?
Please help me.


Thanks,
vikas sawant

[JosAH]

@vikassawant
There's more trouble: your test1 class is a JFrame because it extends from it but it also has a JFrame because it has a member variable of that class. IMHO that's one JFrame too many.

If you want another class to be able to use that (single) instance of your test1 class you should either pass it as a parameter to, say, the constructor of that other class or you should make that test1 object available in another way. That ugly little singleton pattern comes to mind.

kind regards,

Jos