Problem with uploading images using Jsp

[swethak]

Hi,


My Requirement is to upload the images into database through jsp. For that i write a code .And it works fine .But in that File imgfile = new File("C:/Program Files/Apache Software Foundation/Tomcat 5.5/webapps/test/Blue.jpg"); instead of that i used File imgfile = new File("Blue.jpg"); like that it didn't work. When we browse that image from local system it automatically takes like Blue.jpg and didn't take the full path.
So i got the error as " Blue.jpg not found". Please tell the solution how can i resolve my problem.

 
<%@ page import="java.sql.*" %>
<%@ page import="java.io.*"%>
<%
String connectionURL = "jdbc:mysql://localhost:3306/";
String dbName = "user_register";
Connection connection = null;
PreparedStatement pre=null;
Class.forName("com.mysql.jdbc.Driver").newInstance();
connection = DriverManager.getConnection(connectionURL+dbName, "root", "root");
out.println("connection");
File imgfile = new File("C:/Program Files/Apache Software Foundation/Tomcat 5.5/webapps/test/Blue.jpg");
 out.println("reerr");
 FileInputStream fin = new FileInputStream(imgfile);
  pre = connection.prepareStatement("insert into Image values(?,?,?)");
  pre.setInt(1,3);
            pre.setString(2,"new");
            pre.setBinaryStream(3,fin,(int)imgfile.length());
            pre.executeUpdate();
            out.println("Inserting Successfully!");
            %>
 
 

[r035198x]

That is not how you attach images using JSPs. Instead you should have a form on your JSP with an input of type file so users can pick the file and upload it. You then need to read that form's request on the server using something like Apache's commons-fileupload.jar.

P.S Don't connect to databases in JSP code. Do that in a separate class. JSPs are for presentation.

[ak1dnar]

If you like to use a servlet instead of a jsp file for uploading your files here is an example.
How to Insert files to MySQL blob using Java Servlet

[chaarmann]

@ak1dnar
This sourcecode seems to save a file to disk (the uploaded file), then read this file from disk and then save it to database.
But why save it on disk first (where everybody can access it, for example a scanned passport) if you want to save it inside the mySql database?

See my solution in the
thread titled "Image upload and retrieve from BLOB in jsp"
how to save it directly into the database. (without saving it to disk first)

[swethak]

Hi,


Thank you for your reply. I used the jsp code like mentioned that

When use that code i got the errors. please tell that whats the problem in that.

 
<%@ page import="java.io.File"%>;
<%@ page import="java.io.FileInputStream"%>;
<%@ page import="java.io.IOException" %>;
<%@ page import="java.sql.Connection"%>;
<%@ page import="java.sql.DriverManager"%>;
<%@ page import="java.sql.PreparedStatement"%>;
<%@ page import="java.sql.ResultSet"%>;
<%@ page import="java.sql.Statement"%>;
<%@ page import="java.util.Iterator"%>;
<%@ page import="java.util.List"%>;
<%@ page import="javax.servlet.ServletException"%>;
<%@ page import="javax.servlet.http.HttpServlet"%>;
<%@ page import="javax.servlet.http.HttpServletRequest"%>;
<%@ page import="javax.servlet.http.HttpServletResponse"%>;
<%@ page import="org.apache.commons.fileupload.*"%>;
<%@ page import="java.sql.*"%>
<%@ page import="java.io.*"%>
<%
String connectionURL = "jdbc:mysql://localhost:3306/";
String dbName = "user_register";
Connection connection = null;
PreparedStatement pre=null;
Class.forName("com.mysql.jdbc.Driver").newInstance();
connection = DriverManager.getConnection(connectionURL+dbName, "root", "root");
out.println("connection");
FileUpload fup = new FileUpload();
            DiskFileUpload upload = new DiskFileUpload();
            List items = upload.parseRequest(request);
            Iterator iter = items.iterator();
 
            int count = 0;
            while (iter.hasNext()) {
                count++;
                FileItem item = (FileItem) iter.next();
                File cfile = new File(item.getName());
                File tosave = new File(getServletContext().getRealPath("/temp/"), cfile.getName());
                //item.write(tosave);
                // String file_name = item.getName(); 
                FileInputStream fis = new FileInputStream(tosave);
                int len = (int) tosave.length();
  pre = connection.prepareStatement("insert into Image (image)values(?)");
                //image_data column holds LONGBLOB data type
 
                 pre.setBinaryStream(1, fis, len);
                int rows =  pre.executeUpdate();
            }
 
 %>
 
 

errors :


org.apache.jasper.JasperException: Unable to compile class for JSP

An error occurred at line: 19 in the jsp file: /upload4.jsp
Generated servlet error:
FileUpload cannot be resolved to a type

An error occurred at line: 19 in the jsp file: /upload4.jsp
Generated servlet error:
FileUpload cannot be resolved to a type

An error occurred at line: 19 in the jsp file: /upload4.jsp
Generated servlet error:
DiskFileUpload cannot be resolved to a type

An error occurred at line: 19 in the jsp file: /upload4.jsp
Generated servlet error:
DiskFileUpload cannot be resolved to a type

An error occurred at line: 19 in the jsp file: /upload4.jsp
Generated servlet error:
FileItem cannot be resolved to a type

An error occurred at line: 19 in the jsp file: /upload4.jsp
Generated servlet error:
FileItem cannot be resolved to a type

[ak1dnar]

is org.apache.commons.fileupload jar in place? you have to add the relevant jar to the WEB-INF/lib

[swethak]

hi,

i added the commons-fileuploader.jar in my lib folder.Now it works fine.But i can able to browse the files in temp folder only. If i can browse the other location images it shows the error message as "file not found". Please tell the solution to how i can modify my code according to upload all locations images in my local system

[ak1dnar]

Are you telling, your HTML form can upload only the files which is selected from "temp" directory?

[swethak]

hi


Yes.My Problem exactly that one.And also i got another problem with this script.That is

when is use like that

In that upload.jsp used as above code.

<form name="form-upload" action="POST" action="upload.jsp"  enctype="multipart/form-data">
<input type=file name="ufile">
<input type="submit" name="submit" value="submit">
</form>
 

It works fine. And i added the another filed to form as image name it didn't work. And shows errors

like that

<form name="form-upload" action="POST" action="upload.jsp"  enctype="multipart/form-data">
Image Name<input type="text" name="imagename" value="">
<input type=file name="ufile">
<input type="submit" name="submit" value="submit">
</form>
 

I used like that i got the error as

org.apache.jasper.JasperException: Exception in JSP: /upload4.jsp:37
 
34:             while (iter.hasNext()) {
35:                 count++;
36:                 FileItem item = (FileItem) iter.next();
37:                 File cfile = new File(item.getName());
38:                 File tosave = new File(getServletContext().getRealPath("/temp/"), cfile.getName());
39:                 //item.write(tosave);
40:                 // String file_name = item.getName(); 
 

Stacktrace:

    org.apache.jasper.servlet.JspServletWrapper.handleJspException(JspServletWrapper.java:504)
    org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:393)
    org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
 

root cause

java.lang.NullPointerException
    java.io.File.<init>(Unknown Source)
    org.apache.jsp.upload4_jsp._jspService(upload4_jsp.java:99)
    org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:97)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
    org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:332)
    org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:314)
    org.apache.jasper.servlet.JspServlet.service(JspServlet.java:264)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:802)
 
 

Please tell that solution.How can i modified my code to resolve that 2 problems

[ak1dnar]

Your question is not that much clear to me.
I think you need to POST "imagename" also with your file data.
So, first you need to get the POSTed data from your server page (jsp,servlet).

String name_of_the_file = request.getParameter("imagename");

and then pass that value to your sql statement.

[swethak]

hi,

i passed the field name like that to the next page. It prints the NULL value.

We think it is due to by using form attribute like that

enctype="multipart/form-data" .please i resolve my problem

[farahshafilla]

i have a problem according to this code
----------uploadImage.jsp-------------------------

--%>

<%@page contentType="text/html" pageEncoding="UTF-8"%>
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
   "http://www.w3.org/TR/html4/loose.dtd">
 
<html>
 
<head><title>Image Upload</title></head>
 
<body>
  <form action="UploadImage" method="post" enctype="multipart/form-data" 
           name="productForm" id="productForm"><br><br>
    <table width="400px" align="center" border=0 style="background-color:ffeeff;">
      <tr>
        <td align="center" colspan=2 style="font-weight:bold;font-size:20pt;">
           Image Details</td>
      </tr>
 
      <tr>
        <td align="center" colspan=2>&nbsp;</td>
      </tr>
 
      <tr>
        <td>Image Link: </td>
        <td>
          <input type="file" name="file" id="file">
        <td>
      </tr>
 
      <tr>
        <td></td>
        <td><input type="submit" name="Submit" value="Submit"></td>
      </tr>
      <tr>
        <td colspan="2">&nbsp;</td>
      </tr>
 
    </table>
  </form>
</body>
 
</html>
 

-----------UploadImage.java-----------------------
*/

import java.io.*;
import java.sql.*;
import java.util.*;
import java.text.*;
import java.util.regex.*;
import org.apache.commons.fileupload.servlet.ServletFileUpload;
import org.apache.commons.fileupload.disk.DiskFileItemFactory;
import org.apache.commons.fileupload.*;
 
import javax.servlet.*;
import javax.servlet.http.*;
 
public class UploadImage extends HttpServlet{
  public void doPost(HttpServletRequest request, HttpServletResponse response) 
                throws ServletException, IOException {
    PrintWriter out = response.getWriter();
    boolean isMultipart = ServletFileUpload.isMultipartContent(request);
    System.out.println("request: "+request);
    if (!isMultipart) {
      System.out.println("File Not Uploaded");
    } else {
      FileItemFactory factory = new DiskFileItemFactory();
      ServletFileUpload upload = new ServletFileUpload(factory);
      List items = null;
 
      try {
        items = upload.parseRequest(request);
        System.out.println("items: "+items);
      } catch (FileUploadException e) {
        e.printStackTrace();
      }
      Iterator itr = items.iterator();
      while (itr.hasNext()) {
        FileItem item = (FileItem) itr.next();
        if (item.isFormField()){
          String name = item.getFieldName();
          System.out.println("name: "+name);
          String value = item.getString();
          System.out.println("value: "+value);
        } else {
          try {
            String itemName = item.getName();
            Random generator = new Random();
            int r = Math.abs(generator.nextInt());
 
            String reg = "[.*]";
            String replacingtext = "";
            System.out.println("Text before replacing is:-" + itemName);
            Pattern pattern = Pattern.compile(reg);
            Matcher matcher = pattern.matcher(itemName);
            StringBuffer buffer = new StringBuffer();
 
            while (matcher.find()) {
              matcher.appendReplacement(buffer, replacingtext);
            }
            int IndexOf = itemName.indexOf("."); 
            String domainName = itemName.substring(IndexOf);
            System.out.println("domainName: "+domainName);
 
            String finalimage = buffer.toString()+"_"+r+domainName;
            System.out.println("Final Image==="+finalimage);
 
            File savedFile = new File("C:/apache-tomcat-6.0.16/webapps/example/"+"images\\"+finalimage);
            item.write(savedFile);
            out.println("<html>");
            out.println("<body>");
            out.println("<table><tr><td>");
            out.println("<img src=images/"+finalimage+">");
            out.println("</td></tr></table>");
 
            Connection conn = null;
            String url = "jdbc:mysql://localhost:3306/";
            String dbName = "thundercatz";
            String driver = "com.mysql.jdbc.Driver";
            String username = "root"; 
            String userPassword = "";
            String strQuery = null;
            String strQuery1 = null;
            String imgLen="";
 
            try {
              System.out.println("itemName::::: "+itemName);
              Class.forName(driver).newInstance();
              conn = DriverManager.getConnection(url+dbName,username,userPassword);
              Statement st = conn.createStatement();
              strQuery = "insert into testimage set image='"+finalimage+"'"; 
              int rs = st.executeUpdate(strQuery);
              System.out.println("Query Executed Successfully++++++++++++++");
              out.println("image inserted successfully");
              out.println("</body>");
              out.println("</html>");            
            } catch (Exception e) {
              System.out.println(e.getMessage());
            } finally {
              conn.close();
            }    
          } catch (Exception e) {
            e.printStackTrace();
          }
        }
      }
    }
  }
}
 

and the error is:

javax.servlet.ServletException: Servlet execution threw an exception
    org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:390)
 
root cause
 
java.lang.NoClassDefFoundError: org/apache/commons/io/output/DeferredFileOutputStream
    org.apache.commons.fileupload.disk.DiskFileItemFactory.createItem(DiskFileItemFactory.java:196)
    org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:358)
    org.apache.commons.fileupload.servlet.ServletFileUpload.parseRequest(ServletFileUpload.java:126)
    UploadImage.doPost(UploadImage.java:38)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
    org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:390)
 
root cause
 
java.lang.ClassNotFoundException: org.apache.commons.io.output.DeferredFileOutputStream
    org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1360)
    org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1206)
    java.lang.ClassLoader.loadClassInternal(ClassLoader.java:319)
    org.apache.commons.fileupload.disk.DiskFileItemFactory.createItem(DiskFileItemFactory.java:196)
    org.apache.commons.fileupload.FileUploadBase.parseRequest(FileUploadBase.java:358)
    org.apache.commons.fileupload.servlet.ServletFileUpload.parseRequest(ServletFileUpload.java:126)
    UploadImage.doPost(UploadImage.java:38)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:710)
    javax.servlet.http.HttpServlet.service(HttpServlet.java:803)
    org.netbeans.modules.web.monitor.server.MonitorFilter.doFilter(MonitorFilter.java:390)