JSP image upload problem in linux server

[dirtyhawk]

<%@ page language="java" import="java.sql.*,java.io.File" %>
<%@ include file="../../connection/conn.jsp" %>
<%
     String driver = mysql_driver;
    Class.forName(driver).newInstance();
    Connection con=null;
 
    String s_id = (String)session.getAttribute("login_ses_id");
     //response.setContentType("text/html");
    //response.setHeader("Cache-control","no-cache");
 
    //String err = "";
 
    //String lastFileName = "";
 
    //String contentType = request.getContentType();
    //String boundary = "";
    String msg="";
    String institute_id = null;
    ResultSet rst=null;
    Statement stmt=null;
 
    try
    {
    String url=mysql_con_string;
    con=DriverManager.getConnection(url);
    stmt=con.createStatement();
    //stmt1=con.createStatement();
 
    rst=stmt.executeQuery("select * from institutes join users on users.user_institute_id = institutes.institute_id join subscription on subscription.s_institute_id = institutes.institute_id where user_id='"+s_id+"'");
 
        while(rst.next()){
        institute_id  = rst.getString("institute_id");
        }
 
        }catch(Exception e){
    out.println(e.getMessage());
}
 
 
     response.setContentType("text/html");
    response.setHeader("Cache-control","no-cache");
 
    String err = "";
 
    String lastFileName = "";
 
    String contentType = request.getContentType();
    String boundary = "";
    final int BOUNDARY_WORD_SIZE = "boundary=".length();
    if(contentType == null || !contentType.startsWith("multipart/form-data")) {
      err = "Ilegal ENCTYPE : must be multipart/form-data\n";
      err += "ENCTYPE set = " + contentType;
    }else{
      boundary = contentType.substring(contentType.indexOf("boundary=") + BOUNDARY_WORD_SIZE);
      boundary = "--" + boundary;
      try {
        javax.servlet.ServletInputStream sis = request.getInputStream();
        byte[] b = new byte[1024];
        int x=0;
        int state=0;
        String name=null,fileName=null,contentType2=null;
        java.io.FileOutputStream buffer = null;
        while((x=sis.readLine(b,0,1024))>-1) {
          String s = new String(b,0,x);
          if(s.startsWith(boundary)) {
            state = 0;
            //out.println("name="+name+"<br>");
            //out.println(fileName+"<br>");
 
            name = null;
            contentType2 = null;
            fileName = null;
 
 
          }else if(s.startsWith("Content-Disposition") && state==0) {
            state = 1;
            if(s.indexOf("filename=") == -1)
              name = s.substring(s.indexOf("name=") + "name=".length(),s.length()-2);
            else {
              name = s.substring(s.indexOf("name=") + "name=".length(),s.lastIndexOf(";"));
              fileName = s.substring(s.indexOf("filename=") + "filename=".length(),s.length()-2);
              if(fileName.equals("\"\"")) {
                fileName = null;
              }else {
                String userAgent = request.getHeader("User-Agent");
                String userSeparator="/";  // default
                if (userAgent.indexOf("Windows")!=-1)
                  userSeparator="\\";
                if (userAgent.indexOf("Linux")!=-1)
                  userSeparator="/";
                fileName = fileName.substring(fileName.lastIndexOf(userSeparator)+1,fileName.length()-1);
                if(fileName.startsWith( "\""))
                  fileName = "";
              }
            }
            name = name.substring(1,name.length()-1);
            if (name.equals("file")) {
              if (buffer!=null)
                buffer.close();
              lastFileName = fileName;
              //getServletContext().getRealPath("/images/"+institute_id+".jpg");
 
              buffer = new java.io.FileOutputStream("/opt/tomcat6/webapps/study.lk/admin/institutions/images/"+institute_id+".jpg");
 
                  //String f = getServletConfig().getServletContext().getRealPath();
                  //out.println("");
 
            }
          }else if(s.startsWith("Content-Type") && state==1) {
            state = 2;
            contentType2 = s.substring(s.indexOf(":")+2,s.length()-2);
          }else if(s.equals("\r\n") && state != 3) {
            state = 3;
          }else {
            if (name.equals("file"))
              buffer.write(b,0,x);
          }
        }
        sis.close();
        buffer.close();
      }catch(java.io.IOException e) {
        err = e.toString();
      }
    }
    boolean ok = err.equals("");
    if(!ok) {
     out.println();
    }else{
    msg = "Successfully Updated!!!";
 
    }
%>
 
<script language="javascript">
 
function valLogo(){
 
//user_group = document.registration_form.groups.selectedIndex;
file = document.uploadForm.file.value;
 
    if (file.length==0)
    {
 
        document.getElementById('errorlogo').innerHTML = 'Please first select the image from file';
        document.uploadForm.file.focus();
 
        return false;
    }
}
</script>
<link href="../../stylesheets/text.css" rel="stylesheet" type="text/css" />
<form name="uploadForm" onsubmit="return valLogo()" action="upload.jsp" enctype="multipart/form-data" method="post">
  <table width="100%" border="0" cellspacing="0" cellpadding="0">
    <tr>
      <td colspan="3"><div align="center" class="headline">Add / Edit Logo</div></td>
    </tr>
    <tr>
      <td>&nbsp;</td>
      <td>&nbsp;</td>
      <td>&nbsp;</td>
    </tr>
    <tr>
      <td>&nbsp;</td>
      <td colspan="2" id="errorlogo" class="error"><%=msg%></td>
    </tr>
    <tr>
      <td width="5%">&nbsp;</td>
      <td width="28%">&nbsp;</td>
      <td width="67%">&nbsp;</td>
    </tr>
    <tr>
      <td>&nbsp;</td>
      <td><input name="file" type="file" class="text"/></td>
      <td><input name='Upload'  type="submit" class="text" value='Upload'/></td>
    </tr>
    <tr>
      <td height="57" colspan="3"><p>&nbsp;</p>
      <p align="center"><a href="javascript:window.close();" class="links"><strong>( Close This Window )</strong></a></p></td>
    </tr>
  </table>
</form>

This coding properly working on windows. But when i upload it to linux server images not saving in that folder. But i gave correct path for saving images in linux server. Can anybody help me on this????

[Nepomuk]

If the directory /images exists in the root file system (and all other directories are correct too), then the only thing I could find is line 113:

}else if(s.equals("\r\n") && state != 3) {

"\r\n" is used within textfiles in Windows, but not in Linux (normally). Linux (normally) just uses "\n" instead. I think MACs do it slightly different from both. I'd suggest, if you want to check for Windows or Linux line breaks, use

}else if((s.equals("\r\n") || s.equals("\n")) && state != 3) {

I don't know, if this will solve your problem, but it certainly might help.

Greetings,
Nepomuk

[pronerd]

@dirtyhawk
Not with out any details. What is happening when you try? Either that code is never reached, or an exception is thrown. If it is an exception what does it say?

If you have access to the Linux server try the command below and see if you get an error.

ls /opt/tomcat6/webapps/study.lk/admin/institutions/images/

P.S. Instead of encoding system specific paths in your code it would be better to use the servlet API to get the path of your server, and then just add the relative path to your app inside the server. Then use the File API to avoid system dependent separators. See below.

 
String serverPath = getServletConfig().getServletContext().getRealPath();
 
String imagePath = serverPath + "study.lk"+ File.separator +"admin"+ File.separator +"institutions"+ File.separator +"images"+ File.separator;
 
 

[dirtyhawk]

It's working now. Path is ok. problem was folder permission. i have to enable write permission.

Thanks everybody.