ejbCreate()

[oll3i]

i want in my ejbCreate() to create the database , tables and populate the tables
is it allowed?

my ejbCreate() connects to the database but it does not create the tables

public void ejbCreate() {
    System.out.println("Inside ejbCreate");
 
        Connection connection = null;
        try {
            // get database connection
               connection =this.getConnection(dbURL);
               Statement statement = connection.createStatement();   
 
               // DROP the existing tables
                try
                     {
                     statement.execute ("DROP TABLE contacts");
                     statement.execute ("DROP TABLE books");
                      }
                 catch (SQLException e)
                 {
                  // catch and ignore table not found exception
                 }
 
                 statement.execute("CREATE TABLE contacts("+
                       "CONTACT_ID INTEGER NOT NULL PRIMARY KEY,"+
                       "FIRSTNAME VARCHAR(25) not null,"+
                       "LASTNAME VARCHAR(25) not null,"+
                       "EMAIL VARCHAR(60) not null,"+
                       "CONSTRAINT UNIQUE_EMAIL UNIQUE(EMAIL)");
 
 
 
 
 
              statement.execute("create table BOOKS("+
                    "BOOK_ID INTEGER NOT NULL PRIMARY KEY,"+
                     "AUTHOR VARCHAR(100) not null,"+
                    "TITLE VARCHAR(100) not null,"+
                    "ISBN VARCHAR(10) not null,"+
                     "ISSUE_YEAR SMALLINT not null,"+
                     "CONSTRAINT UNIQUE_ISBN UNIQUE(ISBN)");
 
 
         PreparedStatement preparedstatement = connection.prepareStatement("INSERT INTO CONTACTS (CONTACT_ID,FIRSTNAME, LASTNAME, EMAIL) VALUES (?,?,?,?)"); 
 
         preparedstatement.setInt (1, 1);
         preparedstatement.setString (2, "Jan");
         preparedstatement.setString (3, "Kowalski");
         preparedstatement.setString (4, "[e-mail]");
         preparedstatement.execute ();
 
 
         preparedstatement.setInt (1, 2);
         preparedstatement.setString (2, "Andrzej");
         preparedstatement.setString (3, "Pawlowski");
         preparedstatement.setString (4, "[e-mail]");
         preparedstatement.execute ();
 
 
         preparedstatement.setInt (1, 3);
         preparedstatement.setString (2, "Mariusz");
         preparedstatement.setString (3, "Cygan");
         preparedstatement.setString (4, "[e-mail]");
         preparedstatement.execute ();
 
 
         preparedstatement.setInt (1, 4);
         preparedstatement.setString (2, "Maciej");
         preparedstatement.setString (3, "Nowak");
         preparedstatement.setString (4, "[e-mail]");
         preparedstatement.execute ();
 
 
         preparedstatement.setInt (1, 5);
         preparedstatement.setString (2, "Bartosz");
         preparedstatement.setString (3, "Kasprzak");
         preparedstatement.setString (4, "[e-mail]");
         preparedstatement.execute ();
 
 
 
 
         System.out.println("Inserted rows into table contacts");
 
 
         preparedstatement = connection.prepareStatement("INSERT INTO BOOKS (BOOK_ID,AUTHOR, TITLE, ISBN,ISSUE_YEAR) VALUES (?,?,?,?,?)"); 
 
         preparedstatement.setInt (1, 1);
         preparedstatement.setString (2, "Rafe Coburn");
         preparedstatement.setString (3, "SQL dla każdego");
         preparedstatement.setString (4, "8371972482");
         preparedstatement.setInt (5,2001);
         preparedstatement.execute ();
 
         preparedstatement.setInt (1, 2);
         preparedstatement.setString (2, "Larry Ullman");
         preparedstatement.setString (3, "PHP and MySQL for dynamic web sites");
         preparedstatement.setString (4, "0321186486");
         preparedstatement.setInt (5,2003);
         preparedstatement.execute ();
 
         preparedstatement.setInt (1, 3);
         preparedstatement.setString (2, "David Flanagan");
         preparedstatement.setString (3, "JavaScript(The Definite Guide)");
         preparedstatement.setString (4, "0596000480");
         preparedstatement.setInt (5,2002);
         preparedstatement.execute ();
 
         preparedstatement.setInt (1, 4);
         preparedstatement.setString (2, "Kayshav Dattari");
         preparedstatement.setString (3, "Język C++(Efektywne programowanie obiektowe)");
         preparedstatement.setString (4, "8373618120");
         preparedstatement.setInt (5,2005);
         preparedstatement.execute ();
 
 
         preparedstatement.setInt (1, 5);
         preparedstatement.setString (2, "W.Krysicki L.Wlodarski");
         preparedstatement.setString (3, "Analiza Matematyczna w Zadaniach(część 1)");
         preparedstatement.setString (4, "8301014601");
         preparedstatement.setInt (5,1998);
         preparedstatement.execute ();
 
         System.out.println("Inserted rows into table books");
 
         // close connection, statement
         if (preparedstatement != null)
             preparedstatement.close();
         if (connection != null)
             connection.close();
         System.out.println("Closed statement and connection.");
 
 
        } catch (SQLException sqlException) {
                System.out.println(sqlException.getMessage());
          }          
}
 

[itsraghz]

First of all, writing such a big chunk of tasks in one method is NOT a good OO practice.

If I am right, ejbCreate() NEVER creates a database , table and row. All it just does is "creating/instantiating a bean instance which close tied to and represents a row of database table which should have already been existing".

Hope this helps!

[oll3i]

i read somewhere that i can connect to the db and insert rows in ejbCreate() ?

[itsraghz]

Not so sure of it. Shall check and get back to you!