Time comparison doesnt work...

[panos100m]

Relevant part of the code::

//that code wouldnt work ..its purpose is to compare the current time with a give time (in this case italian)
//output of current time is displayed as 0001 (time is 11:42)
//To be precise 2212 output of given time is displayed as 2213 time is 9:00....any ideas??


public static Calendar now2(int hour,int minute,int sec) {
GregorianCalendar calendar2 = new GregorianCalendar();
calendar2.clear();
calendar2.set(Calendar.HOUR_OF_DAY,hour );
calendar2.set(Calendar.MINUTE,minute);
calendar2.set(Calendar.SECOND,sec);
return calendar2;
}


GregorianCalendar calendar = new GregorianCalendar();

calendar.clear();
calendar.get(Calendar.HOUR_OF_DAY);
calendar.get(Calendar.MINUTE);
calendar.get(Calendar.SECOND);

lanng="IT";
int openingh=-1;
int openingm=-1;
int openings=00;
int closingh=-1;
int closingm=-1;
int closings=00;

// int currentime = Integer.parseInt(now("HHMM"));


if (langg.equalsIgnoreCase("IT"))
{
openingh=9;
openingm=00;
closingm=16;
closings=00;

}
if (langg.equalsIgnoreCase("IT"))
{
openingh=9;
openingm=00;
closingm=10;
closings=00;

}

if (langg.equalsIgnoreCase("DA"))
{
openingh=8;
openingm=00;
closingm=15;
closings=00;

}




SimpleDateFormat format = new SimpleDateFormat("HHMM");
System.out.println("To be precise " + format.format(calendar.getTime()));

SimpleDateFormat format2 = new SimpleDateFormat("HHMM");
System.out.println("To be precise " + format2.format(now2(openingh,openingm,openings).ge tTime()));

if (choiceName.equals("Callback")){

if ( calendar.before(now2(openingh,openingm,openings)) && calendar.after(now2(closingh,closingm,closings )))
{
choice.setEnabled(false);
System.out.println("Callback DISABLED");

}
else{
choice.setEnabled(true);}


}

[panos100m]

I've corrected the code..

but still the output is not completely correct

IT
To be precise 2008-07-20 12:23:55 (correct)
To be precise 2008-07-20 09:00:00 (correct)

updated code:


public static Calendar now2(int hour,int minute,int sec) {
GregorianCalendar calendar2 = new GregorianCalendar();
// calendar2.clear();
calendar2.set(Calendar.HOUR_OF_DAY,hour );
calendar2.set(Calendar.MINUTE,minute);
calendar2.set(Calendar.SECOND,sec);
return calendar2;
}
GregorianCalendar calendar = new GregorianCalendar();

String langg="IT";





System.out.println (langg);
int openingh=-1;
int openingm=-1;
int openings=0;
int closingh=-1;
int closingm=-1;
int closings=0;


if (langg.equalsIgnoreCase("IT"))
{
openingh=9;
openingm=0;
closingm=10;
closings=0;

}

if (langg.equalsIgnoreCase("DA"))
{
openingh=8;
openingm=0;
closingm=15;
closings=0;

}

if (langg.equalsIgnoreCase("ES"))
{

openingh=7;
openingm=0;
closingm=16;
closings=0;

}

SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
System.out.println("To be precise " + format.format(calendar.getTime()));

SimpleDateFormat format2 = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss");
System.out.println("To be precise " + format2.format(now2(openingh,openingm,openings).ge tTime()));

if (choiceName.equals("Callback")){

if ( calendar.before(now2(openingh,openingm,openings)) && calendar.after(now2(closingh,closingm,closings )))
{
choice.setEnabled(false);
System.out.println("Callback DISABLED");

}
else{
choice.setEnabled(true);
System.out.println("Callback ENABLED, OPTION");
}
}

[JosAH]

I if ( calendar.before(now2(openingh,openingm,openings)) && calendar.after(now2(closingh,closingm,closings )))

If I read your code correctly (your should've put it between those [ code ] ... [ /code ] tags),
that condition can never be true, the time can never be before opening hours
*and* after closing hours.

kind regards,

Jos

[panos100m]

If I read your code correctly (your should've put it between those [ code ] ... [ /code ] tags),
that condition can never be true, the time can never be before opening hours
*and* after closing hours.

kind regards,

Jos

That's correct so it should be an || there instead of &&

int closingm=-1; should be closingh and the clear can be removed from now2

Thanks :-)