Need help in my code

[crystal2005]

Hi there, I need some help to correct my code. I would like to create a menu bar with the implementation of OO. So, i think i can edit and change it easyly if i use some classes.

[HTML]package gui_layout_BM;

import javax.swing.JFrame;

public class layoutDriver {

public static void main(String[] args) {
JFrame frame = new JFrame("Bovinetine Maker Simulator");
frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOS E);
frame.setJMenuBar(new MenuBarPanel().MainMenuBar()); //This line doesn't seem to call the function
frame.setVisible(true);
frame.setSize(480,320);

}

}[/HTML]

And another function
[HTML]
package gui_layout_BM;

import javax.swing.JMenu;
import javax.swing.JMenuBar;
import javax.swing.JMenuItem;
import javax.swing.JSeparator;

class MenuBarPanel extends JMenuBar{

public JMenuBar MainMenuBar() {
JMenuBar menu = new JMenuBar();

menu.add(CreateFileMenu());
menu.add(new JSeparator());
menu.add(CreateActionMenu());

return menu;
}

public JMenu CreateFileMenu() {
JMenu filemenu = new JMenu("File");

JMenuItem fileItem1 = new JMenuItem("Reset");
JMenuItem fileItem2 = new JMenuItem("Exit");

filemenu.add(fileItem1);
filemenu.add(fileItem2);

return filemenu;

}

public JMenu CreateActionMenu() {
JMenu actionmenu = new JMenu("Action");
//menu.setMnemonic("A");

JMenuItem actionItem1 = new JMenuItem("Add Pot");
JMenuItem actionItem2 = new JMenuItem("Add Ground");
JMenuItem actionItem3 = new JMenuItem("Add Water");
actionItem3.add(new JSeparator());
JMenuItem actionItem4 = new JMenuItem("Remove Pot");
JMenuItem actionItem5 = new JMenuItem("Remove Ground");
JMenuItem actionItem6 = new JMenuItem("Remove Water");
actionItem6.add(new JSeparator());
JMenuItem actionItem7 = new JMenuItem("Brew");

actionmenu.add(actionItem1);
actionmenu.add(actionItem2);
actionmenu.add(actionItem3);
actionmenu.add(actionItem4);
actionmenu.add(actionItem5);
actionmenu.add(actionItem6);
actionmenu.add(actionItem7);

return actionmenu;

}

}
[/HTML]

I hope there is no fatal error in my code.

Thank you for any kind of help.

[JosAH]

Look at your menu bar class:

class MenuBarPanel extends JMenuBar{ 
 
    public JMenuBar MainMenuBar() {
        JMenuBar menu = new JMenuBar();
 
        menu.add(CreateFileMenu());
        menu.add(new JSeparator());
        menu.add(CreateActionMenu());
 
        return menu;
    }
    ...
 

Your class *is a* JMenuBar because you extend from it but it also *has a*
JMenuBar because it makes one in the MainMenuBar method. You probably
want to populate a MenuBarPanel from its constructor. btw, is that a correct
name for your menu bar, i.e. is it really a panel? Also: only names of classes,
interfaces and enums start with a capital letter by convention. All the others
start with a lowercase letter and most of the time the name of a method has
a verb in it. It really improves readability.

kind regards,

Jos

[crystal2005]

Look at your menu bar class:

class MenuBarPanel extends JMenuBar{ 
 
    public JMenuBar MainMenuBar() {
        JMenuBar menu = new JMenuBar();
 
        menu.add(CreateFileMenu());
        menu.add(new JSeparator());
        menu.add(CreateActionMenu());
 
        return menu;
    }
    ...
 

Your class *is a* JMenuBar because you extend from it but it also *has a*
JMenuBar because it makes one in the MainMenuBar method. You probably
want to populate a MenuBarPanel from its constructor. btw, is that a correct
name for your menu bar, i.e. is it really a panel? Also: only names of classes,
interfaces and enums start with a capital letter by convention. All the others
start with a lowercase letter and most of the time the name of a method has
a verb in it. It really improves readability.

kind regards,

Jos

You're right, I want to populate it to make it easier to be called from main class. MenuBarPanel is just a name of class. Thanks to remind me about the naming, i almost forget about it.

I'll figure out again, if i get something, i'll keep posting in this thread. Thanks

[crystal2005]

Hi,

I have changed my code almost completely recently, And now I have problem in Layout Interface. It looks like a nice interface, but it doesn't. When i resize the frame, some buttons aren't fixed. Could someone tell me what is the most appropriate layout for my interface??

This layout has no action listener yet.

Thank you.

import java.awt.*;
import java.awt.event.*;
import javax.swing.*;
import javax.swing.border.*;
 
public class MenuLook {
 
    public JMenuBar createMenuBar() {
        JMenuBar menuBar = new JMenuBar(); //Create the menu bar.
 
        menuBar.add(createFileMenu());
        menuBar.add(createActionMenu());
        menuBar.add(createHelpMenu());
 
        return menuBar;
    }
 
    public JMenu createFileMenu() {
        JMenu file = new JMenu("File");
        file.setMnemonic(KeyEvent.VK_F);
 
        //Group of 'File' JMenuItems
        JMenuItem fileItem1 = new JMenuItem("Reset", KeyEvent.VK_R);
        JMenuItem fileItem2 = new JMenuItem("Exit", KeyEvent.VK_R);
 
        file.add(fileItem1);
        file.addSeparator();
        file.add(fileItem2);
 
        return file;        
    }
 
    public JMenu createActionMenu() {
        JMenu action = new JMenu("Action");
        action.setMnemonic(KeyEvent.VK_A);
 
        //Group of 'Action' JMenuItems
        JMenuItem actionItem1 = new JMenuItem("Add Pot");
        JMenuItem actionItem2 = new JMenuItem("Add Ground");
        JMenuItem actionItem3 = new JMenuItem("Add Water");
        JMenuItem actionItem4 = new JMenuItem("Remove Pot");
        JMenuItem actionItem5 = new JMenuItem("Remove Ground");
        JMenuItem actionItem6 = new JMenuItem("Remove Water");
        JMenuItem actionItem7 = new JMenuItem("Brew");
 
        action.add(actionItem1);
        action.add(actionItem2);
        action.add(actionItem3);
        action.addSeparator();
        action.add(actionItem4);
        action.add(actionItem5);
        action.add(actionItem6);
        action.addSeparator();
        action.add(actionItem7);
 
        return action;        
    }
 
    public JMenu createHelpMenu() {
        JMenu help = new JMenu("Help");
        help.setMnemonic(KeyEvent.VK_H);
 
        //Group of 'help' JMenuItems
        JMenuItem helpItem1 = new JMenuItem("About BM Simulator");
 
        help.add(helpItem1);
 
        return help;        
    }
 
    public Container createContentPane() {
        //Create the content-pane-to-be.
        JPanel contentPane = new JPanel(new BorderLayout());
        //contentPane.setOpaque(true);
 
        //Create a scrolled text area.
        JTextArea output = new JTextArea(5, 30);
        output.setEditable(true);
        JScrollPane scrollPane = new JScrollPane(output);
 
        //Add the text area to the content pane.
        contentPane.add(scrollPane, BorderLayout.CENTER);     
 
        contentPane.add(createWestPanel(), BorderLayout.WEST);        
        contentPane.add(createSouthPanel(), BorderLayout.SOUTH);
 
        return contentPane;
    }
 
    public JPanel createWestPanel() {
        JPanel westPanel = new JPanel(new BorderLayout()); //Probably not appropriate Layout
 
        //Panels inside 'westPanel'
        JPanel addActionPanel = new JPanel(new GridLayout(3,1,10,10));
        JPanel removeActionPanel = new JPanel(new GridLayout(3,1,10,10));
        JPanel brewActionPanel = new JPanel(new GridLayout(1,1,10,10));
 
        TitledBorder addActionBorder = new TitledBorder("Add Action");
        TitledBorder removeActionBorder = new TitledBorder("Remove Action");
        TitledBorder brewActionBorder = new TitledBorder("Brew Action");
 
        JButton b1 = new JButton("Add Pot");
        JButton b2 = new JButton("Add Ground");
        JButton b3 = new JButton("Add Water");
        JButton b4 = new JButton("Remove Pot");
        JButton b5 = new JButton("Remove Ground");
        JButton b6 = new JButton("Remove Water");
        JButton b7 = new JButton("Brew");
 
        addActionPanel.add(b1);
        addActionPanel.add(b2);
        addActionPanel.add(b3);
        addActionPanel.setBorder(addActionBorder);
        removeActionPanel.add(b4);
        removeActionPanel.add(b5);
        removeActionPanel.add(b6);
        removeActionPanel.setBorder(removeActionBorder);
        brewActionPanel.add(b7);
        brewActionPanel.setBorder(brewActionBorder);
 
        //Assign Panels to 'westPanel' 
        westPanel.add(addActionPanel, BorderLayout.PAGE_START);
        westPanel.add(removeActionPanel, BorderLayout.CENTER); //Problem With this line
        westPanel.add(brewActionPanel, BorderLayout.PAGE_END);
 
        return westPanel;
    }
 
    public JPanel createSouthPanel() {
        JPanel southPanel = new JPanel();
 
        JLabel statusBar = new JLabel("This test");
        statusBar.setText("Testing");
 
        southPanel.add(statusBar);
 
        return southPanel;
 
    }
 
    private static void createAndShowGUI() {
        //Create and set up the window.
        JFrame frame = new JFrame("Bovinetine Maker Simulator");
        frame.setDefaultCloseOperation(JFrame.EXIT_ON_CLOSE);
 
        //Create and set up the content pane.
        MenuLook demo = new MenuLook();
        frame.setJMenuBar(demo.createMenuBar());
        frame.setContentPane(demo.createContentPane());
 
        //Display the window.
        frame.setSize(640,380);
        frame.setVisible(true);
    }
 
    public static void main(String[] args) {
        createAndShowGUI();
    }
 
}
 
 

[JosAH]

Hi,

I have changed my code almost completely recently, And now I have problem in Layout Interface. It looks like a nice interface, but it doesn't. When i resize the frame, some buttons aren't fixed. Could someone tell me what is the most appropriate layout for my interface??

Can you tell in plain English what you want it to look and what it doesn't do now?
I browsed a bit through all that code and it looks sensible overall.

kind regards,

Jos

[crystal2005]

This is what basically my interface looks like

But when i try to resize it, the center panel of my west-panel seems to resize itself and become like this

What i expect is, when i resize the window i want all the button to be fixed. So that it would be a nicer look.

Thanks for any advice.

[JosAH]

For that left/west button panel you can use a SpringLayout; the API documentation
of that class points to a nice tutorial with examples.

kind regards,

Jos