Quick Java Question

[faized]

Hello all, one of the conditions for my assessment is that I shouldnt't be re-using code that is similar/same as previously used in my program. I've got "re-used" code everywhere, but not sure how to make it so that its not the same line of code with one word changed. An example below :

    void getInput()
    {
        System.out.print("Enter Australia player name: ");
        australiaPlayerName = input.next();
        System.out.print("Enter Africa player name: ");
        africaPlayerName = input.next();
    }
 

How would I shorten that method so that I'm not repeating code?

[JosAH]

Hello all, one of the conditions for my assessment is that I shouldnt't be re-using code that is similar/same as previously used in my program. I've got "re-used" code everywhere, but not sure how to make it so that its not the same line of code with one word changed. An example below :

    void getInput()
    {
        System.out.print("Enter Australia player name: ");
        australiaPlayerName = input.next();
        System.out.print("Enter Africa player name: ");
        africaPlayerName = input.next();
    }
 

How would I shorten that method so that I'm not repeating code?

Personally I would split that method in two:

String prompt(String prompt, Scanner input) {
   System.out.print(prompt+": ");
   return input.next();
} 
 

now you can do this:

Scanner input= ...;
String australianPlayerName= prompt("Enter Australia player name", input);
String africaPlayerName= prompt("Enter Africa player name", input);
String vegetable= prompt("Type a vegetable you like", input);
// etc. etc.
 

So you can properly reuse the method without any dependency on players or
whatever.

kind regards,

Jos