gcd common divisor

[judge82]

I'm new to Java and I was looking for some help on this particular problem.

I need to create a method that can simplify a fraction, that is, represent it as a fraction where the numerator and the denominator have no common divisors. it should read in the numerator and the denominator and then print out the fraction in its simplified form.

I tried to calculate it with:
while n!=0
{
r = m mod n;
m = n;
n = r;
}
return m

I tried to implement this, but i'm having problem with it in java

class Fraction{

private int numerator;

private int denominator;

public Fraction(int num, int denom){

setNumerator(num);

setDenominator(denom);

}

public int getDenominator(){

return denominator;

}

public int getNumerator(){

return numerator;

}

public void setDenominator(int denom){

if(denom == 0){

System.err.println("Fatal Error");

System.exit(1); //terminate program

}

denominator = denom;

}



public void setNumerator(int num){

numerator = num;

}

public String toString(){

return getNumerator() + "/" + getDenominator();

}

}


Thank you in advance for any help.

[blazedaces]

Firstly, could you please try to put your code in code tags from now on (look at the box on the right when you're posting that says "REPLY GUIDELINES", thank you. It makes the code much easier to read.

Next, what exactly is the problem? What error is showing up when the compiler tries to run this program?

-blazed

[judge82]

I wonder what is the best method, but I'm missing something about naming because all my compiling errors are telling me that I have incompatible types

[r035198x]

I wonder what is the best method, but I'm missing something about naming because all my compiling errors are telling me that I have incompatible types

mod is for % ?

[blazedaces]

I wonder what is the best method, but I'm missing something about naming because all my compiling errors are telling me that I have incompatible types

Repost your code with code tags and then show us all your compile errors so we know what lines they are supposedly on. Also pay attention to what was said in the post above...

-blazed

[JosAH]

I'm new to Java and I was looking for some help on this particular problem.

I need to create a method that can simplify a fraction, that is, represent it as a fraction where the numerator and the denominator have no common divisors. it should read in the numerator and the denominator and then print out the fraction in its simplified form.

I tried to calculate it with:
while n!=0
{
r = m mod n;
m = n;
n = r;
}
return m

I tried to implement this [ ... ]

Watch me do it:

int gcd(int n, int m) {
   int r;
   // your algorithm here with a few parentheses sprinkled in;
   // the compiler tells your where they are needed.
}
 

kind regards,

Jos

[judge82]

like i said guys, I am new with java.. I am trying to help a cousin he knows a write C++

greatest common divisor of two positive integers is the largest integer that is a divisor of both of them. For example, 6 and 15 have 3 as their greatest common divisor, and 15 and 22 have 1 as their greatest common divisor. The following recursive function computes the greatest common divisor of two positive integers. First write a program to test the function; then write and test an equivalent iterative function.

int gcd(int a, int b)
{
int r;

if ((r = a % b) = = 0)
return b;
else
return gcd(b, r);
}

[JosAH]

Why are you changing a perfectly valid iterative solution of a gcd(n, m) to a
recursive version now? Please make up your mind and tell us what your problem
is and stop throwing code fragments at us; we know what programming is all
about.

kind regards,

Jos

[judge82]

Why are you changing a perfectly valid iterative solution of a gcd(n, m) to a
recursive version now? Please make up your mind and tell us what your problem
is and stop throwing code fragments at us; we know what programming is all
about.

kind regards,

Jos

since dividing the numerator and denominator by their gcd will simplify the fraction.
here is a sample run (user input)
enter a numerator:
6
enter a denominator:
8

your fraction is 6/8
the simplified form is 3/4

[JosAH]

since dividing the numerator and denominator by their gcd will simplify the fraction.

Yep, we know that. What's your question?

kind regards,

Jos

[judge82]

^ I can't seem to come up with the code to do the fraction.

[r035198x]

^ I can't seem to come up with the code to do the fraction.

You do realize of course that coming up with the gcd and simplifying the fraction are kind of related?

[blazedaces]

You have already provided two possible answers to your own question... even in code. Sorry, but what in the world is the problem?

-blazed

[JosAH]

^ I can't seem to come up with the code to do the fraction.

But you already have all the ingredients right before your eyes:

private int gcd(int n, int m) { /* implementation here */ }
int nonSimplifiedNumerator;
int nonSimplifiedDenominator;
 

It doesn't take rocket science to do this:

int r= gcd(nonSimplifiedNumerator, nonSimplifiedDenominator);
int simplifiedNumerator= nonSimplifiedNumerator/r;
int simplifiedDenominator= nonSimplifiedDenominator/r;
 

Now this is what I call a spoiler.

kind regards,

Jos

[blazedaces]

Now this is what I call a spoiler.

kind regards,

Jos

Now you ruined it for me! :P

-blazed

[JosAH]

Now you ruined it for me! :P

-blazed

Yep, that's me: I've always been a partypooper. ;-)

kind regards,

Jos