recursion blue

[Manavendra Gupta]

Hi

I have a following recursive method:

private File findMatchOnDestination(File[] fileList, String name) {
for (int i = 0; i < fileList.length; i++) {
if (fileList[i].isDirectory()) {
System.out.println("file: " + fileList[i]);
File[] matches = fileList[i].listFiles(new MatchingNameFilter(name));

if (matches != null && matches.length > 0) {
searchResult = matches[0];
return matches[0];
}
if (searchResult == null) {
findMatchOnDestination(fileList[i].listFiles(), name);
} else {
return searchResult;
}
}
}

return null;
}

and this is how it is inovked:
File[] destFiles = destinationLocation.listFiles(new
SourceFoldersFilter(getFilterFolders()));

for (int i = 0; i < sourceFiles.length; i++) {
File destFile =
findMatchOnDestination(destFiles,sourceFiles[i].getName());
// do something
}

So essentially, I pass a filtered list of files in the destinationLocation,
upon which the findMatchOnDestination() works.

However, as you'd agree the code in findMatchOnDestination() is ugly -
especially the use of "searchResult" static member. Can anyone help me tidy
the code?

Thanks
Manav

[hiwa]

"Manavendra Gupta" <ma*********@cramer.com> wrote in message news:<40***********************@reading.news.pipex .net>...

Hi

I have a following recursive method:

private File findMatchOnDestination(File[] fileList, String name) {
for (int i = 0; i < fileList.length; i++) {
if (fileList[i].isDirectory()) {
System.out.println("file: " + fileList[i]);
File[] matches = fileList[i].listFiles(new MatchingNameFilter(name));

if (matches != null && matches.length > 0) {
searchResult = matches[0];
return matches[0];
}
if (searchResult == null) {
findMatchOnDestination(fileList[i].listFiles(), name);
} else {
return searchResult;
}
}
}

return null;
}

and this is how it is inovked:
File[] destFiles = destinationLocation.listFiles(new
SourceFoldersFilter(getFilterFolders()));

for (int i = 0; i < sourceFiles.length; i++) {
File destFile =
findMatchOnDestination(destFiles,sourceFiles[i].getName());
// do something
}

So essentially, I pass a filtered list of files in the destinationLocation,
upon which the findMatchOnDestination() works.

However, as you'd agree the code in findMatchOnDestination() is ugly -
especially the use of "searchResult" static member. Can anyone help me tidy
the code?

Thanks
Manav

Think simple and do simple:

/** call:
* findMatchOnDestination(destinationLocation, sourceFiles[i].getName())
*/
private void findMatchOnDestination(File f, String s){
try{
if (f.isDirectory()){ //recurse if directory
File[] flist = f.listFiles();
for (int i = 0; i < flist.length; ++i){
findMatchOnDestination(flist[i]);
}
}
else{ //file
if (matchesNameCriteria(f, s)){ //filter filename here
doSomethingOn(f);
}
}
}
catch(Exception e){
e.printStackTrace();
}
}
 

[Manavendra Gupta]

aah, didnt think of that - was keen to return a value from the recursive
method. Thanks!
"hiwa" <HG******@nifty.ne.jp> wrote in message
news:68**************************@posting.google.c om...

"Manavendra Gupta" <ma*********@cramer.com> wrote in message

news:<40***********************@reading.news.pipex .net>...

Hi

I have a following recursive method:

private File findMatchOnDestination(File[] fileList, String name) {
for (int i = 0; i < fileList.length; i++) {
if (fileList[i].isDirectory()) {
System.out.println("file: " + fileList[i]);
File[] matches = fileList[i].listFiles(new MatchingNameFilter(name));
if (matches != null && matches.length > 0) {
searchResult = matches[0];
return matches[0];
}
if (searchResult == null) {
findMatchOnDestination(fileList[i].listFiles(), name);
} else {
return searchResult;
}
}
}

return null;
}

and this is how it is inovked:
File[] destFiles = destinationLocation.listFiles(new
SourceFoldersFilter(getFilterFolders()));

for (int i = 0; i < sourceFiles.length; i++) {
File destFile =
findMatchOnDestination(destFiles,sourceFiles[i].getName());
// do something
}

So essentially, I pass a filtered list of files in the destinationLocation, upon which the findMatchOnDestination() works.

However, as you'd agree the code in findMatchOnDestination() is ugly -
especially the use of "searchResult" static member. Can anyone help me tidy the code?

Thanks
Manav

Think simple and do simple:

 /** call:
   * findMatchOnDestination(destinationLocation, sourceFiles[i].getName())
   */
 private void findMatchOnDestination(File f, String s){
   try{
     if (f.isDirectory()){ //recurse if directory
       File[] flist = f.listFiles();
         for (int i = 0; i < flist.length; ++i){
           findMatchOnDestination(flist[i]);
       }
     }
     else{ //file
       if (matchesNameCriteria(f, s)){ //filter filename here
         doSomethingOn(f);
       }
     }
   }
   catch(Exception e){
     e.printStackTrace();
   }
 }