473,903 Members | 3,390 Online
Bytes | Software Development & Data Engineering Community
+ Post

Home Posts Topics Members FAQ

SITE CRITIQUE: Please comment

JB
Hi All,

This is my first go at a pure CSS web site and I'd like your comments and
suggestions please.

The URL is http://www.waukeshapumps.com/

Comments on CSS, design and content very welcome.

Thanks in advance,

Jeff
Feb 1 '06 #1
26 2119
JB wrote:
This is my first go at a pure CSS web site and I'd like your comments
and suggestions please.

The URL is http://www.waukeshapumps.com/

Comments on CSS, design and content very welcome.


Looks pretty good to me. Nice clean layout. Coupla comments:

Change body font size to 100% instead of that microfont, then drop all
the other sizing except the <hx> elements, and perhaps use 85% for any
legalese.

Visit http://validator.w3.org/ and fix the errors.

--
-bts
-Warning: I brake for lawn deer
Feb 1 '06 #2
"JB" <me@here.com> wrote:
This is my first go at a pure CSS web site and I'd like your comments and
suggestions please.

The URL is http://www.waukeshapumps.com/
It's not a "pure CSS web site" It uses deprecated presentational code.
Ditch the transitional coding, switching to a Strict doctype might make
validation a more useful tool. While on the subject of validation, your
page doesn't:
http://validator.w3.org/check?uri=ht...eshapumps.com/

XHTML served as text/html is silly:
http://www.spartanicus.utvinternet.ie/no-xhtml.htm
HTML 4.01 Strict is the better choice.
Comments on CSS, design and content very welcome.
Looks like you used a template.
<h1>Choose the right alternative</h1>
You header usage is all wrong. The logo image of the index page should
be wrapped in the <h1> with "Waukesha Pumps UK Ltd." as the alt content.
No other <h1>s should be used in this page.
* {
padding:0;
margin:0;
}
This is unwise, it requires you to explicitly define padding and margins
for elements that need it, resulting in needlessly bloated CSS. It's
commonly seen amongst pixel precision fans, don't fight browser
defaults, accept that things will look somewhat different on different
browsers, this is an essential concept when designing for the web.
#leftColumn {
width: 175px;
float: left;
}
Containers for text should be sized using the em unit, your menu text
overflows it's container here due to it's current pixel sizing. Use the
em unit and the container will adapt to different font sizes than the
one you are seeing.

Use a Gecko based browser to zoom the text to check if the design adapts
to varying text settings.

There is no need for this layout to be fixed width, it should adapt to
the available viewport width.
body {
font-size:62.5%;
}
p {
font-size: 1.2em;
}


Idiotic text sizing, leave the body font size alone, including
paragraphs.

--
Spartanicus
Feb 1 '06 #3
In message <43************ **********@ptn-nntp-reader02.plus.n et>, JB
<me@here.com> writes
Hi All,

This is my first go at a pure CSS web site and I'd like your comments and
suggestions please.

The URL is http://www.waukeshapumps.com/

Comments on CSS, design and content very welcome.

Thanks in advance,

Jeff

On the home page, Line 73 column 15: value of attribute "clear" cannot
be "both"; must be one of "left", "all", "right", "none".

Nice job!
--
Chris Hughes
"Reality is that which, when you cease to believe, continues to exist."
http://www.epicure.demon.co.uk
Feb 1 '06 #4
"JB" <me@here.com> wrote in
news:43******** **************@ ptn-nntp-reader02.plus.n et:
Hi All,

This is my first go at a pure CSS web site and I'd like your
comments and suggestions please.

The URL is http://www.waukeshapumps.com/

Comments on CSS, design and content very welcome.


Transitional HTML, yech. What are you transitioning from? Use strict
for newly coded pages.

I use XHTML (not served properly) on one site because it is mandated
from up above. My other sites are done with HTML 4.01 strict. Why are
you using XHTML (not served properly)?

In your CSS, you set foreground colors without setting background color
and vice versa. When you set one, you should set the other. Best done
once for the body only.

Pixel sizing, yech. If I maximize my browser window, there sure is a
lot of white space. Use px only for images, containers for images, and
sometimes for other objects to place them with images. Use em or % for
most other things.

The "look" is good, and as far as I can tell, so is the content.

--
Stan McCann "Uncle Pirate" http://stanmccann.us/pirate.html
Webmaster/Computer Center Manager, NMSU at Alamogordo
http://alamo.nmsu.edu/ There are 10 kinds of people.
Those that understand binary and those that don't.
Feb 1 '06 #5
JB wrote:

This is my first go at a pure CSS web site and I'd like your comments and
suggestions please.
The URL is http://www.waukeshapumps.com/

What others have said, and ...

Overall the visual design is clean, the information well presented.

There is no observable reason for the fixed width design, especially
the center column.
I notice there are no links to pump data, specs, etc. Is this intentional?
IIRC, the trademark symbol is needed only on the first instance of a
trademarked phrase, and not at all necessary in the owner's literature.
The trademark is a distraction and, worse, insulting to have the legalese
constantly forced to my attention.
--
jmm (hyphen) list (at) sohnen-moe (dot) com
(Remove .AXSPAMGN for email)
Feb 1 '06 #6
JB
> Change body font size to 100% instead of that microfont, then drop all
the other sizing except the <hx> elements, and perhaps use 85% for any
legalese.


Thanks for the reply. I'm playing around with the font size at the moment
but don't you think a large font makes a site look amateurish?

Are percentages preferable to ems?

Jeff
Feb 2 '06 #7
JB
> It's not a "pure CSS web site" It uses deprecated presentational code.

What I mean is it's my first site without using tables for layout. I'll look
into doctypes and validation next.
Comments on CSS, design and content very welcome.
Looks like you used a template.


All code was created by me. I am using the template function in Dreamweaver
however.
You header usage is all wrong. The logo image of the index page should
be wrapped in the <h1> with "Waukesha Pumps UK Ltd." as the alt content.
No other <h1>s should be used in this page.
I thought an IMG within a H was bad practice. I intend on using a single
<h1> at the top and smaller <h2>, <h3>s moving sown the page.

don't fight browser defaults


I much prefer to level the playing field from the start. This makes
everything equal from the start.

Containers for text should be sized using the em unit, your menu text
overflows it's container here due to it's current pixel sizing. Use the
em unit and the container will adapt to different font sizes than the
one you are seeing.
I'm trying to keep the whole site at 770px wide. Nothing worse than long
lines of text on a website.
There is no need for this layout to be fixed width, it should adapt to
the available viewport width.
See above.
Idiotic text sizing, leave the body font size alone, including
paragraphs.


I took this advice from a CSS tutorial site. I find it gives good control
but I will try your suggestions.

Thanks,

Jeff
Feb 2 '06 #8
JB
> On the home page, Line 73 column 15: value of attribute "clear" cannot be
"both"; must be one of "left", "all", "right", "none".


Thanks. I'll change to all...in fact, I'll take a closer look and see if I
actually need that line.

Jeff
Feb 2 '06 #9
JB
> Transitional HTML, yech. What are you transitioning from? Use strict
for newly coded pages.

I'll read up a bit more on doctypes and xhtml.
I use XHTML (not served properly) on one site because it is mandated
from up above. My other sites are done with HTML 4.01 strict. Why are
you using XHTML (not served properly)?
I think it happened via Dreamweaver!

In your CSS, you set foreground colors without setting background color
and vice versa. When you set one, you should set the other. Best done
once for the body only.
Noted. Thanks.

Pixel sizing, yech. If I maximize my browser window, there sure is a
lot of white space. Use px only for images, containers for images, and
sometimes for other objects to place them with images. Use em or % for
most other things.
I need to keep the text lines to a certain width. I hate reading long lines
of text on screen. Many commercial sites used fixed width layouts.

The "look" is good, and as far as I can tell, so is the content.


Many thanks,

Jeff
Feb 2 '06 #10

This thread has been closed and replies have been disabled. Please start a new discussion.

Similar topics

17
1593
by: Joe | last post by:
I'm a long-time lurker, so I know what to expect! Can someone please look at this and make appropriate comments? http://members.aardvark.net.au/grakat/temp/ It's only four pages, and it should pretty much work If someone can help me out with the 'form' on the contact page (which I copied) I'd be grateful. PLEASE DON'T USE THE FORM TO SEND ANYTHING TO ME. At the moment, the addy it points to is disabled!!
0
9999
marktang
by: marktang | last post by:
ONU (Optical Network Unit) is one of the key components for providing high-speed Internet services. Its primary function is to act as an endpoint device located at the user's premises. However, people are often confused as to whether an ONU can Work As a Router. In this blog post, weíll explore What is ONU, What Is Router, ONU & Routerís main usage, and What is the difference between ONU and Router. Letís take a closer look ! Part I. Meaning of...
0
9847
by: Hystou | last post by:
Most computers default to English, but sometimes we require a different language, especially when relocating. Forgot to request a specific language before your computer shipped? No problem! You can effortlessly switch the default language on Windows 10 without reinstalling. I'll walk you through it. First, let's disable language synchronization. With a Microsoft account, language settings sync across devices. To prevent any complications,...
0
11283
Oralloy
by: Oralloy | last post by:
Hello folks, I am unable to find appropriate documentation on the type promotion of bit-fields when using the generalised comparison operator "<=>". The problem is that using the GNU compilers, it seems that the internal comparison operator "<=>" tries to promote arguments from unsigned to signed. This is as boiled down as I can make it. Here is my compilation command: g++-12 -std=c++20 -Wnarrowing bit_field.cpp Here is the code in...
1
10986
by: Hystou | last post by:
Overview: Windows 11 and 10 have less user interface control over operating system update behaviour than previous versions of Windows. In Windows 11 and 10, there is no way to turn off the Windows Update option using the Control Panel or Settings app; it automatically checks for updates and installs any it finds, whether you like it or not. For most users, this new feature is actually very convenient. If you want to control the update process,...
0
10501
tracyyun
by: tracyyun | last post by:
Dear forum friends, With the development of smart home technology, a variety of wireless communication protocols have appeared on the market, such as Zigbee, Z-Wave, Wi-Fi, Bluetooth, etc. Each protocol has its own unique characteristics and advantages, but as a user who is planning to build a smart home system, I am a bit confused by the choice of these technologies. I'm particularly interested in Zigbee because I've heard it does some...
0
7206
by: conductexam | last post by:
I have .net C# application in which I am extracting data from word file and save it in database particularly. To store word all data as it is I am converting the whole word file firstly in HTML and then checking html paragraph one by one. At the time of converting from word file to html my equations which are in the word document file was convert into image. Globals.ThisAddIn.Application.ActiveDocument.Select();...
1
4727
by: 6302768590 | last post by:
Hai team i want code for transfer the data from one system to another through IP address by using C# our system has to for every 5mins then we have to update the data what the data is updated we have to send another system
2
4308
muto222
by: muto222 | last post by:
How can i add a mobile payment intergratation into php mysql website.
3
3324
bsmnconsultancy
by: bsmnconsultancy | last post by:
In today's digital era, a well-designed website is crucial for businesses looking to succeed. Whether you're a small business owner or a large corporation in Toronto, having a strong online presence can significantly impact your brand's success. BSMN Consultancy, a leader in Website Development in Toronto offers valuable insights into creating effective websites that not only look great but also perform exceptionally well. In this comprehensive...

By using Bytes.com and it's services, you agree to our Privacy Policy and Terms of Use.

To disable or enable advertisements and analytics tracking please visit the manage ads & tracking page.