How to delete and download attachments?

[bonneylake]

Hey Everyone,

Well for the last few days i been trying to figure out how to delete attachments and download attachments to my computer. The deleting is sort of working and i don't know where to begin on downloading. Right now with the deleting it will delete from the attachments folder on the server but it does not delete from the database an was wondering if someone could explain what i am doing wrong on deleting attachments and how i could make it where a user could download an attachment to there computer? Here is what i have.

<cfparam name="form.confirmed" default="0">
 
<cfquery name="attachment" datasource="CustomerSupport">
         SELECT fk_ticketID,description,path
         FROM dbo.tbl_CS_attachments
         WHERE fk_ticketID = #URL.pk_ticketID#
</cfquery>
 
 
<form method="post">
<cfoutput query="ticket">
<input type="hidden" name="pk_ticketID" id="pk_ticketID" value="#pk_ticketID#" />
</cfoutput>
<cfoutput query="attachment">
<input type="hidden" name="fk_ticketID" id="fk_ticketID" value="#fk_ticketID#" />
</cfoutput>
 
<cfoutput query="attachment">
#description#
<a href="attachments/#path#" target="_blank" >view</a>
<br>
<cfif form.confirmed EQ 1>
<cflock timeout="60">
<cffile action="delete" 
file="C:\Inetpub\Development\WWWRoot\RachelB\footprints\form\attachments\#path#">
</cflock>
</cfif>
<input type="hidden" name="confirmed" value="1">
<input type="hidden" name="fk_ticketID" value="#fk_ticketID#">
<input type="submit" value="delete" onClick="return confirm('Are you sure you want to delete?')">
</cfoutput>
</form>

Thank you,
Rach

[bonneylake]

The cfparam is just there in case a path is not specified. You can set it to the empty string, then when outputting, if it's empty, you can just display a message instead of trying to download the file.

In download.cfm, have you changed the type attribute for the cfcontent tag? Note that you can force a download by setting the type to "application/unknown". That might be simplest solution in this case.

Hey Acoder,

Tried to set the type to what you said an well i am still getting the same error. Here is what it says.

No such file.

The file specified in CFContent does not exist: C:\Inetpub\Development\WWWRoot\RachelB\footprints\ form\attachments\encodeURIComponent(capt.108c1e44b 23c48a59fd6d459b143331f_386_3.jpg)

The error occurred while processing an element with a general identifier of (CFCONTENT), occupying document position (2:1) to (5:1) in the template file C:\Inetpub\Development\WWWRoot\RachelB\footprints\ form\download.cfm.


an this is what i have on the download page.

<cfheader name="Content-Disposition" value="attachment; filename=#path#">
<cfcontent 
file = "C:\Inetpub\Development\WWWRoot\RachelB\footprints\form\attachments\#path#" 
type="application/unknown"
>

Thank you,
Rach

[acoder]

Obviously, it's not going to work (gah!). It should be:

<input type="button" name="download" value="Download" onClick="window.location.href='download.cfm?path='+encodeURIComponent(#path#);">

Note that the previous code was putting encodeURIComponent within the URL resulting in the "No such file" error.

[bonneylake]

Obviously, it's not going to work (gah!). It should be:

<input type="button" name="download" value="Download" onClick="window.location.href='download.cfm?path='+encodeURIComponent(#path#);">

Note that the previous code was putting encodeURIComponent within the URL resulting in the "No such file" error.

Hey Acoder,

i am getting a weird error. It says

Error: missing ) after argument list
Source Code:
window.location.href='download.cfm?path='+encodeUR IComponent(capt.2e780c0734e006b13d9c3f793cd88715_3 86_2.jpg);

it says its missing after capt. an here is what i have for the button

<input type="button" name="download" value="Download" 
onClick="window.location.href='download.cfm?path='+encodeURIComponent(#path#);">

Thank you,
Rach

[acoder]

Remove the spaces between UR and IC

[bonneylake]

Remove the spaces between UR and IC

Hey Acoder,

I don't know why but only when i put the code on here it shows the space between UR and IC even when i make sure it don't have a space between it before i submit.
but in my code its all together.

<input type="button" name="download" value="Download" 
onClick="window.location.href='download.cfm?path='+encodeURIComponent(#path#);
">

Thank you,
Rach

[acoder]

I see what's happening now. #path# is being converted to a string without quotes which JavaScript doesn't recognise. Either set #path# to a JavaScript variable, or just put it in quotes:

encodeURIComponent('#path#')

[bonneylake]

I see what's happening now. #path# is being converted to a string without quotes which JavaScript doesn't recognise. Either set #path# to a JavaScript variable, or just put it in quotes:

encodeURIComponent('#path#')

Hey Acoder,

That was it, it just needed the quotes. THANK YOU, THANK YOU!!! Thank you so much for all your help, it is awesome to see it downloading and deleting files :).
Thank you again :),
Rach

[acoder]

Oh, you're welcome! Glad it's working.