Hey Everyone,
Well i am not sure if this is more of a coldfusion problem or a javscript problem. So if i asked my question in the wrong section let me know an all move it to the correct place.
what i am trying to display previously entered multiple fields. I am able to get my serial fields to display correctly, but i can not display my parts fields correctly.
Currently this is what it does
serial information 1
parts 1
parts 2
serial information 2
parts 1
parts 2
and what it needs to do
serial information 1
parts 1
serial information 2
parts 1
the problem is instead of the part going with the correct serial. it basically puts the information for both parts i added under both of the 2 serials I am also having trouble deleting fields an adding fields for the parts fields.
if someone could explain what i am doing wrong with the parts i would really appreciate it. I know it has to do with the count, just not sure what i am doing wrong
here is the javascript for serial and parts that allows me to add serials and parts
here is the html/coldfusion that displays what was previously entered for serials and parts.
Thank you in advance,
Rach
Oct 16 '08
482  27220 
I don't know where default came from. That should be index.
I don't know where default came from. That should be index.
Hey Acoder,
My bad got the index and default confused. But ok here is what i have, is everything else correct? -
<cfloop list="1" to="#form['part2count' & machinecount]#" index="ps">
-
<cfparam name="Form.defective_#ps#_#machinecount#" default="0">
-
<cfparam name="Form.partsreturn_#ps#_#machinecount#" default="0">
-
<CFSET hcpn = Form["hcpn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET partsreturn = Form["partsreturn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET defective = Form["defective_" & "#ps#" & "_#machinecount#"]>
-
<CFSET rma = Form["rma_" & "#ps#" & "_#machineCount#"]>
-
<cfquery name="parts" datasource="CustomerSupport">
-
exec usp_CS_Insertparts
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#hcpn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#partsreturn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#defective#" CFSQLType = "CF_SQL_BIT">,
-
<cfqueryparam value="#rma#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
</cfloop>
Thank you,
Rach
Seems so - you can only test and find out.
Seems so - you can only test and find out.
Hey Acoder,
I tested it twice an got the error.
Error Diagnostic Information
An error occurred while evaluating the expression:
hcpn = Form["hcpn_" & ps & "_#machinecount#"]
Error near line 95, column 8.
--------------------------------------------------------------------------------
The member "HCPN_1_1" in dimension 1 of object "Form" cannot be found. Please, modify the member name.
i was wondering could it be becuase of this line, becuase i have the value as nothing instead of 0 like the rest?
"<input type='hidden' name='"+part2c+"' id='"+part2c+"' value=''>" +
here is what i have - <cfloop list="#form['part2count' & machinecount]#" index="ps">
-
<cfparam name="Form.defective_#ps#_#machinecount#" default="0">
-
<cfparam name="Form.partsreturn_#ps#_#machinecount#" default="0">
-
<CFSET hcpn = Form["hcpn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET partsreturn = Form["partsreturn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET defective = Form["defective_" & "#ps#" & "_#machinecount#"]>
-
<CFSET rma = Form["rma_" & "#ps#" & "_#machineCount#"]>
-
<cfquery name="parts" datasource="CustomerSupport">
-
exec usp_CS_Insertparts
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#hcpn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#partsreturn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#defective#" CFSQLType = "CF_SQL_BIT">,
-
<cfqueryparam value="#rma#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
</cfloop>
Thank you,
Rach
This would be when there's no parts obviously. Check what the value of part2count1 is. It should be empty when there are no parts.
This would be when there's no parts obviously. Check what the value of part2count1 is. It should be empty when there are no parts.
Hey Acoder,
well my thinking cap was not on an it is working how its suppose to. However, i ran into another problem with it :(. The user has to be able to add parts to some serials an not add parts to other serials, is this possible?
Thank you,
Rach
You mean allow for no parts to be added to any serial or even all serials? Yes, that should be possible.
You mean allow for no parts to be added to any serial or even all serials? Yes, that should be possible.
Hey Acoder,
thats not quite what i mean. Right now i tested one serial with a part an another serial without a part. An i got an error with that (same one i been having). However, if every serial has a part and or every serial does not have a part it works right.So basically wondering if we can make it where it will still submit if one serial has a part an another serial does not have a part?
Thank you,
Rach
Yes, that should be possible. It should be working with the current code, but something's probably missing. When you have one serial with one part and one serial with no parts, check the values of part2count1 and part2count2.
Yes, that should be possible. It should be working with the current code, but something's probably missing. When you have one serial with one part and one serial with no parts, check the values of part2count1 and part2count2.
Hey Acoder,
Ok i need to stop working on so many things at the same time. I figured out the problem an IT IS working correctly! i ended up changing one thing i didn't need to change. But THANK YOU THANK YOU!!!! However, i am having another problem that i was hoping you could explain (an it has to do with displaying previously submitted information). I figured out how to do the insert update stored procedure. An updating is working beautifully, but the inserting only does when you do it a certain way. But here is the trouble i am having.
1) if i go back to view a serial or part. an let say i have 1 serial an i edited to change one field. Anyway when i go back to view it again (with the new changes) instead of it showing the one serial with the change it shows the one serial with the change an then adds another serial (but yet the another serial does not appear in the table i am inserting into.
2)an also if i add a serial/part it will not be inserted into the table. Unless i change the serial name of a previously inserted serial then it will insert. But if i use javascript to add another it will not insert.
but if you could explain those 2 that would be awesome. Which i am sorry i have made this thread so long. This is just a confusing one.
Thank you,
Rach
So you're saying this all works fine if you don't update, but once you update a serial or part field, you start to have these problems? Show the update code.
So you're saying this all works fine if you don't update, but once you update a serial or part field, you start to have these problems? Show the update code.
Hey Acoder,
Yes i have the problem when i update previously submitted fields. But i also have the problem where if i try to add new serials and parts it will not insert it into the table, it will update old ones. But it will not insert new ones unless i take a old submitted serial and clear it out an put the new information in it.
But here is what i have for the update
here is the javascript for both serial and parts -
<!---Allows us to add serial information multiple times --->
-
<script type="text/javascript">
-
<!---Allows us to add multiple fields --->
-
function addInput(divName){
-
var dynamic = document.getElementById('dynamicInput');
-
var thevalue = document.getElementById('theValue');
-
var count = (document.getElementById('theValue').value -1)+ 2;
-
thevalue.value = count;
-
var newdiv = document.createElement('div');
-
var getparts = document.createElement('div');
-
var divIdName = 'dynamic'+count+'Input';
-
var partc = 'partscount'+count;
-
var part2c = 'part2count'+count;
-
-
newdiv.setAttribute('id',divIdName);
-
-
<!--- Adds Extra fields for Model No, Product Type, and Type of Hardware Failure --->
-
newdiv.innerHTML =
-
"<table class='zpExpandedTable' id='modeltable'>" +
-
"<th class='sectiontitletick' colspan='7'>Serial Information "+ count +" </th>" +
-
"<tr>" +
-
"<td id='paddingformultitop'>Model No: </td>" +
-
"</td>" +
-
"<td>" +
-
"<select name='modelno_" + count + "' >" +
-
"<option value=''>Make A Selection</option>" +
-
"<cfoutput query='models'>" +
-
"<option value='#model#'>#model#</option>" +
-
"</cfoutput>" +
-
"</select>" +
-
"</td>" +
-
"<td>" +
-
" Product Type:" +
-
"</td>" +
-
"<td>" +
-
"<select name='producttype_" + count + "'>" +
-
"<option value='' selected>No Choice</option>" +
-
"<cfoutput query='getProdType'>" +
-
"<option value='#pk_productType#'>#pk_productType#</option>" +
-
"</cfoutput>" +
-
"</select>" +
-
"</td>" +
-
"<td class='red'>" +
-
" Type Of Hardware Failure*:" +
-
"</td>" +
-
"<td>" +
-
"<select id='hardwarefailure' name='hardwarefailure_" + count + "'>" +
-
"<option value='' selected>Make A Selection</option>" +
-
"<cfoutput query='getHardwareFail'>" +
-
"<option value='#pk_hardwareFailure#'>#pk_hardwareFailure#</option>" +
-
"</cfoutput>" +
-
"</select>" +
-
"</td>" +
-
"</tr>" +
-
"<table>";
-
-
<!--- Adds Extra fields for Serial Number and Software/Hardware --->
-
newdiv.innerHTML = newdiv.innerHTML +
-
"<table class='zpExpandedTable' id='modeltable'>" +
-
"<tr>" +
-
"<td id='paddingformultitop'>" +
-
"Serial Number: " +
-
"<input type='text' name='serialnum_" + count + "'>" +
-
" Software/Hardware: " +
-
"<select name='softhardware_" + count + "'>" +
-
"<option value='' selected>No Choice</option>" +
-
"<cfoutput query='getSoftHard'>" +
-
"<option value='#pk_softwareHardware#'>#pk_softwareHardware#</option>" +
-
"</cfoutput>" +
-
"</select>" +
-
"</td>" +
-
"</tr>" +
-
"</table>";
-
-
<!--- Adds Extra fields for Description --->
-
newdiv.innerHTML = newdiv.innerHTML +
-
"<table class='zpExpandedTable' id='resoltable' cellpadding='3' cellspacing='0'>" +
-
"<tr>" +
-
"<td id='paddingformutli'>" +
-
"Description: " +
-
"</td>" +
-
"<td class='descriptionmoveinmulti'>" +
-
"( You may enter up to 1000 characters. )"+
-
"<br>" +
-
"<textarea maxlength='1000' onkeyup='return descriptionmaxlength(this)' onkeydown='return descriptionmaxlength(this)'rows='4' cols='60' name='thedescription_" + count + "'></textarea>" +
-
"</td>" +
-
"</tr>" +
-
"</table>";
-
-
<!--- Adds Extra fields for Resolution --->
-
newdiv.innerHTML = newdiv.innerHTML +
-
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
-
"<tr>" +
-
"<td id='paddingformutli'>" +
-
"Resolution: " +
-
"</td>" +
-
"<td class='resolutionmoveinmulti'>" +
-
"( You may enter up to 1500 characters. )"+
-
"<br>" +
-
"<textarea maxlength='1500' onkeyup='return resolutionmaxlength(this)' onkeydown='return resolutionmaxlength(this)' rows='4' cols='60' name='resolution_" + count + "'></textarea>" +
-
"</td>" +
-
"</tr>" +
-
"</table>";
-
-
<!--- Adds Extra fields for Resolution Date, Current Date (for resolution date) and resolution vertified as effective by --->
-
newdiv.innerHTML = newdiv.innerHTML +
-
"<table class='zpExpandedTable' id='resoldatetab' cellpadding='1' cellspacing='0'>" +
-
"<tr>" +
-
"<td id='paddingformultitop'>" +
-
"Resolution Date: (MM/DD/YYYY) " +
-
"</td>" +
-
"<td>" +
-
"<input type='text' name='resdate_" + count + "' value='' > " +
-
-
" Current Date: " +
-
"<input type='checkbox' name='currentdateresol_" + count + "' onClick=resdate_" + count + ".value=fill_date()>" +
-
"</td>" +
-
"<td>" +
-
"Resolution Verified as effective by: " +
-
"</td>" +
-
"<td>" +
-
"<select name='resvertified_" + count + "'>" +
-
"<option value='' selected>Make A Selection</option>" +
-
"<cfoutput query='gettech'><option value='#fname# #lname#'>#fname# #lname#</option></cfoutput>" +
-
"</select>" +
-
"</td>" +
-
"</tr>" +
-
"</table>";
-
-
<!--- Adds Extra fields for Vertification Date, Current Date (for vertification date) and resolution vertified as effective by --->
-
newdiv.innerHTML = newdiv.innerHTML +
-
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
-
"<tr>" +
-
"<td id='paddingformultitop'>" +
-
"Verification Date: (MM/DD/YYYY) " +
-
"</td>" +
-
"<td class='vertificationmoveinmulti'>" +
-
"<input type='text' name='vertifidate_" + count + "'> " +
-
" Current Date: " +
-
"<input type='checkbox' name='currentdatevert_" + count + "' onClick=vertifidate_" + count + ".value=fill_date()>" +
-
"</td>" +
-
"</tr>" +
-
"</table>";
-
-
<!--- Adds Extra fields for Dept/Vendor Responsibility --->
-
newdiv.innerHTML = newdiv.innerHTML +
-
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
-
"<tr>" +
-
"<td class='red' id='paddingformultitop'>" +
-
"Dept/Vendor Responsibility*: " +
-
"<select name='deptvendor_" + count + "' id='deptvendor'>" +
-
"<option value='' selected>Make A Selection</option>" +
-
"<cfoutput query='getDeptVendor'>" +
-
"<option value='#pk_deptVendor#'>#pk_deptVendor#</option>" +
-
" </cfoutput>" +
-
"</select>" +
-
"</td>" +
-
"</tr>" +
-
"</table>" +
-
"<input type='hidden' name='"+partc+"' id='"+partc+"' value='0'>" +
-
"<input type='hidden' name='"+part2c+"' id='"+part2c+"' value=''>" +
-
"<input type='hidden' name='serialcount' id='serialcount' value='" + count + "'>";
-
-
<!--- Adds Delete to every ticket --->
-
newdiv.innerHTML = newdiv.innerHTML +
-
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
-
"<tr>" +
-
"<td>" +
-
"<input type='button' class='removeticket' value='Remove Serial ""+ count +""' onclick=\"removeElement(\'"+divIdName+"\')\"></a>" +
-
"</td>" +
-
"</tr>" +
-
"<tr>" +
-
"<td>" +
-
"<input type='button' class='addticket' value='Add Parts' onclick=\"addpartInput(\'"+divIdName+"\')\">" +
-
"</td>" +
-
"</tr>" +
-
"</table>";
-
-
document.getElementById(divName).appendChild(newdiv);
-
}
-
-
<!---Allows us to remove multiple fields --->
-
function removeElement(divNum) {
-
var d = document.getElementById('dynamicInput');
-
var olddiv = document.getElementById(divNum);
-
d.removeChild(olddiv);
-
}
-
</script>
-
-
-
-
-
-
<!---Allows us to add PARTS information multiple times--->
-
<script type="text/javascript">
-
<!---Adds multiple fields for parts --->
-
function addpartInput(partName){
-
var parts = document.getElementById(partName);
-
-
-
var getparts = document.getElementById('div');
-
var serialno = partName.replace("dynamic","").replace("Input","");
-
var avalue = document.getElementById("partscount"+serialno);
-
var count = parseInt(avalue.value) + 1;
-
avalue.value = count;
-
var partslist = document.getElementById("part2count"+serialno);
-
partslist.value += count + ",";
-
var partdiv = document.createElement('div');
-
var partIdName = 'part' + count + 'Name' + serialno;
-
-
partdiv.setAttribute('id',partIdName);
-
-
<!--- Adds Extra fields for parts table --->
-
partdiv.innerHTML =
-
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0' >" +
-
"<th class='sectiontitle' colspan='7'>Parts Information "+ count +" Serial Information "+serialno+"</th>" +
-
"<tr>" +
-
"<td class='indent' id='formfieldpadding'>HC P/N: " +
-
"<input type='text' name='hcpn_" + count + "_"+serialno+"' style='margin:0px'></td>" +
-
"<td>" +
-
"Parts been returned* " +
-
"<input type='checkbox' name='partsreturn_" + count + "_"+serialno+"' value='1'>" +
-
"</td>" +
-
"<td>" +
-
"<td class='indent'>Defective<input type='checkbox' name='defective_" + count +"_"+serialno+"' value='1'>" +
-
"</td>" +
-
"</td>" +
-
"</tr>" +
-
"</table>";
-
-
-
<!--- Adds Extra fields for RMA Data Only --->
-
partdiv.innerHTML = partdiv.innerHTML +
-
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
-
"<tr>" +
-
"<td id='paddingformultitop'>" +
-
"RMA Data Only: " +
-
"</td>" +
-
"<td class='rmanmoveinmulti'>" +
-
"( You may enter up to 1000 characters. )"+
-
"<br/>" +
-
"<textarea maxlength='1000' onkeyup='return rmamaxlength(this)' onkeydown='return rmamaxlength(this)' rows='4' cols='60' name='rma_" + count + "_"+serialno+"'></textarea> " +
-
"</td>" +
-
"</tr>" +
-
"</table>";
-
-
-
<!--- Adds Delete to every ticket --->
-
partdiv.innerHTML = partdiv.innerHTML +
-
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
-
"<tr>" +
-
"<td>" +
-
"<input type='button' class='removeticket' value='Remove Parts ""+count +""' onclick=\"removetheElement('"+partIdName+"',"+serialno+","+count+")\"></a>" +
-
"</td>" +
-
"</td>" +
-
"</tr>" +
-
"</table>";
-
-
document.getElementById(partName).appendChild(partdiv);
-
}
-
-
<!---Allows us to remove multiple fields--->
-
function removetheElement(divNum, serialno, partnum) {
-
var partslist = document.getElementById("part2count"+serialno);
-
partslist.value = partslist.value.replace(partnum+',',"");
-
var olddiv = document.getElementById(divNum);
-
olddiv.parentNode.removeChild(olddiv);
-
}
-
-
</script>
an here is the html where the previously submitted fields appear
right now i have the serialdisplay.cfm and partsdisplay.cfm in comments because its causeing me problems as well, but its suppose to display fields if no one entered a value for it. which if you need the information for both of those let me know.
Thank you,
Rach
Don't forget that you will need to update the code for the recent change, i.e. when displaying previously entered fields, the part numbers need to be up to date. So on line 167 where part2count#count# is set, the value should not be "". It should be filled with a list of the parts - 1 to the #count# value.
Don't forget that you will need to update the code for the recent change, i.e. when displaying previously entered fields, the part numbers need to be up to date. So on line 167 where part2count#count# is set, the value should not be "". It should be filled with a list of the parts - 1 to the #count# value.
Hey Acoder,
alrighty i changed that line to - <input type="hidden" name="part2count#count#" id="part2count#count#" value="#count#">
whats next? because i am still having the problem that once i go an edit a field and submit it an go to view the results again instead of just showing the one i change it ends up showing it multiple times. An i have checked the tables for both serial and parts an its not repeating the serial or parts. Any ideas?
Thank you,
Rach
The change that you've made wouldn't be enough because if, for example, you had three parts, it should be "1,2,3,", so you need a cfloop to construct the list.
Can you post the update field page code containing the form which you use to update/edit fields and the update serial/parts page including the query(ies).
The change that you've made wouldn't be enough because if, for example, you had three parts, it should be "1,2,3,", so you need a cfloop to construct the list.
Can you post the update field page code containing the form which you use to update/edit fields and the update serial/parts page including the query(ies).
Hey Acoder,
Here is the queries i am using - <!---Shows what was previously entered into serial and description table--->
-
<cfquery name="serial" datasource="CustomerSupport">
-
SELECT pka_serialNo,pkb_fk_ticketNo,model_no,product_type,software_hardware,
-
resolution,resolution_date,verification_date,type_hardware_failure,
-
dept_responsibility,resolution_verified_by,fk_serialNo,fk_ticketNo,description
-
FROM dbo.tbl_CS_serial
-
LEFT JOIN dbo.tbl_CS_notes_descr
-
ON dbo.tbl_CS_serial.pkb_fk_ticketNo=dbo.tbl_CS_notes_descr.fk_ticketNo and
-
dbo.tbl_CS_serial.pka_serialNo=dbo.tbl_CS_notes_descr.fk_serialNo
-
WHERE pkb_fk_ticketNo = #URL.pk_ticketID# and fk_ticketNo = #URL.pk_ticketID#
-
ORDER BY pkb_fk_ticketNo
-
</cfquery>
-
-
<!---Shows what was previously entered into parts table--->
-
<cfquery name="parts" datasource="CustomerSupport">
-
SELECT pk_partID,fk_serialNo,fk_ticketNo,hc_partNo,ltrim(rtrim(part_returned)) as part_returned,rma_number,defective
-
FROM dbo.tbl_CS_parts
-
WHERE fk_ticketNo = #URL.pk_ticketID#
-
</cfquery>
and here is what i am using to update/edit
and where do i need the cfloop list at?
Thank you,
Rach
I see. Can you post the code for userformedit.cfm?
Add the cfloop before the input field line. It should create a string starting from 1 to #count#.
I see. Can you post the code for userformedit.cfm?
Add the cfloop before the input field line. It should create a string starting from 1 to #count#.
Hey Acoder,
Here is what is on the userformedit.cfm page - <!---Inserts information into serial table.--->
-
<CFIF REQUEST_METHOD EQ "POST">
-
<CFSET machineListLen = listLen(Form.serialcount)>
-
<CFLOOP from="1" to="#machineListLen#" index="machineCount">
-
<CFSET serialnum = Form["serialnum_" & machineCount]>
-
<CFSET modelno = Form["modelno_" & machineCount]>
-
<CFSET producttype = Form["producttype_" & machineCount]>
-
<CFSET softhardware = Form["softhardware_" & machineCount]>
-
<CFSET resolution = Form["resolution_" & machineCount]>
-
<CFSET resdate = Form["resdate_" & machineCount]>
-
<CFSET resvertified = Form["resvertified_" & machineCount]>
-
<CFSET vertifidate = Form["vertifidate_" & machineCount]>
-
<CFSET deptvendor = Form["deptvendor_" & machinecount]>
-
<CFSET hardwarefailure = Form["hardwarefailure_" & machineCount]>
-
<CFSET thedescription = Form["thedescription_" & machineCount]>
-
-
-
<!--- inserts information into the serial table--->
-
<cfquery name="serialinsertupdate" datasource="CustomerSupport">
-
exec usp_CS_UpdateInsertserial
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
"#Form.pk_ticketID#",
-
<cfqueryparam value="#modelno#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#producttype#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#softhardware#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#resolution#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#resdate#">,
-
<cfqueryparam value="#resvertified#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#vertifidate#">,
-
<cfqueryparam value="#deptvendor#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#hardwarefailure#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
-
-
-
<!---Inserts information into notes_descr table.--->
-
<cfquery name="description" datasource="CustomerSupport">
-
exec usp_CS_Insertdescription
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#thedescription#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.fk_addedBy#'
-
</cfquery>
-
-
-
-
-
<!---Inserts parts information into parts table.--->
-
<!---because it is a bit we don't use 'ticks' around defective for parts table--->
-
<cfloop list="#form['part2count' & machinecount]#" index="ps">
-
<cfparam name="Form.defective_#ps#_#machinecount#" default="0">
-
<cfparam name="Form.partsreturn_#ps#_#machinecount#" default="0">
-
<CFSET hcpn = Form["hcpn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET partsreturn = Form["partsreturn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET defective = Form["defective_" & "#ps#" & "_#machinecount#"]>
-
<CFSET rma = Form["rma_" & "#ps#" & "_#machineCount#"]>
-
<cfquery name="parts" datasource="CustomerSupport">
-
exec usp_CS_Updateparts
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#hcpn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#partsreturn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#defective#" CFSQLType = "CF_SQL_BIT">,
-
<cfqueryparam value="#rma#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
</cfloop>
an would this be correct for the cfloop. i have it in the update part of the form. - <cfloop from="1" to="#count#" index="counttheparts">
-
<input type="hidden" name="part2count#count#" id="part2count#count#" value="#count#">
-
</cfloop>
an i noticed another problem with the insert :(, you know how we created another count for parts? well i need to do the same thing for serial because if you skip one serial it has a similar fit as parts did.
Thank you,
Rach
Yes, you'll need to update the input field named serialcount too.
For the cfloop, create a string using cfset and then set value to this string in place of #count#: - <cfset partliststr = "">
-
<cfloop ...>
-
<cfset partliststr = partliststr & ...>
-
</cfloop>
-
<input ...>
From your update page code, it seems that you might have to make a few alterations, but let's get this part working first.
Yes, you'll need to update the input field named serialcount too.
For the cfloop, create a string using cfset and then set value to this string in place of #count#:
- <cfset partliststr = "">
-
<cfloop ...>
-
<cfset partliststr = partliststr & ...>
-
</cfloop>
-
<input ...>
From your update page code, it seems that you might have to make a few alterations, but let's get this part working first.
Hey Acoder,
would something like this be correct? - <cfset partliststr = "pl">
-
<cfloop from="1" to="#count#" index="pl">
-
<cfset partliststr = partliststr & #pl#>
-
</cfloop>
-
<input type="hidden" name="part2count#count#" id="part2count#count#" value="#count#">
an i started working on the serial part an making a seperate count for it, well atleast tempting to. So far in the serial function i added (i have it commented out so it wont affect anything). but i added - var serialc = 'sc'+count;
an then i added a hidden field of - "<input type='hidden' name='"+serialc+"' id='"+serialc+"' value=''>" +
an well i added only this to the delete of the serial function but i got confused when i got to delete - var getserial = document.getElementByID('serialc');
Thank you,
Rach
partliststr would have to be empty to begin with and you need to add a comma after each number and finally you need to set the value: - <cfset partliststr = "">
-
<cfloop from="1" to="#count#" index="pl">
-
<cfset partliststr = partliststr & #pl# & ",">
-
</cfloop>
-
<input type="hidden" name="part2count#count#" id="part2count#count#" value="#partliststr#">
You also need to do something similar for serialcount - not create a new field.
partliststr would have to be empty to begin with and you need to add a comma after each number and finally you need to set the value:
- <cfset partliststr = "">
-
<cfloop from="1" to="#count#" index="pl">
-
<cfset partliststr = partliststr & #pl# & ",">
-
</cfloop>
-
<input type="hidden" name="part2count#count#" id="part2count#count#" value="#partliststr#">
You also need to do something similar for serialcount - not create a new field.
Hey Acoder,
Here is what i created for both the part an serial - <cfset serialstr = "">
-
<cfloop from="1" to="#count#" index="sl">
-
<cfset serialstr = serialstr & #sl# & ",">
-
</cfloop>
-
<input type="hidden" name="serialcount" id="serialcount" value="#serialstr#">
-
<input type="hidden" name="partscount#count#" id="partscount#count#" value="#count#">
-
<cfset partliststr = "">
-
<cfloop from="1" to="#count#" index="pl">
-
<cfset partliststr = partliststr & #pl# & ",">
-
</cfloop>
-
<input type="hidden" name="part2count#count#" id="part2count#count#" value="#partliststr#">
an the example i was showing above with the serialcount was for the insert because running into the same problem that i had with parts with the serial.where if i had serials 1,2, and 3 an delete 2 it has an issue with it. Would what i have in the post before this one would for that?
Thank you,
Rach
Move the code for serialcount to wherever it appears in the code. It shouldn't appear in the code for addInput. It should be in the HTML code. Find it there and that's where you'd put the cfloop for serialstr.
Move the code for serialcount to wherever it appears in the code. It shouldn't appear in the code for addInput. It should be in the HTML code. Find it there and that's where you'd put the cfloop for serialstr.
Hey Acoder,
It is in the html its not in the addinput at all.
this is what i have in the addinput - "<input type='hidden' name='"+partc+"' id='"+partc+"' value='0'>" +
-
"<input type='hidden' name='"+part2c+"' id='"+part2c+"' value=''>" +
-
"<input type='hidden' name='serialcount' id='serialcount' value='" + count + "'>";
this is what i have in the html - <cfset serialstr = "">
-
<cfloop from="1" to="#count#" index="sl">
-
<cfset serialstr = serialstr & #sl# & ",">
-
</cfloop>
-
<input type="hidden" name="serialcount" id="serialcount" value="#serialstr#">
-
<input type="hidden" name="partscount#count#" id="partscount#count#" value="#count#">
-
<cfset partliststr = "">
-
<cfloop from="1" to="#count#" index="pl">
-
<cfset partliststr = partliststr & #pl# & ",">
-
</cfloop>
-
<input type="hidden" name="part2count#count#" id="part2count#count#" value="#partliststr#">
-
<!--- Adds Delete to every ticket --->
-
<table class="zpExpandedTable" id="resoltable" cellpadding="1" cellspacing="0">
-
<tr>
-
<td>
Thank you,
Rach
Now that I look at this again, you can get rid of what you've added for serialstr. serialcount is a series of input fields, so what you need to do is make sure each serialcount applies to a serial, i.e. the first one should be set to "1", the second "2", etc. Check that in the source code.
For the parts, you need to use the correct count, so you can't use #count# which would probably be the serial count. You'll need to make sure it's the parts count being used. Make sure everything is set right by testing with a number of scenarios, e.g. 1 serial, 1 part, 2 serials, 1 part or 2 parts or a mixture and see if all the values are set correctly.
Now that I look at this again, you can get rid of what you've added for serialstr. serialcount is a series of input fields, so what you need to do is make sure each serialcount applies to a serial, i.e. the first one should be set to "1", the second "2", etc. Check that in the source code.
For the parts, you need to use the correct count, so you can't use #count# which would probably be the serial count. You'll need to make sure it's the parts count being used. Make sure everything is set right by testing with a number of scenarios, e.g. 1 serial, 1 part, 2 serials, 1 part or 2 parts or a mixture and see if all the values are set correctly.
Hey Acoder,
Only thing i am confused on is this.
Does partscount and partcount2 need to appear in the parts section of the html?
right now these appear in the serial section of the html -
<input type="hidden" name="serialcount" id="serialcount" value="#count#">
-
and this one in parts - <cfset partliststr = "">
-
<cfloop from="1" to="#count1#" index="pl">
-
<cfset partliststr = partliststr & #pl# & ",">
-
</cfloop>
-
<input type="hidden" name="part2count#count1#" id="part2count#count1#" value="#partliststr#">
-
<input type="hidden" name="partscount#count#" id="partscount#count1#" value="#count1#">
but i think i might have an idea of whats causing it.i took out serial count an i got errors, but it didn't insert multiple. However, when i took out the 2 different parts count an left t he serialcount it added serials. So i think it has to do with this - <input type="hidden" name="serialcount" id="serialcount" value="#count#">.
i don't know if it makes a difference but i have serialcount in the addinput as well (except written in javascript), could that be causing it?
Thank you,
Rach
Does partscount and partcount2 need to appear in the parts section of the html?
No it doesn't because these are the parts counts/lists for that particular serial, so it'd only make sense for it to appear once for each serial.
The parts count fields should be named using #count# (serial), but the value should be set to #count1# (part): - <cfset partliststr = "">
-
<cfloop from="1" to="#count1#" index="pl">
-
<cfset partliststr = partliststr & #pl# & ",">
-
</cfloop>
-
<input type="hidden" name="part2count#count#" id="part2count#count#" value="#partliststr#">
-
<input type="hidden" name="partscount#count#" id="partscount#count#" value="#count1#">
but i think i might have an idea of whats causing it.i took out serial count an i got errors, but it didn't insert multiple. However, when i took out the 2 different parts count an left t he serialcount it added serials.
That might've been caused by the incorrect naming.
On the issue of the serial count being added multiple times, that is correct because it's passed as a list to Coldfusion. See the passed value to see what I mean. In fact, this might have been a good way of dealing with the parts count/list instead of what was done in this thread.
No it doesn't because these are the parts counts/lists for that particular serial, so it'd only make sense for it to appear once for each serial.
The parts count fields should be named using #count# (serial), but the value should be set to #count1# (part):
- <cfset partliststr = "">
-
<cfloop from="1" to="#count1#" index="pl">
-
<cfset partliststr = partliststr & #pl# & ",">
-
</cfloop>
-
<input type="hidden" name="part2count#count#" id="part2count#count#" value="#partliststr#">
-
<input type="hidden" name="partscount#count#" id="partscount#count#" value="#count1#">
That might've been caused by the incorrect naming.
On the issue of the serial count being added multiple times, that is correct because it's passed as a list to Coldfusion. See the passed value to see what I mean. In fact, this might have been a good way of dealing with the parts count/list instead of what was done in this thread.
Hey Acoder,
I made the changes to the parts. but in the html does it need to be under the parts section or under the serial section? Here is where i have it right now. -
<!---Shows what was previously entered into parts table--->
-
<!---dbtype="query"--->
-
<cfquery name="getparts" dbtype="query" >
-
SELECT *
-
FROM parts
-
WHERE fk_serialNo=<cfqueryparam value="#pka_serialNo#"
-
cfsqltype="cf_sql_char" maxLength="20">
-
</cfquery>
-
<cfset count1 = 0>
-
<!---<cfif serial.recordcount is 0>--->
-
<cfloop query="getparts">
-
<cfset count1 = count1 + 1>
-
<div id="part#count1#Name#count#">
-
<cfset partliststr = "">
-
<cfloop from="1" to="#count1#" index="pl">
-
<cfset partliststr = partliststr & #pl# & ",">
-
</cfloop>
-
-
<input type="hidden" name="part2count#count#" id="part2count#count#" value="#partliststr#">
-
<input type="hidden" name="partscount#count#" id="partscount#count#" value="#count1#">
an when you talked about passed as a list. Do you mean when the user submits the form an it goes to userform?an the part where it says listlen in the serial? If thats the case, how could i change it or make it where that it will still submit multiple serials, but that when i update it will only update the one serial instead of adding serials? - <!---Inserts information into serial table.--->
-
<CFIF REQUEST_METHOD EQ "POST">
-
<CFSET machineListLen = listLen(Form.serialcount)>
-
<CFLOOP from="1" to="#machineListLen#" index="machineCount">
-
<CFSET serialnum = Form["serialnum_" & machineCount]>
-
<CFSET modelno = Form["modelno_" & machineCount]>
-
<CFSET producttype = Form["producttype_" & machineCount]>
-
<CFSET softhardware = Form["softhardware_" & machineCount]>
-
<CFSET resolution = Form["resolution_" & machineCount]>
-
<CFSET resdate = Form["resdate_" & machineCount]>
-
<CFSET resvertified = Form["resvertified_" & machineCount]>
-
<CFSET vertifidate = Form["vertifidate_" & machineCount]>
-
<CFSET deptvendor = Form["deptvendor_" & machinecount]>
-
<CFSET hardwarefailure = Form["hardwarefailure_" & machineCount]>
-
<CFSET thedescription = Form["thedescription_" & machineCount]>
-
-
-
<!--- inserts information into the serial table--->
-
<cfquery name="serialinsertupdate" datasource="CustomerSupport">
-
exec usp_CS_UpdateInsertserial
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
"#Form.pk_ticketID#",
-
<cfqueryparam value="#modelno#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#producttype#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#softhardware#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#resolution#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#resdate#">,
-
<cfqueryparam value="#resvertified#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#vertifidate#">,
-
<cfqueryparam value="#deptvendor#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#hardwarefailure#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
-
-
-
<!---Inserts information into notes_descr table.--->
-
<cfquery name="description" datasource="CustomerSupport">
-
exec usp_CS_Insertdescription
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#thedescription#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.fk_addedBy#'
-
</cfquery>
-
-
-
-
-
<!---Inserts parts information into parts table.--->
-
<!---because it is a bit we don't use 'ticks' around defective for parts table--->
-
<cfloop list="#form['part2count' & machinecount]#" index="ps">
-
<cfparam name="Form.defective_#ps#_#machinecount#" default="0">
-
<cfparam name="Form.partsreturn_#ps#_#machinecount#" default="0">
-
<CFSET hcpn = Form["hcpn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET partsreturn = Form["partsreturn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET defective = Form["defective_" & "#ps#" & "_#machinecount#"]>
-
<CFSET rma = Form["rma_" & "#ps#" & "_#machineCount#"]>
-
<cfquery name="parts" datasource="CustomerSupport">
-
exec usp_CS_Updateparts
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#hcpn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#partsreturn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#defective#" CFSQLType = "CF_SQL_BIT">,
-
<cfqueryparam value="#rma#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
</cfloop>
-
</CFLOOP>
-
</CFIF>
Thank you,
Rach
It should be under serial as you currently have it.
As for the update page, do you want it to update only one serial at a time or multiple serials/parts all in one go? If it's the latter, you will need to keep it similar to what it is now, though we'd need to check what the update query does. If it's the former, i.e. one at a time, then don't display all at once, provide an edit link to display a particular serial or part and only update that one serial or part.
It should be under serial as you currently have it.
As for the update page, do you want it to update only one serial at a time or multiple serials/parts all in one go? If it's the latter, you will need to keep it similar to what it is now, though we'd need to check what the update query does. If it's the former, i.e. one at a time, then don't display all at once, provide an edit link to display a particular serial or part and only update that one serial or part.
Hey Acoder,
Well the tricky part is. it does need to update multiple serial/parts in one go. But it also has to be able to accept adding more serials/parts and update the other previously submitted serial/parts at the same time. i haven't had any trouble adding any so far (even with having previously submitted serials/parts updating at the same time). an it has not added multiple serial/parts when i do insert. Just when i update previously submitted serial/parts. Do you want me to copy the update query for serial and parts?
Thank you,
Rach
This could get complicated. What if someone adds and deletes serials and parts? You'd be adding, updating and deleting all in one go without any information about what is new and what's changed, etc. I would suggest that you keep updates, adds and deletes all separate. It's more logical and would make things easier.
If, for some reason, you must have all in one go, you'll need to pass this info. to the submit page, e.g. the primary key for serials and parts to allow updates, an indication for deletion, an indication of addition, for both parts and serials. This can be solved, but you'd have to do it carefully.
Hey Acoder,
Well i was thinking about keeping it in all in one go. But it sounds like it would be easier and better if we separate them out, so lets separate them out :). I have an update an a insert for serial and parts. Just don't have a delete for either of them right now. But my stored procedures
insert for serial -
set ANSI_NULLS ON
-
set QUOTED_IDENTIFIER ON
-
go
-
-
-
-- =============================================
-
-- Author: <Author,,Name>
-
-- Create date: <Create Date,,>
-
-- Description: <Description,,>
-
-- =============================================
-
ALTER PROCEDURE [dbo].[usp_CS_Insertserial]
-
-- Add the parameters for the stored procedure here
-
(@pka_serialNo nvarchar(100),
-
@pkb_fk_ticketNo nvarchar(100),
-
@model_no nvarchar(50),
-
@product_type nvarchar(100),
-
@software_hardware nvarchar(40),
-
@resolution nvarchar(500),
-
@resolution_date datetime,
-
@resolution_verified_by nvarchar(50),
-
@verification_date datetime,
-
@dept_responsibility nvarchar(50),
-
@type_hardware_failure nvarchar(100))
-
AS
-
BEGIN
-
-- SET NOCOUNT ON added to prevent extra result sets from
-
-- interfering with SELECT statements.
-
SET NOCOUNT ON;
-
-
-- Insert statements for procedure here
-
insert into tbl_CS_serial
-
(pka_serialNo,pkb_fk_ticketNo,model_no,product_type,software_hardware,resolution,resolution_date,
-
resolution_verified_by,verification_date,dept_responsibility,type_hardware_failure)
-
-
values
-
(@pka_serialNo,@pkb_fk_ticketNo,@model_no,@product_type,@software_hardware,@resolution,@resolution_date,
-
@resolution_verified_by,@verification_date,@dept_responsibility,@type_hardware_failure)
-
-
END
update for serial - set ANSI_NULLS ON
-
set QUOTED_IDENTIFIER ON
-
go
-
-
-- =============================================
-
-- Author: <Author,,Name>
-
-- Create date: <Create Date,,>
-
-- Description: <Description,,>
-
-- =============================================
-
ALTER PROCEDURE [dbo].[usp_CS_Updateserial]
-
-- Add the parameters for the stored procedure here
-
(@pka_serialNo nvarchar(100),
-
@pkb_fk_ticketNo nvarchar(100),
-
@model_no nvarchar(50),
-
@product_type nvarchar(100),
-
@software_hardware nvarchar(40),
-
@resolution nvarchar(500),
-
@resolution_date datetime,
-
@resolution_verified_by nvarchar(50),
-
@verification_date datetime,
-
@dept_responsibility nvarchar(50),
-
@type_hardware_failure nvarchar(100))
-
-
AS
-
-
UPDATE tbl_CS_serial
-
-
SET
-
-
model_no=@model_no,
-
product_type=@product_type,
-
software_hardware=@software_hardware,
-
resolution=@resolution,
-
resolution_date=@resolution_date,
-
resolution_verified_by=@resolution_verified_by,
-
verification_date=@verification_date,
-
dept_responsibility=@dept_responsibility,
-
type_hardware_failure=@type_hardware_failure
-
-
-
-
-
WHERE (pka_serialNo=@pka_serialNo and pkb_fk_ticketNo=@pkb_fk_ticketNo)
insert for parts -
set ANSI_NULLS ON
-
set QUOTED_IDENTIFIER ON
-
go
-
-
-
-- =============================================
-
-- Author: <Author,,Name>
-
-- Create date: <Create Date,,>
-
-- Description: <Description,,>
-
-- =============================================
-
ALTER PROCEDURE [dbo].[usp_CS_Insertparts]
-
-- Add the parameters for the stored procedure here
-
(@fk_serialNo nvarchar(100),
-
@fk_ticketNo nvarchar(100),
-
@hc_partNo nvarchar(50),
-
@part_returned char(10),
-
@defective bit,
-
@rma_number nvarchar(50))
-
AS
-
declare @pk_partID nvarchar(55)
-
set @pk_partID = (select max_num from tbl_CS_ID_HELPER where table_name='tbl_CS_parts')
-
update tbl_CS_ID_helper set max_num=max_num+1 where table_name='tbl_CS_parts'
-
BEGIN
-
-- SET NOCOUNT ON added to prevent extra result sets from
-
-- interfering with SELECT statements.
-
SET NOCOUNT ON;
-
-
-- Insert statements for procedure here
-
insert into tbl_CS_parts
-
(pk_partID,fk_serialNo,fk_ticketNo,hc_partNo,part_returned ,defective
-
,rma_number)
-
-
values
-
(@pk_partID,@fk_serialNo,@fk_ticketNo,@hc_partNo,@part_returned,@defective
-
,@rma_number)
-
-
select @pk_partID as partID
-
END
-
an here is the parts update - set ANSI_NULLS ON
-
set QUOTED_IDENTIFIER ON
-
go
-
-
-- =============================================
-
-- Author: <Author,,Name>
-
-- Create date: <Create Date,,>
-
-- Description: <Description,,>
-
-- =============================================
-
ALTER PROCEDURE [dbo].[usp_CS_Updateparts]
-
-- Add the parameters for the stored procedure here
-
(@fk_serialNo nvarchar(100),
-
@fk_ticketNo nvarchar(100),
-
@hc_partNo nvarchar(50),
-
@part_returned char(10),
-
@defective bit,
-
@rma_number nvarchar(50))
-
-
AS
-
-
UPDATE tbl_CS_parts
-
-
SET
-
-
fk_ticketNo=@fk_ticketNo,
-
hc_partNo=@hc_partNo,
-
part_returned=@part_returned,
-
defective=@defective,
-
rma_number=@rma_number
-
-
-
WHERE (fk_serialNo = @fk_serialNo and fk_ticketNo=@fk_ticketNo)
an well i tried to come up with the delete for serial an part, but not sure if this is the correct way to do it
delete serial - set ANSI_NULLS ON
-
set QUOTED_IDENTIFIER ON
-
go
-
-
-
-- =============================================
-
-- Author: <Author,,Name>
-
-- Create date: <Create Date,,>
-
-- Description: <Description,,>
-
-- =============================================
-
CREATE PROCEDURE [dbo].[usp_CS_Deleteserial]
-
-- Add the parameters for the stored procedure here
-
(@pka_serialNo nvarchar(100)) AS
-
-
DELETE FROM tbl_CS_serial
-
-
WHERE (pka_serialNo=@pka_serialNo and pkb_fk_ticketNo=@pkb_fk_ticketNo)
delete part - set ANSI_NULLS ON
-
set QUOTED_IDENTIFIER ON
-
go
-
-
-
-- =============================================
-
-- Author: <Author,,Name>
-
-- Create date: <Create Date,,>
-
-- Description: <Description,,>
-
-- =============================================
-
ALTER PROCEDURE [dbo].[usp_CS_Deleteparts]
-
-- Add the parameters for the stored procedure here
-
(@fk_serialNo nvarchar(100))
-
AS
-
-
DELETE FROM tbl_CS_parts
-
-
-
WHERE (fk_serialNo = @fk_serialNo and fk_ticketNo=@fk_ticketNo)
Thank you,
Rach
You could have one submission page which deals with all in one go, though the form page would be different and you'd have to specify somewhere what kind of edit it is: add/delete and update.
There is also one other way you could do this: delete all serials and parts and then add them all again using the new info. This seems a bit overkill though, but would allow you to keep it all in one file and similar to what you have to an extent.
Having said that, if you're going to combine add and delete, you might as well combine update as well. I know that goes against what I said earlier, but with combining add and delete, you have to find out which ones need deleting and which ones need adding.
The best separation would be to have add, delete and update all separate for separate serials and parts. This might be too much of a change though, so I'm not sure if you'd want to go ahead with it.
If you want something quicker, then it'd probably be best to go with what you were doing up to now.
You could have one submission page which deals with all in one go, though the form page would be different and you'd have to specify somewhere what kind of edit it is: add/delete and update.
There is also one other way you could do this: delete all serials and parts and then add them all again using the new info. This seems a bit overkill though, but would allow you to keep it all in one file and similar to what you have to an extent.
Having said that, if you're going to combine add and delete, you might as well combine update as well. I know that goes against what I said earlier, but with combining add and delete, you have to find out which ones need deleting and which ones need adding.
The best separation would be to have add, delete and update all separate for separate serials and parts. This might be too much of a change though, so I'm not sure if you'd want to go ahead with it.
If you want something quicker, then it'd probably be best to go with what you were doing up to now.
Hey Acoder,
Well the most important thing to me is that it works good an i wont have to worry about to many problems. Not really worried about making a lot of changes as long as the end result works good.So whatever way you think would work best would be good for me :). But so do i need to have insert, update and delete 3 separate stored procedure or do i need to combine them? right now i have them all separate like above.
Thank you,
Rach
No, the stored procedures should be separate.
As for the separation, though it makes sense, it would mean that all the code for adding/deleting using JavaScript would no longer be required because the adding and deleting would take place in stages - one by one. Do pages take a long time to load? Would it be a problem?
No, the stored procedures should be separate.
As for the separation, though it makes sense, it would mean that all the code for adding/deleting using JavaScript would no longer be required because the adding and deleting would take place in stages - one by one. Do pages take a long time to load? Would it be a problem?
Hey Acoder,
I don't think it would be a problem. I haven't had any loading problems at all.But if we remove the javascript then we won't be able to add multiple serials and parts now right? they still need to be able to add serials and parts and update ones that previously where submitted.
Thank you,
Rach
You wouldn't, but it wouldn't be required. The simplest solution from where you're at is to do it all in one go. In that case, you wouldn't even need an update because everything would be deleted and then added again.
You wouldn't, but it wouldn't be required. The simplest solution from where you're at is to do it all in one go. In that case, you wouldn't even need an update because everything would be deleted and then added again.
Hey Acoder,
I understand on the deleting previously submitted and just reinsert it. But what i am confused on, is if we go in this direction. Basically the user won't be able to add more serial and more parts to the ones they have previously correct?Because the biggest thing besides for being able to put in new changes is to be able to add more parts and more serials.
Thank you,
Rach
They would be able to add more serials and parts because it's assumed that everything will change, so everything is deleted first to be added with the changes. The big obvious disadvantage to this is that if you even change one single field in one single part and you have, say, 3 serials with 2 parts each, everything would be deleted and added all over again (and a side effect would be that the update takes place). If you want to avoid that, then you would need to make a separate page specially for updates and no additions/deletions would be allowed on that page.
They would be able to add more serials and parts because it's assumed that everything will change, so everything is deleted first to be added with the changes. The big obvious disadvantage to this is that if you even change one single field in one single part and you have, say, 3 serials with 2 parts each, everything would be deleted and added all over again (and a side effect would be that the update takes place). If you want to avoid that, then you would need to make a separate page specially for updates and no additions/deletions would be allowed on that page.
Hey Acoder,
Well the deleting is not a big deal. To be honest i have doubts that many changes will be made to it, except to say that this problem has been closed (but you never know). But as long as they can still add multiple serials and parts then i am ready to go. Where do we begin?
Thank you,
Rach
OK, the first thing you need to do is add a delete query which deletes parts and serials, so you could use two stored procedures, or you could use one cascading delete where if you delete serials, the parts are also deleted.
OK, the first thing you need to do is add a delete query which deletes parts and serials, so you could use two stored procedures, or you could use one cascading delete where if you delete serials, the parts are also deleted.
Hey Acoder,
I have already created 2 delete querys. One for parts and serials. I am not sure if this is the correct way to do a delete stored procedure. Here is what i have.
delete for serial -
set ANSI_NULLS ON
-
set QUOTED_IDENTIFIER ON
-
go
-
-
-
-- =============================================
-
-- Author: <Author,,Name>
-
-- Create date: <Create Date,,>
-
-- Description: <Description,,>
-
-- =============================================
-
CREATE PROCEDURE [dbo].[usp_CS_Deleteserial]
-
-- Add the parameters for the stored procedure here
-
(@pka_serialNo nvarchar(100),
-
@pkb_fk_ticketNo nvarchar(100)) AS
-
-
DELETE FROM tbl_CS_serial
-
-
WHERE (pka_serialNo=@pka_serialNo and pkb_fk_ticketNo=@pkb_fk_ticketNo)
delete for parts - set ANSI_NULLS ON
-
set QUOTED_IDENTIFIER ON
-
go
-
-
-
-- =============================================
-
-- Author: <Author,,Name>
-
-- Create date: <Create Date,,>
-
-- Description: <Description,,>
-
-- =============================================
-
CREATE PROCEDURE [dbo].[usp_CS_Deleteparts]
-
-- Add the parameters for the stored procedure here
-
(@fk_serialNo nvarchar(100),
-
@fk_ticketNo nvarchar(100))
-
AS
-
-
DELETE FROM tbl_CS_parts
-
-
-
WHERE (fk_serialNo = @fk_serialNo and fk_ticketNo=@fk_ticketNo)
Thank you,
Rach
Do you use these delete queries anywhere else? If not, it might be an idea to write one which removes all parts and serials for a particular ticket in one (or possibly two) queries. Either way, this is OK too, the only difference being that you'll have to have a nested loop deleting all serials and parts one by one.
Do you use these delete queries anywhere else? If not, it might be an idea to write one which removes all parts and serials for a particular ticket in one (or possibly two) queries. Either way, this is OK too, the only difference being that you'll have to have a nested loop deleting all serials and parts one by one.
Hey Acoder,
Nope the 2 delete queries are not used anywhere else. So how would i combine the 2 into one query? it was hard to find example online of just trying to delete.
Thank you,
Rach
Well, it's not strictly necessary, just a performance issue should you need to go back to it.
In your action page, add a loop that loops over the serials and within that loop, loops over the parts and deletes them one by one, followed by a deletion of the serial for that loop iteration. The cfloop tags would be similar to what you have for addition.
Well, it's not strictly necessary, just a performance issue should you need to go back to it.
In your action page, add a loop that loops over the serials and within that loop, loops over the parts and deletes them one by one, followed by a deletion of the serial for that loop iteration. The cfloop tags would be similar to what you have for addition.
Hey Acoder,
Well do you have a suggestion on where i could find an example on how to delete records from 2 tables? having a hard time finding an example online.
An are you meaning something like this for the cfloop, was not sure what type of cfloop they should be so i just left them <cfloop>. but is where i place the 2 cfloop's correct? - <!---Inserts information into serial table.--->
-
<CFIF REQUEST_METHOD EQ "POST">
-
<CFSET machineListLen = listLen(Form.serialcount)>
-
<cfloop>
-
<CFLOOP from="1" to="#machineListLen#" index="machineCount">
-
<CFSET serialnum = Form["serialnum_" & machineCount]>
-
<CFSET modelno = Form["modelno_" & machineCount]>
-
<CFSET producttype = Form["producttype_" & machineCount]>
-
<CFSET softhardware = Form["softhardware_" & machineCount]>
-
<CFSET resolution = Form["resolution_" & machineCount]>
-
<CFSET resdate = Form["resdate_" & machineCount]>
-
<CFSET resvertified = Form["resvertified_" & machineCount]>
-
<CFSET vertifidate = Form["vertifidate_" & machineCount]>
-
<CFSET deptvendor = Form["deptvendor_" & machinecount]>
-
<CFSET hardwarefailure = Form["hardwarefailure_" & machineCount]>
-
<CFSET thedescription = Form["thedescription_" & machineCount]>
-
-
-
<!--- inserts information into the serial table--->
-
<cfquery name="serialinsertupdate" datasource="CustomerSupport">
-
exec usp_CS_Updateserial
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
"#Form.pk_ticketID#",
-
<cfqueryparam value="#modelno#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#producttype#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#softhardware#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#resolution#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#resdate#">,
-
<cfqueryparam value="#resvertified#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#vertifidate#">,
-
<cfqueryparam value="#deptvendor#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#hardwarefailure#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
-
<!---Inserts information into notes_descr table.--->
-
<cfquery name="description" datasource="CustomerSupport">
-
exec usp_CS_Insertdescription
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#thedescription#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.fk_addedBy#'
-
</cfquery>
-
-
<!---Inserts parts information into parts table.--->
-
<!---because it is a bit we don't use 'ticks' around defective for parts table--->
-
<cfloop list="#form['part2count' & machinecount]#" index="ps">
-
<cfloop>
-
<cfparam name="Form.defective_#ps#_#machinecount#" default="0">
-
<cfparam name="Form.partsreturn_#ps#_#machinecount#" default="0">
-
<CFSET hcpn = Form["hcpn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET partsreturn = Form["partsreturn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET defective = Form["defective_" & "#ps#" & "_#machinecount#"]>
-
<CFSET rma = Form["rma_" & "#ps#" & "_#machineCount#"]>
-
<cfquery name="parts" datasource="CustomerSupport">
-
exec usp_CS_Updateparts
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#hcpn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#partsreturn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#defective#" CFSQLType = "CF_SQL_BIT">,
-
<cfqueryparam value="#rma#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
</cfloop>
-
</cfloop>
-
</cfloop>
-
</CFLOOP>
-
</CFIF>
Thank you,
Rach
You can search for "delete cascade". If you have problems, ask in the SQL Server forum.
On the other hand, if you want to stick with what you've got and work with Coldfusion, you can use a loop to delete serials and parts one by one instead. I'll correct myself and say that you only need one loop. Copy lines 3 and 5 and put them above line 1. Now you have the beginning of the loop. First you would delete the parts that have the serial id (as foreign key) and then the serial.
You can search for "delete cascade". If you have problems, ask in the SQL Server forum.
On the other hand, if you want to stick with what you've got and work with Coldfusion, you can use a loop to delete serials and parts one by one instead. I'll correct myself and say that you only need one loop. Copy lines 3 and 5 and put them above line 1. Now you have the beginning of the loop. First you would delete the parts that have the serial id (as foreign key) and then the serial.
Hey Acoder,
do i need to delete the 2 <cfloop> i had created before. here is what i have. -
<!---Inserts information into serial table.--->
-
<CFSET machineListLen = listLen(Form.serialcount)>
-
<CFLOOP from="1" to="#machineListLen#" index="machineCount">
-
<CFIF REQUEST_METHOD EQ "POST">
-
<cfloop>
-
<CFSET serialnum = Form["serialnum_" & machineCount]>
-
<CFSET modelno = Form["modelno_" & machineCount]>
-
<CFSET producttype = Form["producttype_" & machineCount]>
-
<CFSET softhardware = Form["softhardware_" & machineCount]>
-
<CFSET resolution = Form["resolution_" & machineCount]>
-
<CFSET resdate = Form["resdate_" & machineCount]>
-
<CFSET resvertified = Form["resvertified_" & machineCount]>
-
<CFSET vertifidate = Form["vertifidate_" & machineCount]>
-
<CFSET deptvendor = Form["deptvendor_" & machinecount]>
-
<CFSET hardwarefailure = Form["hardwarefailure_" & machineCount]>
-
<CFSET thedescription = Form["thedescription_" & machineCount]>
-
-
-
<!--- inserts information into the serial table--->
-
<cfquery name="serialinsertupdate" datasource="CustomerSupport">
-
exec usp_CS_Updateserial
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
"#Form.pk_ticketID#",
-
<cfqueryparam value="#modelno#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#producttype#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#softhardware#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#resolution#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#resdate#">,
-
<cfqueryparam value="#resvertified#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#vertifidate#">,
-
<cfqueryparam value="#deptvendor#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#hardwarefailure#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
-
<!---Inserts information into notes_descr table.--->
-
<cfquery name="description" datasource="CustomerSupport">
-
exec usp_CS_Insertdescription
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#thedescription#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.fk_addedBy#'
-
</cfquery>
-
-
<!---Inserts parts information into parts table.--->
-
<!---because it is a bit we don't use 'ticks' around defective for parts table--->
-
<cfloop list="#form['part2count' & machinecount]#" index="ps">
-
<cfloop>
-
<cfparam name="Form.defective_#ps#_#machinecount#" default="0">
-
<cfparam name="Form.partsreturn_#ps#_#machinecount#" default="0">
-
<CFSET hcpn = Form["hcpn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET partsreturn = Form["partsreturn_" & "#ps#" & "_#machinecount#"]>
-
<CFSET defective = Form["defective_" & "#ps#" & "_#machinecount#"]>
-
<CFSET rma = Form["rma_" & "#ps#" & "_#machineCount#"]>
-
<cfquery name="parts" datasource="CustomerSupport">
-
exec usp_CS_Updateparts
-
<cfqueryparam value="#serialnum#" CFSQLType = "CF_SQL_VARCHAR">,
-
'#Form.pk_ticketID#',
-
<cfqueryparam value="#hcpn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#partsreturn#" CFSQLType = "CF_SQL_VARCHAR">,
-
<cfqueryparam value="#defective#" CFSQLType = "CF_SQL_BIT">,
-
<cfqueryparam value="#rma#" CFSQLType = "CF_SQL_VARCHAR">
-
</cfquery>
-
</cfloop>
-
</cfloop>
-
</cfloop>
-
</CFLOOP>
-
</CFIF>
an will this work for the delete for both serial and parts? -
set ANSI_NULLS ON
-
set QUOTED_IDENTIFIER ON
-
go
-
-
-
-- =============================================
-
-- Author: <Author,,Name>
-
-- Create date: <Create Date,,>
-
-- Description: <Description,,>
-
-- =============================================
-
CREATE PROCEDURE [dbo].[usp_CS_Deletesp]
-
-- Add the parameters for the stored procedure here
-
(@pka_serialNo nvarchar(100),
-
@pkb_fk_ticketNo nvarchar(100),
-
@fk_serialNo nvarchar(100),
-
@fk_ticketNo nvarchar(100)) AS
-
-
DELETE FROM tbl_CS_serial
-
WHERE (pka_serialNo=@pka_serialNo and pkb_fk_ticketNo=@pkb_fk_ticketNo)
-
-
DELETE FROM tbl_CS_parts
-
WHERE (fk_serialNo = @fk_serialNo and fk_ticketNo=@fk_ticketNo)
-
-
Thank you,
Rach
If you're going to use one stored procedure to delete all serials and parts, then you won't need the loop code in Coldfusion.
If you're going the SQL Server route, the best solution would probably be a delete cascade, but you may want to make sure firstly that your version of SQL Server supports it and secondly ask the experts in the SQL Server forum if they have any suggestions. If that's not possible, the solution would be to delete from parts first and then from serials. You only need the ticket number.
If you're going to use one stored procedure to delete all serials and parts, then you won't need the loop code in Coldfusion.
If you're going the SQL Server route, the best solution would probably be a delete cascade, but you may want to make sure firstly that your version of SQL Server supports it and secondly ask the experts in the SQL Server forum if they have any suggestions. If that's not possible, the solution would be to delete from parts first and then from serials. You only need the ticket number.
Hey Acoder,
Well the reason i am doing the SQL server route is because you said i could run into problems later doing it the other way, which trying to avoid as many problems as possible. But i thought that was a delete cascade? it was the only example i could find online that deleted from 2 tables. Only ones i could find where ones that had delete and update or would delete from one table.Do you know of a better way to search it? i tried delete cascade, i tried sql server stored procedure delete cascade. Really hard to find an example.
Thank you,
Rach
Sign in to post your reply or Sign up for a free account.
Similar topics
by: euang |
last post by:
Hi,
I have been using access 2000 for two years on WINDOWS NT to display dynamic
aweb page using ASP
My ISP has now changed to Windows 2003, and I am having major problems
displaying...
|
by: Sue |
last post by:
As soon as a character is entered in the first field of a new record, the number
of records shown in the navigation buttons increases by 1 and the new record
button becomes enabled. In the...
|
by: Robin S. |
last post by:
I tried to ask this question several days ago, but I didn't explain my
application correctly.
Basically I want to have one record from table "A" and I want to display,
say, 5 records from table...
|
by: Vigneshwar Pilli via DotNetMonster.com |
last post by:
Hey,
Well, I have a Problem.
I have designed a table which has few fields which are being declared in
the database of type ....
char of length 10.
and other fields with varchar 50 and...
|
by: hbomb |
last post by:
I have a form which is used to both enter data for an application and to view a snapshot of previous data entered for students. The database’s initial point of entry is a form called INTERESTED...
|
by: NumberCruncher |
last post by:
Hi All,
I am struggling with setting up my first system of tables, forms,and reports, and could use your help!
I am setting up a database to keep track of the production of a produced item. The...
|
by: banderson |
last post by:
Hello,
I have a combo box in which I want to display multiple fields by concatenating the fields together. If one of those concatenated fields is Null, then the combo box does not show anything. To...
|
by: bonneylake |
last post by:
Hey Everyone,
Well this is probably a pretty easy question, but for some reason i just can not figure it out.
What i am trying to do is redisplay what was entered previously. I have figured...
|
by: chuck gregory |
last post by:
I'm using the 2002 (10.6771.6845) SP3 Access program.
I have a form that will not show previously entered data. It has about 45 fields. I will call it the "parent" form. The "parent" form was at...
|
by: CloudSolutions |
last post by:
Introduction:
For many beginners and individual users, requiring a credit card and email registration may pose a barrier when starting to use cloud servers. However, some cloud server providers now...
|
by: Faith0G |
last post by:
I am starting a new it consulting business and it's been a while since I setup a new website. Is wordpress still the best web based software for hosting a 5 page website? The webpages will be...
|
by: isladogs |
last post by:
The next Access Europe User Group meeting will be on Wednesday 3 Apr 2024 starting at 18:00 UK time (6PM UTC+1) and finishing by 19:30 (7.30PM).
In this session, we are pleased to welcome former...
|
by: ryjfgjl |
last post by:
In our work, we often need to import Excel data into databases (such as MySQL, SQL Server, Oracle) for data analysis and processing. Usually, we use database tools like Navicat or the Excel import...
|
by: ryjfgjl |
last post by:
In our work, we often receive Excel tables with data in the same format. If we want to analyze these data, it can be difficult to analyze them because the data is spread across multiple Excel files...
|
by: emmanuelkatto |
last post by:
Hi All, I am Emmanuel katto from Uganda. I want to ask what challenges you've faced while migrating a website to cloud.
Please let me know.
Thanks!
Emmanuel
|
by: BarryA |
last post by:
What are the essential steps and strategies outlined in the Data Structures and Algorithms (DSA) roadmap for aspiring data scientists? How can individuals effectively utilize this roadmap to progress...
|
by: nemocccc |
last post by:
hello, everyone, I want to develop a software for my android phone for daily needs, any suggestions?
|
by: Hystou |
last post by:
There are some requirements for setting up RAID:
1. The motherboard and BIOS support RAID configuration.
2. The motherboard has 2 or more available SATA protocol SSD/HDD slots (including MSATA, M.2...
| |
