how to loop through this?

[bonneylake]

Hey Everyone,

What i am trying to do is show previously entered information. I know i need a loop for this , but i am not sure how to loop through this based on my form appears all in the javascript

here is my code

<cfquery name="serial" datasource="CustomerSupport">
        SELECT pka_serialNo,pkb_fk_ticketNo,model_no,product_type,software_hardware,resolution,resolution_date,
         verification_date,rma_data,type_hardware_failure,dept_responsibility,resolution_verified_by FROM dbo.tbl_CS_serial
</cfquery>
 
<cfoutput query="serial">
<cfset model_no = #model_no#>
<cfset product_type = #product_type#>
<cfset type_hardware_failure = #type_hardware_failure#>
<cfset software_hardware = #software_hardware#>
<cfset resolution_verified_by = #resolution_verified_by#>
<cfset dept_responsibility = #dept_responsibility#>
</cfoutput>
 
<script type="text/javascript">
 
<!---Allows us to show previous fields --->
 
function showInput(divName){
var dynamic = document.getElementById('dynamicInput');
var thevalue = document.getElementById('theValue');
var count = (document.getElementById('theValue').value -1)+ 2;
thevalue.value = count;
var newdiv = document.createElement('div');
var divIdName = 'dynamic'+count+'Input';
newdiv.setAttribute('id',divIdName);
 
 
<!--- Adds Extra fields for Model No, Product Type, and Type of Hardware Failure  --->
newdiv.innerHTML =
 
"<table class='zpExpandedTable' id='modeltable'>" +
"<th class='sectiontitletick' colspan='7'>Serial Information "+ count +" </th>" +
"<tr>" +
"<td id='paddingformultitop'>Model No:&nbsp;&nbsp;&nbsp;&nbsp;</td>" +
"</td>" +
"<td>" +
 "<select name='modelno_" + count + "'>" +
 "<option value=''>Make A Selection</option>" +
"<cfoutput query='models'>" + 
"<option value='#model#'<cfif #model# is #evaluate(model_no)#>selected</cfif>>#model#</option>" + 
"</cfoutput>" + 
 "</select>" +
 "</td>" +
 "<td>" +
"&nbsp;&nbsp;&nbsp;&nbsp;Product Type:"  +
"</td>" +
"<td>" +
"<select name='producttype_" + count + "'>" +
"<option value='' selected>No Choice</option>" +
"<cfoutput query='getProdType'>" + 
"<option value='#pk_productType#'<cfif #pk_productType# is #product_type#>selected</cfif>>#pk_productType#</option>" + 
"</cfoutput>" + 
"</select>" +
"</td>" +
"<td class='red'>" +
"&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;Type Of Hardware Failure*:" +
"</td>" +
"<td>" +
"<select name='hardwarefailure_" + count + "'>" +
"<option value='' selected>Make A Selection</option>" +
"<cfoutput query='getHardwareFail'>" +
"<option value='#pk_hardwareFailure#'<cfif #pk_hardwareFailure# is #type_hardware_failure#>selected</cfif>>#pk_hardwareFailure#</option>" +
"</cfoutput>" +
"</select>" +
"</td>" +
"</tr>" +
"<table>";
 
<!--- Adds Extra fields for Serial Number and Software/Hardware  --->
newdiv.innerHTML = newdiv.innerHTML +
"<table class='zpExpandedTable' id='modeltable'>" +
"<tr>" +
"<td id='paddingformultitop'>" +
"Serial Number:&nbsp;&nbsp;" +
"<cfoutput query="serial"><input type='text' name='serialnum_" + count + "' value='#pka_serialNo#' ></cfoutput>" +
"&nbsp;&nbsp;&nbsp;&nbsp;Software/Hardware:&nbsp;&nbsp;" +
"<select name='softhardware_" + count + "'>" +
"<option value='' selected>No Choice</option>" +
"<cfoutput query='getSoftHard'>" + 
"<option value='#pk_softwareHardware#'<cfif #pk_softwareHardware# is #software_hardware#>selected</cfif>>#pk_softwareHardware#</option>" + 
"</cfoutput>" + 
"</select>" +
"</td>" +
"</tr>" +
"</table>";
 
<!--- Adds Extra fields for Description ---> 
newdiv.innerHTML = newdiv.innerHTML + 
"<table class='zpExpandedTable' id='resoltable' cellpadding='3' cellspacing='0'>" +
"<tr>" +
"<td id='paddingformutli'>" +
"Description:&nbsp;&nbsp;" + 
"</td>" +
"<td class='descriptionmoveinmulti'>" +
"( You may enter up to 500 characters. )"+
"<br>" +
"<cfoutput query="description"><textarea maxlength='500' onkeyup='return ismaxlength(this)' onkeydown='return ismaxlength(this)'rows='4' cols='60' name='thedescription_" + count + "'>#description#</textarea></cfoutput>" + 
"</td>" +
"</tr>" +
"</table>";
 
<!--- Adds Extra fields for Resolution  --->
newdiv.innerHTML = newdiv.innerHTML +
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
"<tr>" +
"<td id='paddingformutli'>" +
"Resolution:&nbsp;&nbsp;" +
"</td>" +
"<td class='resolutionmoveinmulti'>" +
"( You may enter up to 500 characters. )"+
"<br>" +
"<cfoutput query='serial'><textarea  maxlength='500' onkeyup='return ismaxlength(this)' onkeydown='return ismaxlength(this)' rows='4' cols='60' name='resolution_" + count + "'>#resolution#</textarea></cfoutput>" +
"</td>" +
"</tr>" +
"</table>";
 
<!--- Adds Extra fields for Resolution Date, Current Date (for resolution date) and resolution vertified as effective by  --->
newdiv.innerHTML = newdiv.innerHTML +
"<table class='zpExpandedTable' id='resoldatetab' cellpadding='1' cellspacing='0'>" +
"<tr>" +
"<td id='paddingformultitop'>" +
"Resolution Date:&nbsp;(MM/DD/YYYY)&nbsp;&nbsp;" +
"</td>" +
"<td>" +
"<cfoutput query='serial'><input type='text' name='resdate_" + count + "' value='#resolution_date#'>&nbsp;&nbsp;</cfoutput>" +
 
"&nbsp;&nbsp;&nbsp;&nbsp;Current Date:&nbsp;&nbsp;" +
"<input type='checkbox' name='currentdateresol_" + count + "' onClick=resdate_" + count + ".value=fill_date()>" +
"</td>" +
"<td>" +
"Resolution Verified as effective by:&nbsp;&nbsp;"  +
"</td>" +
"<td>" +
"<select name='resvertified_" + count + "'>" +
"<option value='' selected>Make A Selection</option>" +
"<cfoutput query='gettech'>" +
"<option value='#fname# #lname#'<cfif "#fname# #lname#" is #resolution_verified_by#>selected</cfif>>#fname# #lname#</option>" +
" </cfoutput>" +
"</select>" +
"</td>" +
"</tr>" +
"</table>";
 
 
<!--- Adds Extra fields for Vertification Date, Current Date (for vertification date)   --->
newdiv.innerHTML = newdiv.innerHTML +
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
"<tr>" +
"<td id='paddingformultitop'>" +
"Verification Date:&nbsp;(MM/DD/YYYY)&nbsp;&nbsp;" +
"</td>" +
"<td class='vertificationmoveinmulti'>" +
"<cfoutput query='serial'><input type='text' name='vertifidate_" + count + "' value='#verification_date#'>&nbsp;&nbsp;</cfoutput>" +
"&nbsp;&nbsp;&nbsp;&nbsp;Current Date:&nbsp;&nbsp;" +
"<input type='checkbox' name='currentdatevert_" + count + "' onClick=vertifidate_" + count + ".value=fill_date()>" +
"</td>" +
"</tr>" +
"</table>";
 
<!--- Adds Extra fields for Dept/Vendor Responsibility  --->
newdiv.innerHTML = newdiv.innerHTML +
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
"<tr>" +
"<td class='red' id='paddingformultitop'>" +
"Dept/Vendor Responsibility*:&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;"  +
"<select name='deptvendor_" + count + "'>" +
"<option value='' selected>Make A Selection</option>" +
"<cfoutput query='getDeptVendor'>" +
"<option value='#pk_deptVendor#'<cfif #pk_deptVendor# is #dept_responsibility#>selected</cfif>>#pk_deptVendor#</option>" +
" </cfoutput>" +
"</select>" +
"</td>" +
"</tr>" +
"</table>";
 
<!--- Adds Extra fields for RMA Data Only  --->
newdiv.innerHTML = newdiv.innerHTML +
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
"<tr>" +
"<td id='paddingformultitop'>" +
"RMA Data Only:&nbsp;&nbsp;&nbsp;&nbsp;" +
"</td>" +
"<td class='rmanmoveinmulti'>" +
"( You may enter up to 500 characters. )"+
"<br/>" +
"<cfoutput query='serial'><textarea maxlength='500' onkeyup='return ismaxlength(this)' onkeydown='return ismaxlength(this)' rows='4' cols='60' name='rma_" + count + "' >#rma_data#</textarea></cfoutput> " +
"</td>" +
"</tr>" +
"</table>" +
"<input type='hidden' name='serialcount' value='" + count + "'>";
 
<!--- Adds Delete to every ticket  --->
newdiv.innerHTML = newdiv.innerHTML +
"<table class='zpExpandedTable' id='resoltable' cellpadding='1' cellspacing='0'>" +
"<tr>" +
"<td>" +
"<input type='button' class='removeticket' value='Remove Serial &quot;"+count +"&quot;' onclick=\"removeElement(\'"+divIdName+"\')\"></a>" +
"</td>" +
"</td>" +
"</tr>" +
"</table><br>";
 
 document.getElementById(divName).appendChild(newdiv);
 
} 
</script>

i was using this after i submitted my form to loop through it. it was used to submit the form fields and also show a print screen on what was previously entered.

<CFSET machineListLen = listLen(Form.serialcount)>
<CFLOOP from="1" to="#machineListLen#" index="machineCount">
 <CFSET serialnum       = "Form.serialnum_" & machineCount>
 <CFSET modelno         = "Form.modelno_" & machineCount>
 <CFSET producttype     = "Form.producttype_" & machineCount>
 <CFSET softhardware    = "Form.softhardware_" & machineCount>
 <CFSET resolution      = "Form.resolution_" & machineCount>
 <CFSET resdate         = "Form.resdate_" & machineCount>
 <CFSET resvertified    = "Form.resvertified_" & machineCount>
 <CFSET vertifidate     = "Form.vertifidate_" & machineCount>
 <CFSET deptvendor      = "Form.deptvendor_" & machinecount>
 <CFSET hardwarefailure = "Form.hardwarefailure_" & machineCount>
 <CFSET rma             = "Form.rma_" & machineCount>
 <CFSET thedescription  = "Form.thedescription_" & machineCount>
 
#evaluate(modelno)#....an so on.

but i am not sure if i can combine the above with what i have now because i am showing previously entered data an not entering the data.

Thank you for all the help,
Rach

[bonneylake]

It seems as though this line shows the description (line 83):

<cfloop query="description"><textarea maxlength='1000' onkeyup='return descriptionmaxlength(this)' onkeydown='return descriptionmaxlength(this)'rows='4' cols='60' name="thedescription_#count#">#description#</textarea></cfloop> 

Is the problem that instead of one description per serial, it's showing all descriptions side by side or is it that multiple descriptions can appear under one serial, but they're just not in the right place?

Hey Acoder,

Yes its showing them but its putting them side by side. It shows multiple descriptions. like for example

serial information 1
description 1 description 2

serial information 2
description 1 description 2

when it needs to be like

serial information 1
description 1

serial information 2
description 2

Thank you,
Rach

[acoder]

Is description not a field in the serial table? Why have you got a separate query for description?

[bonneylake]

Is description not a field in the serial table? Why have you got a separate query for description?

Hey Acoder,

No the description is not in the serial table its in the description table. An i had forgotten about that till i looked at it yesterday when i added 2 descriptions.

Thank you,
Rach

[acoder]

Is it one description per serial or could you have more than one per serial? What kind of query are you using to retrieve the descriptions?

[bonneylake]

Is it one description per serial or could you have more than one per serial? What kind of query are you using to retrieve the descriptions?

Hey Acoder,

Its definitely one description per serial. an this is what i am using to retrieve the description

<!---Shows what was previously entered into description table--->
<cfquery name="description" datasource="CustomerSupport">
        SELECT fk_serialNo,fk_ticketNo,description
         FROM dbo.tbl_CS_notes_descr
         WHERE fk_ticketNo = #URL.pk_ticketID#
</cfquery>

Thank you,
Rach

[acoder]

If it's always only one, why not store in the serial table? If that's not an option, make a join query when getting the serial, so the description is also included and you don't need two separate queries.

[bonneylake]

If it's always only one, why not store in the serial table? If that's not an option, make a join query when getting the serial, so the description is also included and you don't need two separate queries.

Hey Acoder,

That is a brillant idea (why didn't i think of that!). An well i tried it but i am having a weird problem.

This is what its doing

serial number: 963
description: this is the description

serial number: 999
description: this is the description

serial number: 963
description: this is the second description

serial number: 999
description: this is the second description

an it needs to be

serial number: 963
description: this is the description

serial number: 999
description: this is the second description

here is what i have for the cfquery. it has the serial an description in it now.

<cfquery name="serial" datasource="CustomerSupport">
        SELECT pka_serialNo,pkb_fk_ticketNo,model_no,product_type,software_hardware,
       resolution,resolution_date,verification_date,rma_data,type_hardware_failure,
        dept_responsibility,resolution_verified_by,fk_serialNo,fk_ticketNo,description
        FROM dbo.tbl_CS_serial, dbo.tbl_CS_notes_descr
        WHERE pkb_fk_ticketNo = #URL.pk_ticketID# and fk_ticketNo = #URL.pk_ticketID#
</cfquery>

that an inbetween the div i had this, i took the cfloop off from around description.

<table class="zpExpandedTable" id="resoltable" cellpadding="3" cellspacing="0">
<tr>
<td id="paddingformutli">
Description:&nbsp;&nbsp;
</td>
<td class="descriptionmoveinmulti">
( You may enter up to 500 characters. )
<br>
<cfloop query="description"><textarea maxlength="500" onkeyup="return ismaxlength(this)" onkeydown="return ismaxlength(this)" rows="4" cols="60" name="thedescription_#count#">#description#</textarea></cfloop> 
</td>
</tr>
</table>

but besides that everything else is the same so i am not sure why its putting the results twice. Any ideas?

Thank you,
Rach

[acoder]

That's because you've joined the query without removing the duplicates by matching up the IDs. See left join.

[bonneylake]

That's because you've joined the query without removing the duplicates by matching up the IDs. See left join.

Hey Acoder,

I read it but i think i got something confused.do i need to do to each field dbo.tbl_CS_serial.pka_serialNo?

<cfquery name="serial" datasource="CustomerSupport">
        SELECT pka_serialNo,pkb_fk_ticketNo,model_no,product_type,software_hardware,
       resolution,resolution_date,verification_date,rma_data,type_hardware_failure,
        dept_responsibility,resolution_verified_by,fk_serialNo,fk_ticketNo,description
        FROM dbo.tbl_CS_serial
        LEFT JOIN dbo.tbl_CS_notes_descr
        ON pkb_fk_ticketNo=fk_ticketNo
        WHERE pkb_fk_ticketNo = #URL.pk_ticketID# and fk_ticketNo = #URL.pk_ticketID#
</cfquery>

Thank you,
Rach

[bonneylake]

Hey Acoder,

I figured out what i did wrong. Here is what the results where.

<!---Shows what was previously entered into serial and description table--->
<cfquery name="serial" datasource="CustomerSupport">
        SELECT pka_serialNo,pkb_fk_ticketNo,model_no,product_type,software_hardware,
       resolution,resolution_date,verification_date,rma_data,type_hardware_failure,
        dept_responsibility,resolution_verified_by,fk_serialNo,fk_ticketNo,description
        FROM dbo.tbl_CS_serial
        LEFT JOIN dbo.tbl_CS_notes_descr
        ON dbo.tbl_CS_serial.pkb_fk_ticketNo=dbo.tbl_CS_notes_descr.fk_ticketNo and
        dbo.tbl_CS_serial.pka_serialNo=dbo.tbl_CS_notes_descr.fk_serialNo
        WHERE pkb_fk_ticketNo = #URL.pk_ticketID# and fk_ticketNo = #URL.pk_ticketID#
        ORDER BY pkb_fk_ticketNo
</cfquery>

Thank you again for all the help!!! :)

Rach

[acoder]

Good work, though I'm not sure about the where clause. I think one of them is probably not needed.