Write a program to print out the binary value of a 16 bit number.

[zetlyn]

#include <stdio.h>
#include <stdlib.h>

int main()
{
int i, count, mask;

i = 0xF5A2;
mask = 0x8000;
printf("Hex value= %x, Binary=", i, mask);

for(count=0;count<15;count++)
{
if(i & mask)
{
printf("1");

}
else
{
printf("0");
mask = mask >> 1;
}

}

return 0;
}

[zetlyn]

what am i missing? every time i use the program i get a binary of 111111111111111

[weaknessforcats]

Your mask is not shifting right unless you print a 0. Since you don't print 0, the mask never shifts.

[donbock]

Look at the first printf (the one that prints the hex value). You pass two arguments after the format string (i and mask), but the format string has only one conversion specifier. You might as well not pass mask.

The int type is allowed to be as small as 16 bits. If it is indeed 16 bits for your compiler, then odd things could happen when the most significant bit is set. You might want to declare i and mask as long or unsigned int to avoid inadvertently creating negative values. You will have to update the format string used to print i accordingly.

You should get in the habit of printing a newline at the end of every line to insure the output buffer is flushed. Refer to this earlier post for an explanation of buffered versus nonbuffered I/O.