deprecated conversion from string constant to char

[ikkyizzy]

 
#include<iomanip>
#include<iostream>
#include<conio.h>
#include<string.h>
#include<vector>
#include<list>
#include"Movie.h"
using namespace std;
 
 
 
//Passanger class
class Passenger{
private:
int bookingRefNo;
char name[50];
int numAdult;
int numChildren;
int numFlights;
double totalPrice;
 
public:
Passenger();
 
//setter methods retun type
void setBookingRef();
void setName(char inName[50]);
void setNumAdult(int noAdult);
void setNumChildren(int noChild);
void setNumFlight(int noFlight);
void setTotalPrice(double inTotalPrice);
 
//getter method initialization
int getBookingRef();
char * getName();
int getNumAdult();
int getNumChildren();
int getNumFlight();
double getTotalPrice();
};
//setter methods
Passenger::Passenger(){
setBookingRef();
}
 
void Passenger::setBookingRef(){
static int count=500;
count++;
 
bookingRefNo=count;
}
void Passenger::setName(char inName[50]){
strcpy(name,inName);
}
void Passenger::setNumAdult(int noAdult){
numAdult = noAdult;
}
void Passenger::setNumChildren(int noChild){
numChildren = noChild;
}
void Passenger::setNumFlight(int noFlight){
numFlights = noFlight;
}
void Passenger::setTotalPrice(double inTotalPrice){
totalPrice = inTotalPrice;
}
//getter methods
int Passenger::getBookingRef(){
return bookingRefNo;
}
char* Passenger::getName(){
return name;
}
int Passenger::getNumAdult(){
return numAdult;
}
int Passenger::getNumChildren(){
return numChildren;
}
int Passenger::getNumFlight(){
return numFlights;
}
double Passenger::getTotalPrice(){
return totalPrice;
}
 
class Flight{
//initialization
private:
int flightNo;
char orgin[50];
char destination[50];
char date[50];
char deparR[50];
double price;
int childPerc;
vector<Movie> movieList;
 
public:
 
Flight();
Flight(char InOrgin[50], char InDesi[50], char InDate[50], char InDeparr[50], double inPrice, int ChildPerc);
void SetflightNo();
void SetOrgin(char InOrgin[50]);
void SetDesti(char InDesti[50]);
void SetDate(char InDate[50]);
void SetDeparr(char InDeparr[50]);
void SetPrice(double InPrice);
void SetChildPerc(int InChildPerc);
 
int  GetflightNo();
char* GetOrgin();
char* GetDesti();
char* GetDate();
char* GetDeparr();
double GetPrice();
int GetChildPerc();
void addMovie(Movie objMov);
 
 
};
Flight::Flight(){
SetflightNo();
SetOrgin("null");
SetDesti("null");
SetDeparr("null");
SetPrice(0.0);
SetChildPerc(0);
}
Flight::Flight(char *InOrgin, char *InDesi, char *InDate, char *InDeparr, double inPrice, int InChildPerc){
SetflightNo();
SetOrgin(InOrgin);
SetDesti(InDesi);
SetDeparr(InDeparr);
SetPrice(inPrice);
SetChildPerc(InChildPerc);
}
//setter methods
void Flight::SetflightNo(){
static int flightCount=100;
flightCount++;
flightNo = flightCount;
 
}
 
void Flight:: SetOrgin(char InOrgin[50]){
strcpy(orgin,InOrgin);
}
 
void Flight::SetDesti(char InDesti[50]){
strcpy(destination,InDesti);
}
void Flight::SetDate(char InDate[50]){
strcpy(date,InDate);
}
void Flight::SetDeparr(char InDeparr[50]){
strcpy(deparR,InDeparr);
}
void Flight::SetPrice(double InPrice){
price = InPrice;
}
void Flight::SetChildPerc(int InChildPerc){
childPerc = InChildPerc;
}
//getter methods
int Flight::GetflightNo(){
return flightNo;
}
 
char* Flight:: GetOrgin(){
return orgin;
}
 
char* Flight::GetDesti(){
return destination;
}
char* Flight::GetDate(){
return date;
}
char* Flight::GetDeparr(){
return deparR;
}
 
double Flight::GetPrice(){
return price;
}
 
int Flight::GetChildPerc(){
return childPerc;
}
 
void Flight::addMovie(Movie objMov){
movieList.push_back(objMov);
} 
//Business Flight Class
class BusinessFlight : public Flight{
private:
double rate;
 
public:
 
BusinessFlight();
BusinessFlight(char *InOrgin, char *InDesi, char *InDate, char *InDeparr, double inPrice, int ChildPerc, double inRate);
void SetRate(double InRate);
double GetRate();
Passenger Book(Passenger obj);
};
 
BusinessFlight::BusinessFlight():Flight(){
SetRate(0.0);
}
 
BusinessFlight::BusinessFlight(char *InOrgin, char *InDesi, char *InDate, char *InDeparr, double inPrice, int ChildPerc, double 
 
inRate):Flight(InOrgin,InDesi,InDate,InDeparr,inPrice,ChildPerc)
{
SetRate(inRate);
}
 
 
Passenger BusinessFlight::Book(Passenger obj){
double adultPrice;
double childPrice;
double totalPrice;
adultPrice = obj.getNumAdult() * GetPrice() * GetRate();
childPrice = obj.getNumChildren() * (double) GetChildPerc()/100 * GetRate();
totalPrice = adultPrice + childPrice;
obj.setTotalPrice(totalPrice);
obj.setNumFlight(GetflightNo());
return obj;
}
//setter methods
void BusinessFlight::SetRate(double InRate){
rate = InRate;
}
//getter methods
double BusinessFlight::GetRate(){
return rate;
}
 
//class economy flight
class EconomyFlight : public Flight{
private:
public:
EconomyFlight();
    EconomyFlight(char *InOrgin, char *InDesi, char *InDate, char *InDeparr, double inPrice, int ChildPerc);
Passenger Book(Passenger obj);
};
 
EconomyFlight::EconomyFlight(){
 
}
 
Passenger EconomyFlight::Book(Passenger obj){
double adultPrice;
double childPrice;
double totalPrice;
adultPrice = obj.getNumAdult() * GetPrice();
childPrice = obj.getNumChildren() * (double) GetChildPerc()/100;
totalPrice = adultPrice + childPrice;
obj.setTotalPrice(totalPrice);
obj.setNumFlight((int)GetflightNo());
return obj;
}
EconomyFlight::EconomyFlight(char *InOrgin, char *InDesi, char *InDate, char *InDeparr, double inPrice, int ChildPerc):Flight
 
(InOrgin,InDesi,InDate,InDeparr,inPrice,ChildPerc){
 
}
 
 
 
//Travel Agent Class
class TrevelAgent{
private:
char *name;
list<Passenger> ListPassenger;
list<BusinessFlight> ListBusiness;
list<EconomyFlight> ListEconomy;
 
public:
void setName(char *InName);
char* getName();
void addEconomy(EconomyFlight objEcono);
void addBusiness(BusinessFlight objBusiness);
void addPassenger(Passenger objPassenger);
void FlightList();
void PassengerList();
void DeleteFlight(int FlightNo);
void DeletePassneger(int Pid);
    void BookFlight(int PID , int FID);
};
 
void TrevelAgent::addEconomy(EconomyFlight objEcono){
ListEconomy.push_back(objEcono);
}
 
void TrevelAgent::addBusiness(BusinessFlight objBusiness){
ListBusiness.push_front(objBusiness);
}
 
void TrevelAgent::addPassenger(Passenger objPassenger){
ListPassenger.push_back(objPassenger);
}
//setter methods
void TrevelAgent::setName(char *InName){
name= InName;
}
//getter methods
char* TrevelAgent::getName(){
return name;
}
 
void TrevelAgent::FlightList(){
cout<<"ID"<<setw(10)<<"Orgin"<<setw(20)<<"Destination"<<setw(10)<<"Date"<<setw(10)<<"Price\n";
list<BusinessFlight>::iterator dis;
for(dis=ListBusiness.begin(); dis!=ListBusiness.end();dis++){
BusinessFlight b = *dis;
 
cout<<b.GetflightNo()<<setw(10)<<b.GetOrgin()<<setw(20)<<b.GetDesti()<<setw(10)<<b.GetDate()<<setw(10)<<b.GetPrice()
 
<<"\n";
}
list<EconomyFlight>::iterator itrEcon;
for(itrEcon=ListEconomy.begin();itrEcon!=ListEconomy.end();itrEcon++){
EconomyFlight e = *itrEcon;
cout<<e.GetflightNo()<<setw(10)<<e.GetOrgin()<<setw(20)<<e.GetDesti()<<setw(10)<<e.GetDate()<<setw(10)<<e.GetPrice()
 
<<"\n";
}
 
}
 
void TrevelAgent::PassengerList(){
cout<<"Booking id"<<setw(10)<<"Name"<<setw(20)<<"No Adult"<<setw(10)<<"No of Child"<<setw(10)<<"Price\tFlightID\n";
list<Passenger>::iterator itrPasn;
for(itrPasn=ListPassenger.begin(); itrPasn!=ListPassenger.end();itrPasn++){
Passenger p = *itrPasn;
cout<<p.getBookingRef()<<setw(10)<<p.getName()<<setw(20)<<p.getNumAdult()<<setw(10)<<p.getNumChildren()<<setw
 
(10)<<p.getTotalPrice()<<"\t"<<p.getNumFlight()<<"\n";
}
}
 
void TrevelAgent::DeleteFlight(int FlightNo){
list<BusinessFlight>::iterator dis;
list<BusinessFlight>::iterator currentpos;
int flag =0;
for(dis=ListBusiness.begin(); dis!=ListBusiness.end();dis++){
BusinessFlight b = *dis;
int myFli = b.GetflightNo();
if(FlightNo == myFli ){
currentpos = dis;
flag = 1;
}
}
 
list<EconomyFlight>::iterator itrEcon;
list<EconomyFlight>::iterator EconCurrent;
for(itrEcon=ListEconomy.begin(); itrEcon!=ListEconomy.end();itrEcon++){
EconomyFlight e = *itrEcon;
int myFli = e.GetflightNo();
if(FlightNo == myFli ){
EconCurrent = itrEcon;
flag = 2;
}
}
 
if (flag==1){
char ch;
cout << "Do you want Delete Flight " << FlightNo << " :";
cin >> ch;
if(ch=='y'||ch=='Y'){
ListBusiness.erase(currentpos);
cout <<"Deleted......." <<endl;
}
}else{
cout << "Could not found !!!!!"<<endl;
}
 
if (flag==2){
char ch;
cout << "Do you want Delete Flight " << FlightNo << " :";
cin >> ch;
if(ch=='y'||ch=='Y'){
ListEconomy.erase(EconCurrent);
cout <<"Deleted......." <<endl;
}
}else{
cout << "Could not found !!!!!"<<endl;
}
}
 
void TrevelAgent::DeletePassneger(int PID){
list<Passenger>::iterator itrPas;
list<Passenger>::iterator currentpos;
int flag =0;
for(itrPas=ListPassenger.begin(); itrPas!=ListPassenger.end();itrPas++){
Passenger p = *itrPas;
int myFli = p.getBookingRef();
if(PID == myFli ){
currentpos = itrPas;
flag = 1;
}
}
 
 
if (flag==1){
char ch;
cout << "Do you want Delete Passenger " << PID << " :";
cin >> ch;
if(ch=='y'||ch=='Y'){
ListPassenger.erase(currentpos);
cout <<"Deleted......." <<endl;
}
}else{
cout << "Could not found !!!!!"<<endl;
}
 
}
 
void TrevelAgent::BookFlight(int PID , int FID){
 
list<Passenger>::iterator itrPas;
 
Passenger PC ;
int flag =0;
for(itrPas=ListPassenger.begin(); itrPas!=ListPassenger.end();itrPas++){
Passenger p = *itrPas;
int myFli = p.getBookingRef();
if(PID == myFli ){
 
PC = *itrPas;
flag = 1;
}
}
 
 
list<BusinessFlight>::iterator dis;
 
BusinessFlight BC;
 
 
for(dis=ListBusiness.begin(); dis!=ListBusiness.end();dis++){
BusinessFlight b = *dis;
int myFli = b.GetflightNo();
if(FID == myFli ){
 
BC = *dis;
flag = 1;
}
}
 
list<EconomyFlight>::iterator itrEcon;
 
EconomyFlight EC;
for(itrEcon=ListEconomy.begin(); itrEcon!=ListEconomy.end();itrEcon++){
EconomyFlight e = *itrEcon;
int myFli = e.GetflightNo();
if(FID == myFli ){
 
EC  = *itrEcon;
flag = 2;
}
}
 
if (flag==1){
 
for(itrPas=ListPassenger.begin(); itrPas!=ListPassenger.end();itrPas++){
Passenger p = *itrPas;
int myFli = p.getBookingRef();
if(PID == myFli ){
 
*itrPas = BC.Book(PC);
 
}
}
}
 
if (flag==2){
 
for(itrPas=ListPassenger.begin(); itrPas!=ListPassenger.end();itrPas++){
Passenger p = *itrPas;
int myFli = p.getBookingRef();
if(PID == myFli ){
 
*itrPas = EC.Book(PC);
 
}
}
}
}
//Travel Console
 
class TravelConsole{
private:
BusinessFlight *objBusiness;
EconomyFlight *objEconomy;
Flight* objFlght;
Movie *objMovie;
TrevelAgent objAgent;
public:
void CreateBusinessFlight();
void CreateEconomyFlight();
void CreateMovie();
void ListFlight();
void CreatePassenger();
void DeleteFlight();
void DeletePassenger();
void Booking();
TrevelAgent getTrevelAgent();
};
 
TrevelAgent TravelConsole::getTrevelAgent(){
return objAgent;
}
 
void TravelConsole::CreateBusinessFlight(){
char orgin[50];
char destination[50];
char date[50];
char deparr[50];
double price;
int childPercentage;
double rate;
cout<<"Business Flight Detail"<<endl;
cout <<"-------------------------------------"<<endl;
cout << "Enter the Flight Origin  :";
cin >> orgin;
cout << "Enter the Flight Destination :";
cin >> destination;
cout << "Enter Flight Date :";
cin >> date;
cout << "Enter the Depar and Arrival Time (dep 1:00 , arr 3:00):";
cin >> deparr;
cout << "Enter the Price :" ;
cin >> price;
cout << "Enter the Child Percentage :";
cin >> childPercentage;
cout << "Enter the Rate :";
cin >> rate;
BusinessFlight obiBussin;
obiBussin.SetOrgin(orgin);
obiBussin.SetDesti(destination);
obiBussin.SetDate(date);
obiBussin.SetDeparr(deparr);
obiBussin.SetPrice(price);
obiBussin.SetChildPerc(childPercentage);
obiBussin.SetRate(rate);
objAgent.addBusiness(obiBussin);
char ch;
char no='y';
cout <<"Do you want add Movie to this Flight (Y/N) :";
cin >>ch;
if(ch=='y'||ch=='Y'){
while(no!='n'){
CreateMovie();
cout <<"Movied added" <<endl;
cout <<"Do you add another Movie (Y/N) :";
cin >> no;
};
}
 
}
 
void TravelConsole::CreateEconomyFlight(){
char orgin[30];
char destination[30];
char date[30];
char deparr[30];
double price;
int childPercentage;
 
cout<<"Economy Flight Detail"<<endl;
cout <<"-------------------------------------"<<endl;
cout << "Enter the Flight Origin  :";
cin >> orgin;
cout << "Enter the Flight Destination :";
cin >> destination;
cout << "Enter Flight Date :";
cin >> date;
cout << "Enter the Depar and Arrival Time (dep 1:00 , arr 3:00) :";
cin >> deparr;
cout << "Enter the Price :" ;
cin >> price;
cout << "Enter the Child Percentage :";
cin >> childPercentage;
 
EconomyFlight EconoFlight;
EconoFlight.SetOrgin(orgin);
EconoFlight.SetDesti(destination);
EconoFlight.SetDate(date);
EconoFlight.SetDeparr(deparr);
EconoFlight.SetPrice(price);
EconoFlight.SetChildPerc(childPercentage);
objAgent.addEconomy(EconoFlight);
 
char ch;
cout <<"Do you want add Movie to this Flight (Y/N) :";
cin >>ch;
if(ch=='y'||ch=='Y'){
CreateMovie();
cout <<"Movied added" <<endl;
}
}
 
void TravelConsole::CreatePassenger(){
int bookingRef;
char name[50];
int numAdult;
int numChild;
int numFlight;
double totalPrice;
 
cout<<"Create Persion"<<endl;
cout <<"-------------------------------------"<<endl;
cout << "Enter the Name:";
cin >> name;
cout << "Enter Number of Adult :";
cin >> numAdult;
cout << "Enter Number of Children:";
cin >> numChild;
Passenger objPasn;
objPasn.setName(name);
objPasn.setNumAdult(numAdult);
objPasn.setNumChildren(numChild);
objPasn.setNumFlight(0);
objPasn.setTotalPrice(0.0);
objAgent.addPassenger(objPasn);
}
 
void TravelConsole::CreateMovie(){
char title [40];
cout<<"Create Flight"<<endl;
cout <<"-------------------------------------"<<endl;
cout << "Enter Movie Name  :";
cin >> title;
objMovie = new Movie(title);
}
 
void TravelConsole::DeleteFlight(){
int FID;
cout << "Please Enter the Flight No :";
cin >> FID;
objAgent.DeleteFlight(FID);
}
 
void TravelConsole::DeletePassenger(){
int PID;
cout << "Please Enter the Passenger ID:";
cin >> PID;
objAgent.DeletePassneger(PID);
}
 
void TravelConsole::Booking(){
int PID;
int FID;
 
objAgent.PassengerList();
cout << "Select A Passenger :";
cin >> PID;
objAgent.FlightList();
cout << "Select A Select a Flight:";
cin >> FID;
objAgent.BookFlight(PID,FID);
}
 
void TravelConsole::ListFlight(){
 
}
 
int main(){
//main menu
TravelConsole travel;
int v=10;
 
int menuloc;
do{
cout << "MAIN MENU" << endl;
cout << "----------------------" <<endl;
cout <<"1. Create Business Flight " <<endl;
cout <<"2. Create Economy Flight " <<endl;
cout <<"3. Flight List " << endl;
cout <<"4. Create Passenger " <<endl;
cout <<"5. Passenger list " <<endl;
cout <<"6. Delete Flight " << endl;
cout <<"7. Delete Passenger " << endl;
cout <<"8. Booking " << endl;
cout <<"9. Exit " << endl;
cout <<"" << endl;
cout <<"Please Select a Choice: " <<flush;
cin >>menuloc;
 
switch(menuloc){
case 1: {    
travel.CreateBusinessFlight();
break;
}
case 2: {
travel.CreateEconomyFlight();
break;
}
 
case 3:{
travel.getTrevelAgent().FlightList();
break;
  }
case 4:{
travel.CreatePassenger();
break;
  }
case 5:{
travel.getTrevelAgent().PassengerList();
break;
  }
case 6:{
travel.DeleteFlight();
break;
  }
case 7:{
travel.DeletePassenger();
break;
  }
case 8:{
travel.Booking();
break;
  }
case 9:{
return 0;
break;
  }
}
 
 
}while(menuloc!=v);
 
getchar();
system("pause");
return 0;
}
 
 

I am getting the error in Fligh:Flight() when the program is run.
Any help is appreciated!

Thanks

[weaknessforcats]

using the str... function from C (strcpy, strstr, etc) are all deprecated in C++ because you should be using the C++ string class plus the old C functions need a \0 to terminate. If they don't find one, they just continue on, corrupt your memory and crash your program.

Beyond that, you are passing the address of local variables around the program. Not good. Use heap allocated variables. Especially the arrays in places like your Flight class. There is no code top prevent array overrun. Typically you would have a string object in your class which handles this problem. If you aren't allowed to do that, you should determine the size of he data to insert in the class object, then allocate that much memory, then copy the data to the allocation. All you need in your class definition is a pointer to the allocation. The effect is to remove all those hard-coded array lengths.

[ikkyizzy]

Thanks for the help. ..................