I have another C++ mess on my hands

[gneisler]

I can not get this program to work.

#include <iostream>
#include <iomanip>
#include <string>
 
 
using namespace std;
 
const int SIZE = 80;
 
 
 
class Student
{
protected:
 
    int social;
    string name;
    char *NamePtr;
public:
    Student (int = 999999999 , char [] = "unassigned");
    void setSSN(long);
    long getSSN();
    void setName(char[]);
    char* getName();
    virtual double calcGPA();
};
 
Student::Student(int ssn, string studentname)
{
    social = ssn;
    strcpy (name, studentname);
}
 
void Student::setSSN(int SSN)
{
            social = SSN;
        return;
}
 
long Student::getSSN()
{
    return (social);
}
 
void Student::setName(char name2)
{
        strcpy (name, name2);
        return;
}
 
char* Student::getName()
{    
    NamePtr = name;
    return (NamePtr);
}
 
double Student::calcGPA()
{
    cout << "Student calcGPA" << endl;
    return (0);
}
 
class GradStudent : public Student 
{
private:
    char status;
public:
    GradStudent (char = 'A');
    virtual double calcGPA();
    void SetStatus(char);
};
 
GradStudent::GradStudent(char grade)
{
    status = grade;
}
 
double GradStudent::calcGPA()
{
    double GPA = 0.0;
    if (status == 'A' || status == 'a')
        GPA = 4.0;
    cout << "GradStudent calcGPA";
    return (GPA);
}
 
void GradStudent::SetStatus (char stat)
{
    status = stat;
    return;
}
 
class UnderGradStudent : public Student
{
private:
    double CreditHrs;
    double QualityPts;
public:
    UnderGradStudent ( double = 0, double = 0);
    virtual double calcGPA ();
    void setCredits(int);
    void setQuality(int);
};
 
UnderGradStudent::UnderGradStudent(double Hours, double Points)
{
    CreditHrs = Hours;
    QualityPts = Points;
    if (Hours < 0)
        CreditHrs = 0;
    if (Points < 0)
        QualityPts = 0;
}
 
double UnderGradStudent::calcGPA ()
{
    double GPA = 0.0;
    if (CreditHrs > 0)
        GPA = QualityPts / CreditHrs;
    cout << "UnderGraduateStudent calcGPA";
    return (GPA);
}
 
void UnderGradStudent::setCredits (int C)
{
    CreditHrs = C;
    if (C < 0)
        CreditHrs = 0;
    return;
}
 
void UnderGradStudent::setQuality (int Q)
{
    QualityPts = Q;
    if (Q < 0)
        QualityPts = 0;
    return;
}
 
 
int main()
{
    char ans = 'n';
    char grade;
    string StudentName;
    double StudentSSN;
    int choice, points, credits, continue;
 
 
    Student* a = NULL;
 
    do
    {
        cout << "Enter 1 for undergrad.\nEnter 2 for grad" << endl << "-->";
        cin >> choice;
 
        if (choice == 1)
        {
            a = new UnderGradStudent;
 
            cin.ignore();
            cout << "Please enter student name: ";
            cin.getline(StudentName, SIZE);
            a->setName(StudentName);        
        }
 
        else if (choice == 2)
        {
            a = new GradStudent;
 
            cin.ignore();
            cout << "Please enter student name: ";
            cin.getline(StudentName, SIZE);
            a->setName(StudentName);
 
 
        }
 
 
        else continue;
 
 
        cout <<  "\nName: " << a->getName() << " SSN: " << a->getSSN() << " GPA: "
            << setiosflags(ios::fixed | ios::showpoint) << setprecision(2) << a->calcGPA() << endl;
 
 
        delete a;
        a = NULL;
 
        cout << "Continue?: ";
        cin >> continue;
        cin.ignore();
        cout << endl;
 
    }while (toupper(ans) == 'Y');
 
 
    cout << "Press ENTER to quit.";
    cin.ignore( 1000, '\n' );
 
 
    return 0;
}

[weaknessforcats]

There are lots of errors here. Foremost is that some of your member functions have different arguments from what is in the class declaration.

etc..

I suggest you create a new source file ana have only your class definition and a main:

class Student
{
 
};
 
int main()
{
   Student s;
}

Verify this compiles.

Now add member data and a constructor.

Verify this compiles.
Verify the program works.

Now add another member function.

Add code in main() to test it.
Verify this compiles.
Verify the program still works.


By working gradually you guarantee the program compiles and runs correctly so any errors would be in the last bit of code you added. Just work through a step at a time.

I see you are using things like strcpy in a C++ program. Bad news. YOu use the assignment operator on string objects.

Post again and let me know how you are coming along.

[gneisler]

Some of the error messages from the compiler does not make sense, well for me they do not, being new to C++.

#include <iostream>
#include <iomanip>
#include <string>
using namespace std;
 
class Student
{
protected:
 
    int social;
    string name;
    string *NamePtr;
public:
    Student (); // Default constructor
    Student(int ssn, string StudentName);
    void setSSN(int);
    int getSSN();
    void setName(string);
    string* getName();
    virtual double calcGPA();
};
 
Student ::Student()
{
}
Student::Student(int ssn, string  StudentName)
{
 
    social = ssn;
    strcpy (name, Studentname);
 
    return;
}
 
void Student::setSSN(int SSN)
{
        social = SSN;
        return;
}
 
int Student::getSSN()
{
    return (social);
}
 
void Student::setName(string name2)
{
        strcpy (name, name2);
        return;
}
 
string* Student::getName()
{    
    NamePtr = name;
    return (NamePtr);
}
 
double Student::calcGPA()
{
    cout << "Student calcGPA" << endl;
    return (0);
}
 
class GradStudent : public Student 
{
private:
    char Status;
public:
    GradStudent (char = 'A');
    virtual double calcGPA();
    void SetStatus(char);
};
 
GradStudent::GradStudent(char grade)
{
    Status = grade;
}
 
double GradStudent::calcGPA()
{
    double GPA = 0.0;
    if (Status == 'A' || Status == 'a')
        GPA = 4.0;
    cout << "GradStudent calcGPA";
    return (GPA);
}
 
void GradStudent::SetStatus (char stat)
{
    Status = stat;
    return;
}
 
class UnderGradStudent : public Student
{
private:
    double CreditHrs;
    double QualityPts;
public:
    UnderGradStudent ( double = 0, double = 0);
    virtual double calcGPA ();
    void setCreditHrs(int);
    void setQuality(int);
};
 
UnderGradStudent::UnderGradStudent(double Hours, double Points)
{
    CreditHrs = Hours;
    QualityPts = Points;
    if (Hours < 0)
        CreditHrs = 0;
    if (Points < 0)
        QualityPts = 0;
}
 
double UnderGradStudent::calcGPA ()
{
    double GPA = 0.0;
    if (CreditHrs > 0)
        GPA = QualityPts / CreditHrs;
    cout << "UnderGraduateStudent calcGPA";
    return (GPA);
}
 
void UnderGradStudent::setCreditHrs (int C)
{
    CreditHrs = C;
    if (C < 0)
        CreditHrs = 0;
    return;
}
 
void UnderGradStudent::setQuality (int Q)
{
    QualityPts = Q;
    if (Q < 0)
        QualityPts = 0;
    return;
}
 
 
int main()
{
    char ans = 'n', grade, Status;
    string StudentName;
    int StudentSSN;
    int code, CreditHrs, points;
 
 
    Student* a = NULL;
 
    do
    {
        cout << "Enter 1 for undergrad.\nEnter 2 for grad." << endl << "-->";
        cin >> code;
 
        if (code == 1)
        {
            a = new UnderGradStudent;
 
            cin.ignore();
            cout << "Enter Student name: ";
            cin.getline(StudentName);
            a->setName (StudentName);
            cout << "Enter Student SSN: ";
            cin >> StudentSSN;
            a->getSSN();
 
            cout << "Enter credit hours: ";
            cin >> CreditHrs;
            a->setCreditHrs(CreditHrs);
 
            cout << "Enter quality points: ";
            cin >> points;
            a->setQuality(points);
            cout << endl;
 
 
        }
 
        else if (code == 2)
        {
            a = new GradStudent;
 
            cin.ignore();
            cout << "Enter Student name: ";
            a->getName(StudentName);
 
 
            cout << "Enter Student SSN: ";
            cin >> StudentSSN;
            a->setSSN(StudentSSN);
 
            cout << "Enter Status: ";
            cin >> Status;
            a->SetStatus(Status);
            cout << endl;
        }
 
 
 
 
 
        cout <<  "\nName: " << a->getName() << " SSN: " << a->getSSN() << " GPA: "
            << setiosflags(ios::fixed | ios::showpoint) << setprecision(2) << a->calcGPA() << endl;
 
 
        delete a;
        a = NULL;
 
        cout << "Continue?: ";
        cin >> ans;
        cin.ignore();
        cout << endl;
    }
    while (toupper(ans) == 'Y');
 
 
 
    return 0;
}

[weaknessforcats]

Student::Student(int ssn, string  StudentName)
{
 
    social = ssn;
    //strcpy(name, Studentname);
    name = StudentName;
 
    return;
}

Please stop using strcpy. This is C++ and not C. strcpy only works with char* strings with a \0 terminator.

A C++ string object is not a C-string.

Also:

string* Student::getName()
{
    NamePtr = name;
    return (NamePtr);
}
 

NamePtr is a string* and name is a string. You can't assign an obect to a pointer.

NamePtr is a hacker's delight. It exposes the private data member member and allows you to change it without using a member function. Remove this from your design. You don't need a string*.

The code should be:

string Student::getName()
{
    ///NamePtr = name;
    //return (NamePtr);
    return name;
}

But here is your real problem:

a = new UnderGradStudent;
......
....
cin >> points;
a->setQuality(points);
 

setQuality is a method of UnderGradStudent whereas your variable "a" is a Student. You can only call base class methods from a base class pointer.

Only you know that a points to an UnderGradStudent object. The compiler has no idea.

For this to work you need a setQuality method in Student:

class Student
{
  public:
   virtual void setQuality(int) =0;
};

This code will allow a->setQuality to work and the virtual will cause a call to UnderGradStudent::setQuality.

You might read this: http://bytes.com/topic/c/insights/79...polymorphism-c

Fix your code and post again. And please stop using strcpy or any other C functions from 1968.