Tax Rate Array

[gneisler]

Can not get this array to work. Instead of displaying just one result , I get all of them.

#include <iostream>
#include <iomanip>
#include <cctype>
 
using namespace std;
 
int main ()
{
 
const double income_amt[] = {0,10000,20000,50000,100000};
double tax_rates[]  = {0,0.05,0.10,0.15,0.20};
int i = 0;
double gross_pay = 0 ;
double Taxes;
char ans = 'n';
 
do{
 
    cout<<"Enter the Gross Pay: ";
    cin>> gross_pay;
 
    for(i = 0; i<5; i++){
 
     if(( gross_pay > income_amt[i] ) && ( gross_pay > income_amt[i] )){
 
 
 
     Taxes = (gross_pay * tax_rates[i]);
}
 
     cout<<"The Taxes are: "<<setw(10)<<fixed<<setprecision(2)<<Taxes<<endl;
 
 
      } 
     cout<<"Enter Y or y to continue.  Anything else to quit:"<<endl;
     cin>> ans;
 
}while(toupper(ans)== 'Y');
 
return  0;
 
}
 
 

[weaknessforcats]

I don't understand your issue.

The tax display is inside the loop.

[gneisler]

Instead of just display one answer it is displaying all of them.
For example, I enter the gross pay: 50001 the display should be "Taxes are: 7500.15" but I am getting all of them:
The Taxes are: 0.00
The Taxes are: 2500.05
The Taxes are:5000.10
The Taxes are:7500.15
The Taxes are:7500.15

[weaknessforcats]

I say again your display is inside your loop.

You will get a display on each cycle of the loop, which is what you say is happening.

[donbock]

The for loop on line 22 causes all of the lines between 22 and 34 to execute 5 times. Of those five loop iterations, the tax calculation on line 28 will only execute for those cases where gross_pay > income_amt[i]; for your example of gross pay of 50001, that would be for i=0-3, but not 4.

@weaknessforcats has pointed out that The-Taxes-Are print statement is inside the for-loop but outside of the if-block so it is executed all 5 times through the loop. Do you want to move it inside the if-block (so it executes every time the tax is calculated) or perhaps outside of the for-loop (so it executes exactly once)?

Some other comments:

1. Lines 13 and 14: floating-point variables are imprecise. That may be acceptable for scientific calculations, but most people insist on precision for calculations involving money.
2. Line 24: the if-condition is of the form if(A && A). The "&& A" portion is useless and redundant. That can't be what you want.
3. I assume that your intention is to use
   • tax_rates[0] if the gross pay is between income_amt[0] and income_amt[1];
   • tax_rates[1] if the gross pay is between income_amt[1] and income_amt[2];
   • tax_rates[2] if the gross pay is between income_amt[2] and income_amt[3];
   • tax_rates[3] if the gross pay is between income_amt[3] and income_amt[4]; and
   • tax-rates[4] if the gross pay is above income_amt[4].
   Your current logic does not do this.
   Also, how do you want to handle cases when the gross pay is equal to the low or high income threshold?

xx